exchange

commit 2b95de5a1401fdb921cb77733d4989cacaec4dac
parent 8b447f66974602c4f86f23d6005f473bd9653e99
Author: Christian Grothoff <christian@grothoff.org>
Date:   Tue, 13 Oct 2026 00:11:09 +0200

document X-Forwarded-Proto is assumed to be trusted, only works in reverse-proxy setup

Diffstat:
M
src/include/taler/taler_mhd_lib.h
 | 
6
++++++

1 file changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/include/taler/taler_mhd_lib.h b/src/include/taler/taler_mhd_lib.h
@@ -73,6 +73,12 @@ enum TALER_MHD_GlobalOptions
  * Find out if an MHD connection is using HTTPS (either
  * directly or via proxy).
  *
+ * WARNING: if present, the client-supplied "X-Forwarded-Proto"
+ * request header takes precedence over what MHD knows about the
+ * connection, and there is no trusted-proxy configuration.  Thus the
+ * answer is attacker-controlled whenever clients can reach the daemon
+ * directly, and must not be used for access-control decisions.
+ *
  * @param connection MHD connection
  * @returns #GNUNET_YES if the MHD connection is using https,
  *          #GNUNET_NO if the MHD connection is using http,