commit 27f26b946881a923a1a533501675cb224ecf2b62 parent 34ebf76f1b7089120b9774f77078f9960bf265d7 Author: Christian Grothoff <christian@grothoff.org> Date: Sat, 28 Dec 2024 15:13:28 +0100 -refs to bugs Diffstat:
12 files changed, 16 insertions(+), 17 deletions(-)
diff --git a/src/auditor/taler-helper-auditor-wire-debit.c b/src/auditor/taler-helper-auditor-wire-debit.c @@ -458,8 +458,7 @@ check_pending_rc (void *cls, }; enum GNUNET_DB_QueryStatus qs; - /* FIXME: where do we *undo* this if the wire transfer is - found later? */ + /* FIXME-#9418: where do we *undo* this if the wire transfer is found later? */ qs = TALER_ARL_adb->insert_auditor_closure_lags ( TALER_ARL_adb->cls, &cl); @@ -469,7 +468,7 @@ check_pending_rc (void *cls, GNUNET_break (GNUNET_DB_STATUS_SOFT_ERROR == qs); return GNUNET_SYSERR; } - /* FIXME: where do we *undo* this if the wire transfer is + /* FIXME-#9418: where do we *undo* this if the wire transfer is found later? */ TALER_ARL_amount_add (&TALER_ARL_USE_AB (total_closure_amount_lag), &TALER_ARL_USE_AB (total_closure_amount_lag), diff --git a/src/auditordb/pg_select_historic_denom_revenue.c b/src/auditordb/pg_select_historic_denom_revenue.c @@ -133,7 +133,7 @@ TAH_PG_select_historic_denom_revenue ( }; enum GNUNET_DB_QueryStatus qs; - // FIXME: implement limit/offset! + // FIXME: implement limit/offset! #9423 PREPARE (pg, "auditor_historic_denomination_revenue_select", "SELECT" diff --git a/src/auditordb/pg_select_historic_reserve_revenue.c b/src/auditordb/pg_select_historic_reserve_revenue.c @@ -128,7 +128,7 @@ TAH_PG_select_historic_reserve_revenue ( .pg = pg }; - // FIXME: use limit/offset! + // FIXME: use limit/offset! #9423 PREPARE (pg, "auditor_historic_reserve_summary_select", "SELECT" diff --git a/src/exchange/taler-exchange-httpd_kyc-start.c b/src/exchange/taler-exchange-httpd_kyc-start.c @@ -415,7 +415,7 @@ TEH_handler_kyc_start ( &pd, &kyp->provider_name); - /* FIXME: the next two DB interactions should be ONE + /* FIXME-#9419: the next two DB interactions should be ONE transaction */ /* Check if we already initiated this process */ qs = TEH_plugin->get_pending_kyc_requirement_process ( diff --git a/src/exchange/taler-exchange-httpd_purses_merge.c b/src/exchange/taler-exchange-httpd_purses_merge.c @@ -259,7 +259,7 @@ reply_merge_success (const struct PurseMergeContext *pmc) } else { -#if WAD_NOT_IMPLEMENTED +#if WAD_NOT_IMPLEMENTED /* #7271 */ /* FIXME: figure out partner, lookup wad fee by partner! #7271 */ if (0 > TALER_amount_subtract (&merge_amount, diff --git a/src/exchangedb/pg_insert_kyc_failure.c b/src/exchangedb/pg_insert_kyc_failure.c @@ -75,7 +75,7 @@ TEH_PG_insert_kyc_failure ( params); if (qs > 0) { - /* FIXME: might want to do this eventually in the same transaction... */ + /* FIXME-#9419: might want to do this eventually in the same transaction... */ struct TALER_KycCompletedEventP rep = { .header.size = htons (sizeof (rep)), .header.type = htons (TALER_DBEVENT_EXCHANGE_KYC_COMPLETED), diff --git a/src/exchangedb/pg_wad_in_insert.c b/src/exchangedb/pg_wad_in_insert.c @@ -46,7 +46,7 @@ TEH_PG_wad_in_insert ( GNUNET_PQ_query_param_end }; - // FIXME: should we keep the account data + serial_id? + // FIXME-#7271: should we keep the account data + serial_id? PREPARE (pg, "wad_in_insert", "INSERT INTO wads_in " diff --git a/src/json/json_helper.c b/src/json/json_helper.c @@ -1399,7 +1399,7 @@ parse_normalized_payto_uri (void *cls, return GNUNET_SYSERR; } payto_uri->normalized_payto = (char *) str; -#if FIXME /* need reduced validation for normalized paytos! */ +#if FIXME /* #9421 need reduced validation for normalized paytos! */ { char *err; diff --git a/src/lib/exchange_api_coins_history.c b/src/lib/exchange_api_coins_history.c @@ -1175,9 +1175,9 @@ TALER_EXCHANGE_check_coin_signature_conflict ( } -#if FIXME_IMPLEMENT +#if FIXME_IMPLEMENT /* #9422 */ /** - * FIXME-Oec: we need some specific routines that show + * FIXME-Oec-#9422: we need some specific routines that show * that certain coin operations are indeed in conflict, * for example that the coin is of a different denomination * or different age restrictions. @@ -1195,7 +1195,7 @@ TALER_EXCHANGE_check_coin_signature_conflict ( * @param required balance required on the coin for the operation * @return #GNUNET_OK if @a proof holds */ -// FIXME: should be properly defined and implemented! +// FIXME-#9422: should be properly defined and implemented! enum GNUNET_GenericReturnValue TALER_EXCHANGE_check_coin_conflict_ ( const struct TALER_EXCHANGE_Keys *keys, @@ -1214,7 +1214,7 @@ TALER_EXCHANGE_check_coin_conflict_ ( checked in the GET /coins/$COIN_PUB handler */ break; case TALER_EC_EXCHANGE_GENERIC_COIN_CONFLICTING_DENOMINATION_KEY: - // FIXME: write check! + // FIXME-#9422: write check! break; default: GNUNET_break_op (0); diff --git a/src/mhd/mhd_legal.c b/src/mhd/mhd_legal.c @@ -141,7 +141,7 @@ mime_matches (const char *accept_pattern, (NULL == dm) ) return (0 == strcmp ("*", accept_pattern)); // FIXME: use TALER_MHD_check_accept() here! - /* FIXME: eventually, we might want to parse the "q=$FLOAT" + /* FIXME-#9420: eventually, we might want to parse the "q=$FLOAT" part after the ';' and figure out which one is the best/preferred match instead of returning a boolean... */ end = strchr (da, ';'); diff --git a/src/mhd/mhd_parsing.c b/src/mhd/mhd_parsing.c @@ -583,7 +583,7 @@ TALER_MHD_check_accept (struct MHD_Connection *connection, while (isspace ((unsigned char) t[0])) t++; /* trim of ';q=' parameter and everything after space */ - /* FIXME: eventually, we might want to parse the "q=$FLOAT" + /* FIXME-#9420: eventually, we might want to parse the "q=$FLOAT" part after the ';' and figure out which one is the best/preferred match instead of returning a boolean... */ end = strchr (t, ';'); diff --git a/src/testing/testing_api_cmd_bank_history_credit.c b/src/testing/testing_api_cmd_bank_history_credit.c @@ -263,7 +263,7 @@ command_cb (void *cls, &exchange_credit_url)) ) return; // Not an interesting event // FIXME: support KYCAUTH transfer events! - // FIXME: support WAD transfer events! + // FIXME-#7271: support WAD transfer events! /** * Is the interesting event a match with regard to