exchange

commit 26c9563ef0719601dfd5ac33c70b277dde7e5326
parent 0fe82acc1b7a57d53903624a5789ca83dfae2b45
Author: Florian Dold <florian.dold@gmail.com>
Date:   Thu, 23 Jan 2020 15:44:33 +0100

return TALER_EC_INVALID instead of TALER_EC_NONE when error JSON doesn't contain code

Diffstat:
M
src/json/json.c
 | 
7
++++++-

1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/json/json.c b/src/json/json.c
@@ -77,8 +77,13 @@ TALER_JSON_get_error_code (const json_t *json)
     return TALER_EC_INVALID_RESPONSE;
   }
   jc = json_object_get (json, "code");
+  /* The caller already knows that the JSON represents an error,
+     so we are dealing with a missing error code here.  */
   if (NULL == jc)
-    return TALER_EC_NONE;
+  {
+    GNUNET_break_op (0);
+    return TALER_EC_INVALID;
+  }
   if (json_is_integer (jc))
     return (enum TALER_ErrorCode) json_integer_value (jc);
   GNUNET_break_op (0);