exchange

Base system with REST service to issue digital coins, run by the payment service provider
Log | Files | Refs | Submodules | README | LICENSE

commit 19f513d3f42dd6b37ecd65a7e5d3404a9b3f69d4
parent e9b36b0c969be265881827b4274fce5be9ee0c17
Author: Christian Grothoff <christian@grothoff.org>
Date:   Tue,  4 Feb 2025 23:55:48 +0100

-make codespelly happier

Diffstat:
Mcontrib/ci/jobs/000-codespell/skip.txt | 5++++-
Mdebian/etc-taler-exchange/taler-exchange/conf.d/exchange-business.conf | 7++-----
Msrc/exchangedb/pg_do_refund.h | 2++
Msrc/include/taler_exchange_service.h | 4++--
Msrc/include/taler_exchangedb_plugin.h | 2+-
Msrc/include/taler_testing_lib.h | 2+-
Msrc/lib/exchange_api_management_auditor_enable.c | 30++++++++++++++++--------------
Msrc/testing/testing_api_cmd_auditor_add.c | 6+++---
8 files changed, 31 insertions(+), 27 deletions(-)

diff --git a/contrib/ci/jobs/000-codespell/skip.txt b/contrib/ci/jobs/000-codespell/skip.txt @@ -85,11 +85,14 @@ taler-terms-generator *.ttf *.ttf **/valgrind.h -*/vpn/tests/** *.wav *.woff *.woff2 *.xcf +*.o +*.pub +*.wdb +*~ *.xlsx *.zkey release-artifacts diff --git a/debian/etc-taler-exchange/taler-exchange/conf.d/exchange-business.conf b/debian/etc-taler-exchange/taler-exchange/conf.d/exchange-business.conf @@ -14,7 +14,7 @@ # Here you MUST configure the amount above which transactions are # always subject to manual AML review. -# AML_THRESHOLD = +# AML_THRESHOLD = # Attribute encryption key for storing attributes encrypted # in the database. Should be a high-entropy nonce. @@ -23,7 +23,7 @@ ATTRIBUTE_ENCRYPTION_KEY = SET_ME_PLEASE # For your terms of service and privacy policy, you should specify # an Etag that must be updated whenever there are significant # changes to either document. The format is up to you, what matters -# is that the value is updated and never re-used. See the HTTP +# is that the value is updated and never reused. See the HTTP # specification on Etags. # TERMS_ETAG = # PRIVACY_ETAG = @@ -42,6 +42,3 @@ PAYTO_URI = # Credentials to access the account are in a separate # config file with restricted permissions. @inline-secret@ exchange-accountcredentials-1 ../secrets/exchange-accountcredentials-1.secret.conf - - - diff --git a/src/exchangedb/pg_do_refund.h b/src/exchangedb/pg_do_refund.h @@ -24,6 +24,8 @@ #include "taler_util.h" #include "taler_json_lib.h" #include "taler_exchangedb_plugin.h" + + /** * Perform refund operation, checking for sufficient deposits * of the coin and possibly persisting the refund details. diff --git a/src/include/taler_exchange_service.h b/src/include/taler_exchange_service.h @@ -6657,12 +6657,12 @@ struct TALER_EXCHANGE_ManagementAuditorEnableResponse * Function called with information about the auditor setup operation result. * * @param cls closure - * @param aer response data + * @param r response data */ typedef void (*TALER_EXCHANGE_ManagementAuditorEnableCallback) ( void *cls, - const struct TALER_EXCHANGE_ManagementAuditorEnableResponse *aer); + const struct TALER_EXCHANGE_ManagementAuditorEnableResponse *r); /** diff --git a/src/include/taler_exchangedb_plugin.h b/src/include/taler_exchangedb_plugin.h @@ -4374,7 +4374,7 @@ struct TALER_EXCHANGEDB_Plugin * @param[out] not_found set if the deposit was not found * @param[out] refund_ok set if the refund succeeded (below deposit amount) * @param[out] gone if the merchant was already paid - * @param[out] conflict set if the refund ID was re-used + * @param[out] conflict set if the refund ID was reused * @return query execution status */ enum GNUNET_DB_QueryStatus diff --git a/src/include/taler_testing_lib.h b/src/include/taler_testing_lib.h @@ -1212,7 +1212,7 @@ TALER_TESTING_cmd_age_withdraw_reveal ( /** * Create a withdraw command, letting the caller specify - * the desired amount as string and also re-using an existing + * the desired amount as string and also reusing an existing * coin private key in the process (violating the specification, * which will result in an error when spending the coin!). * diff --git a/src/lib/exchange_api_management_auditor_enable.c b/src/lib/exchange_api_management_auditor_enable.c @@ -82,10 +82,11 @@ handle_auditor_enable_finished (void *cls, { struct TALER_EXCHANGE_ManagementAuditorEnableHandle *ah = cls; const json_t *json = response; - struct TALER_EXCHANGE_ManagementAuditorEnableResponse aer = { + struct TALER_EXCHANGE_ManagementAuditorEnableResponse auditor_enable_response + = { .hr.http_status = (unsigned int) response_code, .hr.reply = json - }; + }; ah->job = NULL; switch (response_code) @@ -93,8 +94,8 @@ handle_auditor_enable_finished (void *cls, case MHD_HTTP_NO_CONTENT: break; case MHD_HTTP_FORBIDDEN: - aer.hr.ec = TALER_JSON_get_error_code (json); - aer.hr.hint = TALER_JSON_get_error_hint (json); + auditor_enable_response.hr.ec = TALER_JSON_get_error_code (json); + auditor_enable_response.hr.hint = TALER_JSON_get_error_hint (json); break; case MHD_HTTP_NOT_FOUND: GNUNET_log (GNUNET_ERROR_TYPE_ERROR, @@ -102,34 +103,35 @@ handle_auditor_enable_finished (void *cls, ah->url); if (NULL != json) { - aer.hr.ec = TALER_JSON_get_error_code (json); - aer.hr.hint = TALER_JSON_get_error_hint (json); + auditor_enable_response.hr.ec = TALER_JSON_get_error_code (json); + auditor_enable_response.hr.hint = TALER_JSON_get_error_hint (json); } else { - aer.hr.ec = TALER_EC_GENERIC_INVALID_RESPONSE; - aer.hr.hint = TALER_ErrorCode_get_hint (aer.hr.ec); + auditor_enable_response.hr.ec = TALER_EC_GENERIC_INVALID_RESPONSE; + auditor_enable_response.hr.hint = TALER_ErrorCode_get_hint ( + auditor_enable_response.hr.ec); } break; case MHD_HTTP_CONFLICT: - aer.hr.ec = TALER_JSON_get_error_code (json); - aer.hr.hint = TALER_JSON_get_error_hint (json); + auditor_enable_response.hr.ec = TALER_JSON_get_error_code (json); + auditor_enable_response.hr.hint = TALER_JSON_get_error_hint (json); break; default: /* unexpected response code */ GNUNET_break_op (0); - aer.hr.ec = TALER_JSON_get_error_code (json); - aer.hr.hint = TALER_JSON_get_error_hint (json); + auditor_enable_response.hr.ec = TALER_JSON_get_error_code (json); + auditor_enable_response.hr.hint = TALER_JSON_get_error_hint (json); GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Unexpected response code %u/%d for exchange management auditor enable\n", (unsigned int) response_code, - (int) aer.hr.ec); + (int) auditor_enable_response.hr.ec); break; } if (NULL != ah->cb) { ah->cb (ah->cb_cls, - &aer); + &auditor_enable_response); ah->cb = NULL; } TALER_EXCHANGE_management_enable_auditor_cancel (ah); diff --git a/src/testing/testing_api_cmd_auditor_add.c b/src/testing/testing_api_cmd_auditor_add.c @@ -62,15 +62,15 @@ struct AuditorAddState * if the response code is acceptable. * * @param cls closure. - * @param aer response details + * @param r response details */ static void auditor_add_cb ( void *cls, - const struct TALER_EXCHANGE_ManagementAuditorEnableResponse *aer) + const struct TALER_EXCHANGE_ManagementAuditorEnableResponse *r) { struct AuditorAddState *ds = cls; - const struct TALER_EXCHANGE_HttpResponse *hr = &aer->hr; + const struct TALER_EXCHANGE_HttpResponse *hr = &r->hr; ds->dh = NULL; if (ds->expected_response_code != hr->http_status)