exchange

commit 176113a62afbd84d907859f6e90ed2e74856af5a
parent a66b9e1b8aa5d49d2dbd0ce29e8c65d20f2e7997
Author: Christian Grothoff <christian@grothoff.org>
Date:   Sun, 23 Feb 2020 21:52:18 +0100

fix some auditor assertions (see #6106)

Diffstat:
M
src/auditor/taler-auditor.c
 | 
11
++++++-----

1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/auditor/taler-auditor.c b/src/auditor/taler-auditor.c
@@ -786,9 +786,11 @@ get_denomination_info_by_hash (const struct GNUNET_HashCode *dh,
     *issue = i;
     return GNUNET_DB_STATUS_SUCCESS_ONE_RESULT;
   }
-  /* This should be impossible; hard error */
-  GNUNET_break (0);
-  return GNUNET_DB_STATUS_HARD_ERROR;
+  /* We found more keys, but not the denomination we are looking for :-( */
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+              "Denomination %s not found\n",
+              TALER_B2S (dh));
+  return GNUNET_DB_STATUS_SUCCESS_NO_RESULTS;
 }
 
 
@@ -2927,13 +2929,12 @@ check_wire_out_cb (void *cls,
                                          &currency_round_unit));
 
   /* Calculate the exchange's gain as the fees plus rounding differences! */
-  if (GNUNET_OK !=
+  if (GNUNET_SYSERR ==
       TALER_amount_subtract (&exchange_gain,
                              &wcc.total_deposits,
                              &final_amount))
   {
     GNUNET_break (0);
-    // FIXME: we should report an arithmetic error here!
     ac->qs = GNUNET_DB_STATUS_HARD_ERROR;
     return GNUNET_SYSERR;
   }