exchange

commit 1628f0255c78864fa0af05d065ff31449aa92806
parent 8c2ee80ae8e0ee078f7c5a3b98a521e7344a975c
Author: Christian Grothoff <grothoff@gnunet.org>
Date:   Fri,  8 Jul 2022 15:34:09 +0200

-note fixme

Diffstat:
M
src/exchangedb/plugin_exchangedb_postgres.c
 | 
5
++++-

1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/exchangedb/plugin_exchangedb_postgres.c b/src/exchangedb/plugin_exchangedb_postgres.c
@@ -1779,6 +1779,9 @@ prepare_statements (struct PostgresClosure *pg)
       "   WHERE coin_pub IN (SELECT coin_pub FROM dep)"
       "     AND deposit_serial_id IN (SELECT deposit_serial_id FROM dep))"
       " ,fees AS (" /* find deposit fees for non-refunded deposits */
+      // FIXME: this is wrong, the deposit fee is waived IF the
+      // refunds were for 100% of the deposit value. This logic
+      // ignores this detail :-(.
       "  SELECT"
       "    denom.fee_deposit_val AS fee_val"
       "   ,denom.fee_deposit_frac AS fee_frac"
@@ -7502,7 +7505,7 @@ postgres_aggregate (
                                                  rs);
   if (qs < 0)
   {
-    GNUNET_assert (GNUNET_DB_STATUS_SOFT_ERROR == qs);
+    GNUNET_break (GNUNET_DB_STATUS_SOFT_ERROR == qs);
     return qs;
   }
   if (GNUNET_DB_STATUS_SUCCESS_NO_RESULTS == qs)