exchange

commit 0f5ef01dd3ef623fb06d3cf9046a18ae818d2570
parent 22eae129a9e5934d3fadf11cb4b4c6724c9d1aa8
Author: Christian Grothoff <christian@grothoff.org>
Date:   Thu, 14 Dec 2017 13:36:59 +0100

nicer error reporting

Diffstat:
M
src/bank-lib/bank_api_history.c
 | 
2
+-
M
src/include/taler_error_codes.h
 | 
7
+++++++
M
src/wire/plugin_wire_test.c
 | 
7
++++---

3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/bank-lib/bank_api_history.c b/src/bank-lib/bank_api_history.c
@@ -174,7 +174,7 @@ handle_history_finished (void *cls,
   switch (response_code)
   {
   case 0:
-    ec = TALER_EC_INTERNAL_INVARIANT_FAILURE;
+    ec = TALER_EC_BANK_HISTORY_HTTP_FAILURE;
     break;
   case MHD_HTTP_OK:
     if (GNUNET_OK !=
diff --git a/src/include/taler_error_codes.h b/src/include/taler_error_codes.h
@@ -1516,6 +1516,13 @@ enum TALER_ErrorCode
   TALER_EC_BANK_HISTORY_NOT_AUHTORIZED = 4151,
 
   /**
+   * The bank library had trouble obtaining a valid
+   * HTTP response.
+   * Returned with a status code of 0.
+   */
+  TALER_EC_BANK_HISTORY_HTTP_FAILURE = 4152,
+
+  /**
    * The bank could not find the wire transfer that was supposed to
    * be rejected.
    * Returned with a status code of MHD_HTTP_NOT_FOUND.
diff --git a/src/wire/plugin_wire_test.c b/src/wire/plugin_wire_test.c
@@ -891,9 +891,10 @@ bhist_cb (void *cls,
     GNUNET_free (whh);
     break;
   default:
-    /* FIXME: consider modifying API to pass more specific error code(s)
-       back to the application. */
-    GNUNET_break (0);
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                "Bank failed with HTTP status %u (EC: %u)\n",
+                http_status,
+                ec);
     if (NULL != whh->hres_cb)
       (void) whh->hres_cb (whh->hres_cb_cls,
                            ec,