commit 05acfaaa4b368c3e54de02a7c2aa2b6b74fcc45e
parent 6833084c8e52920b6ceb4b669698a5b014ed0d59
Author: Christian Grothoff <christian@grothoff.org>
Date: Wed, 1 Jan 2025 13:48:53 +0100
TODO -> FIXME
Diffstat:
17 files changed, 27 insertions(+), 32 deletions(-)
diff --git a/src/auditordb/plugin_auditordb_postgres.c b/src/auditordb/plugin_auditordb_postgres.c
@@ -481,7 +481,7 @@ postgres_gc (void *cls)
if (NULL == conn)
return GNUNET_SYSERR;
GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
- "TODO: Auditor GC not implemented (#4960)\n");
+ "FIXME: Auditor GC not implemented (#9433)\n");
qs = GNUNET_PQ_eval_prepared_non_select (conn,
"gc_auditor",
params_time);
diff --git a/src/benchmark/taler-bank-benchmark.c b/src/benchmark/taler-bank-benchmark.c
@@ -22,9 +22,8 @@
* @author Marcello Stanisci
* @author Christian Grothoff
*/
-// TODO:
-// - use more than one 'client' bank account
-// - also add taler-exchange-transfer to simulate outgoing payments
+// FIXME: support use of more than one 'client' bank account
+// FIXME: add taler-exchange-transfer to simulate outgoing payments
#include "platform.h"
#include <gnunet/gnunet_util_lib.h>
#include <microhttpd.h>
@@ -214,7 +213,7 @@ run (void *cls,
GNUNET_asprintf (&create_reserve_label,
"createreserve-%u",
j);
- // TODO: vary user accounts more...
+ // FIXME: vary user accounts more...
all_commands[1 + j]
= TALER_TESTING_cmd_admin_add_incoming_retry (
TALER_TESTING_cmd_admin_add_incoming (add_label (
diff --git a/src/exchangedb/pg_insert_records_by_table.c b/src/exchangedb/pg_insert_records_by_table.c
@@ -2260,9 +2260,9 @@ irbt_cb_table_purse_deletion (struct PostgresClosure *pg,
* @param td record to insert
*/
static enum GNUNET_DB_QueryStatus
-irbt_cb_table_age_withdraw (struct PostgresClosure *pg,
- const struct
- TALER_EXCHANGEDB_TableData *td)
+irbt_cb_table_age_withdraw (
+ struct PostgresClosure *pg,
+ const struct TALER_EXCHANGEDB_TableData *td)
{
struct GNUNET_PQ_QueryParam params[] = {
GNUNET_PQ_query_param_uint64 (&td->serial),
@@ -2279,7 +2279,7 @@ irbt_cb_table_age_withdraw (struct PostgresClosure *pg,
&td->details.age_withdraw.reserve_sig),
GNUNET_PQ_query_param_uint32 (
&td->details.age_withdraw.noreveal_index),
- /* TODO: other fields, too! */
+ /* FIXME[oec]: other fields, too! */
GNUNET_PQ_query_param_end
};
diff --git a/src/exchangedb/pg_lookup_records_by_table.c b/src/exchangedb/pg_lookup_records_by_table.c
@@ -2684,7 +2684,7 @@ lrbt_cb_table_age_withdraw (void *cls,
GNUNET_PQ_result_spec_uint32 (
"noreveal_index",
&td.details.age_withdraw.noreveal_index),
- /* TODO[oec]: more fields! */
+ /* FIXME[oec]: more fields! */
GNUNET_PQ_result_spec_end
};
@@ -3704,7 +3704,7 @@ TEH_PG_lookup_records_by_table (void *cls,
" FROM age_withdraw"
" WHERE age_withdraw_id > $1"
" ORDER BY age_withdraw_id ASC;");
- /* TODO[oec]: MORE FIELDS! */
+ /* FIXME[oec]: MORE FIELDS! */
rh = &lrbt_cb_table_age_withdraw;
break;
case TALER_EXCHANGEDB_RT_LEGITIMIZATION_MEASURES:
diff --git a/src/exchangedb/test_exchangedb.c b/src/exchangedb/test_exchangedb.c
@@ -2115,7 +2115,7 @@ run (void *cls)
break;
}
case TALER_EXCHANGEDB_TT_OLD_COIN_RECOUP:
- /* TODO: check fields better... */
+ /* FIXME: check fields better... */
matched |= 16;
break;
default:
diff --git a/src/extensions/extensions.c b/src/extensions/extensions.c
@@ -224,7 +224,7 @@ configure_extension (
if (GNUNET_OK != add_extension (extension))
{
- /* TODO: Ignoring return values here */
+ /* FIXME[oec]: Ignoring return values here */
GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Couldn't add extension `%s` (section [%s]).\n",
name,
@@ -334,7 +334,7 @@ TALER_extensions_load_manifests (
if (critical != extension->critical
|| 0 != strcmp (version,
- extension->version) // TODO: libtool compare?
+ extension->version) // FIXME[oec]: libtool compare?
|| NULL == config
|| (GNUNET_OK !=
extension->load_config (config,
diff --git a/src/kyclogic/kyclogic_api.c b/src/kyclogic/kyclogic_api.c
@@ -1215,7 +1215,7 @@ append_voluntary_measure (
ms->check_name))
return; /* very strange configuration */
#if 0
- /* TODO: support vATTEST-9048 (this API in kyclogic!) */
+ /* FIXME: support vATTEST-9048 (this API in kyclogic!) */
// NOTE: need to convert ms to "KycRequirementInformation"
// *and* in particular generate "id" values that
// are then understood to refer to the voluntary measures
diff --git a/src/lib/exchange_api_handle.c b/src/lib/exchange_api_handle.c
@@ -1188,7 +1188,7 @@ decode_keys_json (const json_t *resp_obj,
/* Parse the supported extension(s): age-restriction. */
- /* TODO: maybe lift all this into a FP in TALER_Extension ? */
+ /* FIXME[Oec]: maybe lift all this into a FP in TALER_Extension ? */
if (! no_extensions)
{
if (no_signature)
diff --git a/src/pq/pq_result_helper.c b/src/pq/pq_result_helper.c
@@ -114,7 +114,7 @@ extract_amount_currency_tuple (void *cls,
fname);
return GNUNET_SYSERR;
}
- /* TODO[oec]: OID-checks? */
+ /* FIXME[oec]: OID-checks? */
r_amount->value = GNUNET_ntohll (ap.v);
r_amount->fraction = ntohl (ap.f);
@@ -273,7 +273,7 @@ extract_amount_tuple (void *cls,
fname);
return GNUNET_SYSERR;
}
- /* TODO[oec]: OID-checks? */
+ /* FIXME[oec]: OID-checks? */
r_amount->value = GNUNET_ntohll (ap.v);
r_amount->fraction = ntohl (ap.f);
diff --git a/src/testing/test_exchange_api.c b/src/testing/test_exchange_api.c
@@ -409,7 +409,7 @@ run (void *cls,
* called _after_ TALER_TESTING_cmd_exec_offline_sign_extensions is called,
* i. e. age restriction is activated in the exchange!
*
- * TODO: create a test that tries to withdraw coins with age restriction but
+ * FIXME[oec]: create a test that tries to withdraw coins with age restriction but
* (expectedly) fails because the exchange doesn't support age restriction
* yet.
*/
diff --git a/src/testing/test_exchange_api_age_restriction.c b/src/testing/test_exchange_api_age_restriction.c
@@ -105,7 +105,7 @@ run (void *cls,
* called _after_ TALER_TESTING_cmd_exec_offline_sign_extensions is called,
* i. e. age restriction is activated in the exchange!
*
- * TODO: create a test that tries to withdraw coins with age restriction but
+ * FIXME: create a test that tries to withdraw coins with age restriction but
* (expectedly) fails because the exchange doesn't support age restriction
* yet.
*/
diff --git a/src/testing/testing_api_cmd_age_withdraw.c b/src/testing/testing_api_cmd_age_withdraw.c
@@ -211,7 +211,7 @@ age_withdraw_cb (
/* nothing to check */
break;
case MHD_HTTP_CONFLICT:
- /* TODO[oec]: Add this to the response-type and handle it here */
+ /* FIXME[oec]: Add this to the response-type and handle it here */
break;
case MHD_HTTP_UNAVAILABLE_FOR_LEGAL_REASONS:
default:
@@ -417,7 +417,7 @@ age_withdraw_traits (
TALER_TESTING_make_trait_reserve_pub (&aws->reserve_pub),
TALER_TESTING_make_trait_amounts (idx,
&out->amount),
- /* TODO[oec]: add legal requirement to response and handle it here, as well
+ /* FIXME[oec]: add legal requirement to response and handle it here, as well
TALER_TESTING_make_trait_legi_requirement_row (&aws->requirement_row),
TALER_TESTING_make_trait_h_payto (&aws->h_payto),
*/
@@ -614,7 +614,7 @@ age_withdraw_reveal_cb (
case MHD_HTTP_FORBIDDEN:
/* nothing to check */
break;
- /* TODO[oec]: handle more cases !? */
+ /* FIXME[oec]: handle more cases !? */
default:
/* Unsupported status code (by test harness) */
GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
diff --git a/src/testing/testing_api_cmd_batch_withdraw.c b/src/testing/testing_api_cmd_batch_withdraw.c
@@ -233,7 +233,7 @@ reserve_batch_withdraw_cb (void *cls,
/* nothing to check */
break;
case MHD_HTTP_CONFLICT:
- /* TODO[oec]: Check if age-requirement is the reason */
+ /* FIXME[oec]: Check if age-requirement is the reason */
break;
case MHD_HTTP_GONE:
/* theoretically could check that the key was actually */
diff --git a/src/testing/testing_api_cmd_reserve_attest.c b/src/testing/testing_api_cmd_reserve_attest.c
@@ -72,7 +72,7 @@ struct AttestState
*/
struct TALER_TESTING_Interpreter *is;
- /* TODO: expose fields below as traits... */
+ /* FIXME: expose fields below as traits... */
/**
* Attested attributes returned by the exchange.
diff --git a/src/testing/testing_api_loop.c b/src/testing/testing_api_loop.c
@@ -659,7 +659,7 @@ TALER_TESTING_main (char *const *argv,
}
ret = TALER_TESTING_loop (main_cb,
main_cb_cls);
- /* TODO: should we free 'cred' resources here? */
+ /* FIXME: should we free 'cred' resources here? */
return (GNUNET_OK == ret) ? 0 : 1;
}
diff --git a/src/util/exchange_signatures.c b/src/util/exchange_signatures.c
@@ -458,7 +458,7 @@ TALER_exchange_online_age_withdraw_confirmation_verify (
}
-/* TODO:oec: add signature for age-withdraw, age-reveal */
+/* FIXME[oec] add signature for age-withdraw, age-reveal */
GNUNET_NETWORK_STRUCT_BEGIN
diff --git a/src/util/tokens.c b/src/util/tokens.c
@@ -60,8 +60,6 @@ TALER_token_use_setup_priv (
const struct TALER_TokenUseMerchantValues *alg_values,
struct TALER_TokenUsePrivateKeyP *token_priv)
{
- /* TODO: Maybe extract common code between this
- function and TALER_planchet_setup_coin_priv (). */
const struct GNUNET_CRYPTO_BlindingInputValues *bi
= alg_values->blinding_inputs;
@@ -108,8 +106,6 @@ TALER_token_use_blinding_secret_create (
const struct TALER_TokenUseMerchantValues *alg_values,
union GNUNET_CRYPTO_BlindingSecretP *bks)
{
- /* TODO: Extract common code between this
- function and TALER_planchet_blinding_secret_create (). */
const struct GNUNET_CRYPTO_BlindingInputValues *bi =
alg_values->blinding_inputs;
@@ -181,7 +177,7 @@ TALER_token_issue_sign (const struct TALER_TokenIssuePrivateKey *issue_priv,
{
issue_sig->signature
= GNUNET_CRYPTO_blind_sign (issue_priv->private_key,
- "tk", /* TODO: What is a good value here? */
+ "tk",
envelope->blinded_pub);
if (NULL == issue_sig->signature)
return GNUNET_SYSERR;
