challenger

commit fd3c5a57801724576425413e16f6d6bce9539bcf
parent 833801537281c004789aa284ef2aa0459dd20431
Author: Christian Grothoff <christian@grothoff.org>
Date:   Sun,  4 May 2025 09:51:47 +0200

properly log helper failures, and wait until helper is actually finished with status evaluation

Diffstat:
M
src/challenger/challenger-httpd_challenge.c
 | 
10
++++++++--

1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/challenger/challenger-httpd_challenge.c b/src/challenger/challenger-httpd_challenge.c
@@ -652,8 +652,10 @@ CH_handler_challenge (struct CH_HandlerContext *hc,
     return MHD_NO;
   }
   /* Handle case where helper process failed */
-  if ( (GNUNET_OS_PROCESS_EXITED != bc->pst) ||
-       (0 != bc->exit_code) )
+  if ( (GNUNET_OS_PROCESS_UNKNOWN != bc->pst) &&
+       (NULL == bc->child) &&
+       ( (GNUNET_OS_PROCESS_EXITED != bc->pst) ||
+         (0 != bc->exit_code) ) )
   {
     char es[32];
 
@@ -663,6 +665,10 @@ CH_handler_challenge (struct CH_HandlerContext *hc,
                      "%u/%d",
                      (unsigned int) bc->exit_code,
                      bc->pst);
+    GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                "Helper failed with status %d/%d\n",
+                (int) bc->pst,
+                (int) bc->exit_code);
     return reply_error (bc,
                         "internal-error",
                         MHD_HTTP_INTERNAL_SERVER_ERROR,