challenger

commit 15434ec4cf3ba0c9f023eb974358bc70a2f20130
parent 20aba703085bee6083254eb9cfca94e904d19719
Author: Christian Grothoff <christian@grothoff.org>
Date:   Thu,  6 Aug 2026 15:13:14 +0200

use GNUNET_break_op() for client issues

Diffstat:
M
src/challenger/challenger-httpd_common.c
 | 
5
++++-
M
src/challenger/challenger-httpd_token.c
 | 
2
+-

2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/challenger/challenger-httpd_common.c b/src/challenger/challenger-httpd_common.c
@@ -246,7 +246,10 @@ CH_build_full_redirect_url (
         "get_validation");
       return (MHD_NO == ret) ? GNUNET_SYSERR : GNUNET_NO;
     case GNUNET_DB_STATUS_SUCCESS_NO_RESULTS:
-      GNUNET_break (0);
+      /* Reachable when a concurrent /token consumed the validation
+         between /solve and the construction of the redirect URL; that is
+         a client-side race, not a bug of ours. */
+      GNUNET_break_op (0);
       ret = TALER_MHD_reply_with_error (
         connection,
         MHD_HTTP_NOT_FOUND,
diff --git a/src/challenger/challenger-httpd_token.c b/src/challenger/challenger-httpd_token.c
@@ -746,7 +746,7 @@ CH_handler_token (struct CH_HandlerContext *hc,
       case GNUNET_DB_STATUS_SOFT_ERROR:
         continue;
       case GNUNET_DB_STATUS_SUCCESS_NO_RESULTS:
-        GNUNET_break (0);
+        GNUNET_break_op (0);
         return CH_reply_with_oauth_error (
           hc->connection,
           MHD_HTTP_BAD_REQUEST,