cashless2ecash

commit d281cba162f0de437849721ae0c8d55b110160f5
parent 98bbaa66eb8d455ec172e31f8c72bfb347d52d11
Author: Joel-Haeberli <haebu@rubigen.ch>
Date:   Mon,  3 Jun 2024 12:31:56 +0200

fix: transfer

Diffstat:
M
c2ec/api-wire-gateway.go
 | 
9
+--------
M
c2ec/proc-transfer.go
 | 
9
+++++++++

2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/c2ec/api-wire-gateway.go b/c2ec/api-wire-gateway.go
@@ -190,14 +190,7 @@ func transfer(res http.ResponseWriter, req *http.Request) {
 		return
 	}
 
-	decodedRequestUid := bytes.NewBufferString(transfer.RequestUid).Bytes() // decodedRequestUid, err := talerBinaryDecode(string(transfer.RequestUid))
-	if err != nil {
-		LogError("wire-gateway-api", err)
-		setLastResponseCodeForLogger(HTTP_BAD_REQUEST)
-		res.WriteHeader(HTTP_BAD_REQUEST)
-		return
-	}
-
+	decodedRequestUid := bytes.NewBufferString(transfer.RequestUid).Bytes()
 	t, err := DB.GetTransferById(decodedRequestUid)
 	if err != nil {
 		LogError("wire-gateway-api", err)
diff --git a/c2ec/proc-transfer.go b/c2ec/proc-transfer.go
@@ -62,6 +62,15 @@ func transferCallback(notification *Notification, errs chan error) {
 		LogError("proc-transfer", err)
 		transferFailed(transfer, errs)
 		errs <- err
+		return
+	}
+
+	if transfer == nil {
+		err := errors.New("expected an existing transfer. very strange")
+		LogError("proc-transfer", err)
+		transferFailed(transfer, errs)
+		errs <- err
+		return
 	}
 
 	paytoTargetType, tid, err := ParsePaytoUri(transfer.CreditAccount)