anastasis

commit 719cc8b7f9011a720d30308b99edc456a2943ca6
parent b84592ab13fa57ced793b437ad193c4e19c34b5b
Author: Christian Grothoff <christian@grothoff.org>
Date:   Fri, 13 Dec 2024 14:58:26 +0100

-fix NPE on plugin not found

Diffstat:
M
src/lib/anastasis_backup.c
 | 
5
+----
M
src/stasis/anastasis_db_plugin.c
 | 
10
++++++----

2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/src/lib/anastasis_backup.c b/src/lib/anastasis_backup.c
@@ -623,10 +623,7 @@ policy_store_cb (void *cls,
   enum ANASTASIS_UploadStatus us;
 
   pss->pso = NULL;
-  if (NULL == ud)
-    us = ANASTASIS_US_HTTP_ERROR;
-  else
-    us = ud->us;
+  us = ud->us;
   if ( (ANASTASIS_US_SUCCESS == us) &&
        (0 != GNUNET_memcmp (&pss->curr_hash,
                             ud->details.success.curr_backup_hash)) )
diff --git a/src/stasis/anastasis_db_plugin.c b/src/stasis/anastasis_db_plugin.c
@@ -51,10 +51,12 @@ ANASTASIS_DB_plugin_load (const struct GNUNET_CONFIGURATION_Handle *cfg,
   plugin = GNUNET_PLUGIN_load (ANASTASIS_project_data (),
                                lib_name,
                                (void *) cfg);
-  if (NULL != plugin)
-    plugin->library_name = lib_name;
-  else
-    lib_name = NULL;
+  if (NULL == plugin)
+  {
+    GNUNET_free (lib_name);
+    return NULL;
+  }
+  plugin->library_name = lib_name;
   if ( (! skip_preflight) &&
        (GNUNET_OK !=
         plugin->preflight (plugin->cls)) )