make sure 400 is responded when JSON is invalid

1 files changed, 8 insertions, 4 deletions

diff --git a/nexus/src/main/kotlin/tech/libeufin/nexus/server/NexusServer.kt b/nexus/src/main/kotlin/tech/libeufin/nexus/server/NexusServer.kt
index 69f13f53..2c6fe7d6 100644
--- a/nexus/src/main/kotlin/tech/libeufin/nexus/server/NexusServer.kt
+++ b/nexus/src/main/kotlin/tech/libeufin/nexus/server/NexusServer.kt
@@ -469,8 +469,13 @@ fun serverMain(dbName: String, host: String, port: Int) {
                     // sanity checks.
                     when (schedSpec.type) {
                         "fetch" -> {
-                            jacksonObjectMapper().treeToValue(schedSpec.params, FetchSpecJson::class.java)
-                                ?: throw NexusError(HttpStatusCode.BadRequest, "bad fetch spec")
+                            // only checking validity.
+                            try {
+                                jacksonObjectMapper().treeToValue(schedSpec.params, FetchSpecJson::class.java)
+                            } catch (e: Exception) {
+                                logger.error(e.message)
+                                throw NexusError(HttpStatusCode.BadRequest, "bad fetch spec")
+                            }
                         }
                         "submit" -> {
                         }
@@ -491,8 +496,7 @@ fun serverMain(dbName: String, host: String, port: Int) {
                         this.taskCronspec = schedSpec.cronspec
                         this.taskName = requireValidResourceName(schedSpec.name)
                         this.taskType = schedSpec.type
-                        this.taskParams =
-                            jacksonObjectMapper().writerWithDefaultPrettyPrinter().writeValueAsString(schedSpec.params)
+                        this.taskParams = jacksonObjectMapper().writerWithDefaultPrettyPrinter().writeValueAsString(schedSpec.params)
                     }
                 }
                 call.respond(object {})