summaryrefslogtreecommitdiff
path: root/BUILDING.md
AgeCommit message (Collapse)Author
2020-12-18doc: add two tips for speeding the dev buildsMomtchil Momtchev
Add two important tips for novice Node.js contributors PR-URL: https://github.com/nodejs/node/pull/36452 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2020-11-22doc: add arm64 macOS as experimentalRichard Lau
PR-URL: https://github.com/nodejs/node/pull/36189 Refs: https://github.com/nodejs/build/issues/2474 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2020-11-02doc: adjust table alignment for remark v13Nick Schonning
Addresses table-cell-padding rule issues PR-URL: https://github.com/nodejs/node/pull/35647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-10-27doc: fix typo in BUILDING.mdraisinten
PR-URL: https://github.com/nodejs/node/pull/35807 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2020-10-25test: refactor coverage logicbcoe
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: https://github.com/nodejs/node/pull/35767 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2020-10-22doc: add Installing Node.js header in BUILDING.mdPooja D.P
PR-URL: https://github.com/nodejs/node/pull/35710 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-09-06doc: spruce up user journey to local docs browsingDerek Lewis
This patch improves the means by which the docs are viewed locally. * Remove extraneous code in the `docserve` Makefile target * Document the `docserve` task for all to know * Bring all code snippets in this section up to speed * Clarify the purpose of each documentation browsing method Fixes: https://github.com/nodejs/node/issues/34977 PR-URL: https://github.com/nodejs/node/pull/34986 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2020-09-04doc: update support macos version for 15.xAshCripps
with our minimum target already set to 10.13 for 14.x it doesn't make sense to claim to support anything lower. PR-URL: https://github.com/nodejs/node/pull/35022 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
2020-08-20doc: fix bulleted list punctuation in BUILDING.mdRich Trott
Remove/add periods as appropriate in bulleted lists in BUILDING.md. PR-URL: https://github.com/nodejs/node/pull/34849 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
2020-08-20build,win: use x64 Node when building for ARM64Dennis Ameling
Uses x64 node executable for running .js files in arm64 cross-compilation scenarios. MSI can now be created by running `vcbuild.bat release msi arm64` Refs: https://github.com/nodejs/node/issues/25998 Refs: https://github.com/nodejs/node/issues/32582 PR-URL: https://github.com/nodejs/node/pull/34009 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
2020-08-14build: move compiling for Windows ARM64 to Tier 2João Reis
PR-URL: https://github.com/nodejs/node/pull/34721 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-07-13build: recommend Python 3.8 to build on WindowsMichaël Zasso
PR-URL: https://github.com/nodejs/node/pull/34182 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2020-06-12build: drop support for VS2017Michaël Zasso
PR-URL: https://github.com/nodejs/node/pull/33694 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
2020-05-30doc: fix urls to avoid redirectionsapics
Replace redirected urls with the final ones. Replace http urls with https ones. PR-URL: https://github.com/nodejs/node/pull/33614 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2020-05-08doc: mention python3-distutils dependency in BUILDING.mdosher
Ran into #30189, solved by this comment: https://github.com/nodejs/node/issues/30189#issuecomment-548250793 Refs: https://github.com/nodejs/node/issues/30189 PR-URL: https://github.com/nodejs/node/pull/33174 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
2020-04-23doc: add angle brackets around implicit linksNick Schonning
PR-URL: https://github.com/nodejs/node/pull/32676 Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-04-15doc: update cross compiler machine for Linux armv7Richard Lau
Update cross compiler machine for Linux armv7 to Ubuntu 18.04. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32812 Refs: https://github.com/nodejs/build/issues/2168 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2020-04-15doc: update Centos/RHEL releases use devtoolset-8Richard Lau
Releases built on Centos/RHEL have been updated to use devtoolset-8. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32812 Refs: https://github.com/nodejs/build/issues/2168 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2020-04-15doc: remove SmartOS from official binariesRichard Lau
Based on feedback from Joyent, the SmartOS builds are largely unusable without bundling all of the libraries used to build the binary so are being dropped starting from Node.js 14. We will still test SmartOS in the CI. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32812 Refs: https://github.com/nodejs/build/issues/2168 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2020-04-05tools: update Boxstarter script and documenthimself65
PR-URL: https://github.com/nodejs/node/pull/32299 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2020-04-01doc: add ASAN build instructionsgengjiawen
PR-URL: https://github.com/nodejs/node/pull/32436 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
2020-03-26build: update macos deployment target to 10.13 for 14.xAshCripps
Update the macos deployment target to 10.13 (High Sierra) for Node 14 refs: https://github.com/nodejs/build/issues/2168 PR-URL: https://github.com/nodejs/node/pull/32454 Refs: https://github.com/nodejs/build/issues/2168 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>
2020-03-10doc: official macOS builds now on 10.15 + Xcode 11Rod Vagg
PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Signed-off-by: Rod Vagg <rod@vagg.org>
2020-03-05win: block running on EOL Windows versionsJoão Reis
Windows 7 and Windows Server 2008 R2 EOL was January 14, 2020. Windows 8 EOL was January 12, 2016. Windows 2012 (not R2) is still supported and allowed to run. This clarifies that support is experimental. PR-URL: https://github.com/nodejs/node/pull/31954 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2020-02-13doc: add prerequisites information for ArchUjjwal Sharma
Add prerequisites for Arch Linux and derivatives in BUILDING.md. PR-URL: https://github.com/nodejs/node/pull/31669 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2020-02-07doc: add note in BUILDING.md about running `make distclean`Swagat Konchada
Fixes: https://github.com/nodejs/node/issues/28675 PR-URL: https://github.com/nodejs/node/pull/31542 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-12-25doc: fix anchors and subtitle in BUILDING.mdsutangu
PR-URL: https://github.com/nodejs/node/pull/30296 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
2019-12-24doc: implement minor improvements to BUILDING.md textRich Trott
Fix comma splices. Remove unnecessary words. Minor text improvements. PR-URL: https://github.com/nodejs/node/pull/31070 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-12-13doc: clarify build support textRich Trott
Revise compilation/execution support text to keep it shorter, simpler, and hopefully easier to read/understand. PR-URL: https://github.com/nodejs/node/pull/30899 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2019-12-11doc: clarify Tier 2 implications in BUILDING.mdRich Trott
Clarify the explanation of Tier 2 platforms and binary releases. PR-URL: https://github.com/nodejs/node/pull/30866 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org>
2019-12-04doc: remove imprecise and redundant testing textRich Trott
Remove "All commits...are tested on these platforms." for the following reasons: * It's somewhat redundant. The surrounding text makes it clear that we test on these platforms. * It's imprecise. Commits, such as those that only affect documentation or linting do not get tested on all the platforms. (Well, perhaps they do in an after-the-fact kind of way when a subsequent commit gets tested, but I think that's a stretch.) PR-URL: https://github.com/nodejs/node/pull/30763 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2019-12-03doc: update status of Python 3 supportMichael Dawson
Refs: https://github.com/nodejs/TSC/pull/781#issuecomment-559666380 Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. PR-URL: https://github.com/nodejs/node/pull/30722 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2019-11-30doc: documenting a bit more FreeBSD caseDavid Carlier
FreeBSD provides more up to date compilers than the one provided by the system. PR-URL: https://github.com/nodejs/node/pull/30325 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>
2019-11-27doc: add 13 and 12 to previous versionsAndrew Hughes
Remove Node.js 6 and add Node.js 12 and Node.js 13 to the previous versions of this document section PR-URL: https://github.com/nodejs/node/pull/30590 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2019-11-20doc: fix overriding of prefix optionLuigi Pinca
Make the example in the "Building a debug build" section work as intended. Fixes: https://github.com/nodejs/node/issues/30477 PR-URL: https://github.com/nodejs/node/pull/30518 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-11-14doc: remove "multiple variants" from BUILDING.mdRich Trott
The statement that tests for tier 1 platforms are run on multiple variants is not true. We usually only run on one variant of macOS. Remove "multiple", which simplifies and clarifies the statements anyway. PR-URL: https://github.com/nodejs/node/pull/30366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-11-13doc: remove "maintenance is supported by" text in BUILDING.mdRich Trott
The "maintenance is supported by" stuff in BUILDING.md is unclear. It seems unnecessary so I propose removing it. I don't understand what it means to, in this context, support maintenance. Does it mean that you simply do the maintenance? Does that mean it really just means "maintain"? Do we really mean that we mantain support, rather than support maintenance? That information does not seem necessary to include. I'm not sure it's meaningful. With (for example) Windows, is it accurate to say that the Node.js core team maintains support for it? Or is it accurate to say that support is maintaned by smaller groups or individuals within the Node.js core team? Both could be considered accurate. So is the difference meaningful? I think the more important elements of determinig tier support are the other listed elements. PR-URL: https://github.com/nodejs/node/pull/30365 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2019-11-11doc: add link to node-code-ide-configs in testingKamat, Trivikram
Refs: https://github.com/orgs/nodejs/teams/collaborators/discussions/58 This config will help contributors to run/debug tests on VSCode PR-URL: https://github.com/nodejs/node/pull/24012 Reviewed-By: James M Snell <jasnell@gmail.com>
2019-11-04build: add workaround for WSLgengjiawen
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: https://github.com/nodejs/node/pull/30221 Fixes: https://github.com/nodejs/node/issues/30189 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2019-11-02build: allow Python 3.8Michaël Zasso
PR-URL: https://github.com/nodejs/node/pull/30194 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2019-10-20build: default Windows build to Visual Studio 2019Michaël Zasso
Building and testing Node.js with Visual Studio 2019 is now working as expected. Fallback to VS 2017 if VS 2019 was not found. Fixes: https://github.com/nodejs/node/issues/27214 PR-URL: https://github.com/nodejs/node/pull/30022 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
2019-10-03tools: support full-icu by defaultSteven R. Loomis
Instead of an English-only icudt64l.dat in the repo, we now have icudt64l.dat.gz with all locales. - updated READMEs and docs - shrinker now copies source, and compresses (bzip2) the ICU data file - configure expects deps/icu-small to be full ICU with a full compressed data file Fixes: https://github.com/nodejs/node/issues/19214 Co-Authored-By: Richard Lau <riclau@uk.ibm.com> Co-Authored-By: Jan Olaf Krems <jan.krems@gmail.com> Co-Authored-By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/29522 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
2019-09-20build: update minimum Xcode version for macOSMichael Dawson
Update the minimum Xcode version for macOS to 10. We'll need this level to incorporate future V8 versions. Refs: https://github.com/nodejs/node/pull/29493 PR-URL: https://github.com/nodejs/node/pull/29622 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
2019-09-08build: update minimum AIX OS levelMichael Dawson
Update minimum AIX OS level to 7.2 TL2. Looks like this will be the version we can get into the CI so should be the base level for 13.X and above and will be in support for the life of 13.X. PR-URL: https://github.com/nodejs/node/pull/29476 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-09-05doc: change urls directly from 'http' to 'https'Maledong
There're some URLs with old links, change them together from 'http' to 'https'. Notice: 1. Since files of CHANGELOG may be generated through tools, I don't intend to change them together as the history track. 2. All the files in the 'deps' are of 3-rd parties, they will be overwritten for the next update, so avoid modifications for them. PR-URL: https://github.com/nodejs/node/pull/29422 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2019-09-03doc: use consistent indenting for unordered list itemsNick Schonning
Address Markdownlint MD007 rule. Default suggestion is 2 space indenting for unordered list items. PR-URL: https://github.com/nodejs/node/pull/29390 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2019-08-31doc: add blanks around code fencesNick Schonning
Addresses Markdownlint MD031 rule warnings PR-URL: https://github.com/nodejs/node/pull/29366 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com>
2019-08-18doc: improve example single-test commandDavid Guttman
Changes example command to refer to the full test directory: `./test/parallel/` instead of `./parallel/` PR-URL: https://github.com/nodejs/node/pull/29171 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-07-08doc: mention markdown linting in BUILDING.mdTariq Ramlall
BUILDING.md mentioned JS and C++ linting were performed in the 'make lint' command, but 'make lint' also performs markdown linting. This commit updates the docs to include markdown as one of the things being linted. PR-URL: https://github.com/nodejs/node/pull/28578 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-07-06doc: fix link in build instructionsGautham B A
The right one is #prerequisites. PR-URL: https://github.com/nodejs/node/pull/28572 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-02 09:52:31 +0000