diff options
| author | Steve Holme <steve_holme@hotmail.com> | 2016-04-03 17:30:51 +0100 |
|---|---|---|
| committer | Steve Holme <steve_holme@hotmail.com> | 2016-04-03 17:30:51 +0100 |
| commit | 1d451bdd999a254fc8321356514ed04e21e45a0b (patch) | |
| tree | 2eb552711cd07c26d5562d2e946a5fd0ac06844a /lib/vauth/krb5_gssapi.c | |
| parent | 156b8287a7d68569d6a43240fd7ed6b7380193b5 (diff) | |
| download | gnurl-1d451bdd999a254fc8321356514ed04e21e45a0b.tar.gz gnurl-1d451bdd999a254fc8321356514ed04e21e45a0b.tar.bz2 gnurl-1d451bdd999a254fc8321356514ed04e21e45a0b.zip | |
krb5: Small code tidy up
* Prefer dereference of string pointer rather than strlen()
* Free challenge pointer in one place
* Additional comments
Diffstat (limited to 'lib/vauth/krb5_gssapi.c')
| -rw-r--r-- | lib/vauth/krb5_gssapi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/vauth/krb5_gssapi.c b/lib/vauth/krb5_gssapi.c index 0e0db5bc4..8e1ea827b 100644 --- a/lib/vauth/krb5_gssapi.c +++ b/lib/vauth/krb5_gssapi.c @@ -113,7 +113,7 @@ CURLcode Curl_auth_create_gssapi_user_message(struct SessionHandle *data, free(spn); } - if(chlg64 && strlen(chlg64)) { + if(chlg64 && *chlg64) { /* Decode the base-64 encoded challenge message */ if(*chlg64 != '=') { result = Curl_base64_decode(chlg64, &chlg, &chlglen); @@ -144,6 +144,7 @@ CURLcode Curl_auth_create_gssapi_user_message(struct SessionHandle *data, mutual_auth, NULL); + /* Free the decoded challenge as it is not required anymore */ free(input_token.value); if(GSS_ERROR(major_status)) { |