diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2018-10-23 00:31:16 +0200 |
|---|---|---|
| committer | Daniel Stenberg <daniel@haxx.se> | 2018-10-26 13:51:07 +0200 |
| commit | ebfe02f73c0723bd44b03b14183a24cf2b4fddca (patch) | |
| tree | 4727d94a891e7d0ef0e4bfc95f8ede5d27670c1e | |
| parent | bbce45fb00f26c92213fd0182f3416b48034bac2 (diff) | |
| download | gnurl-ebfe02f73c0723bd44b03b14183a24cf2b4fddca.tar.gz gnurl-ebfe02f73c0723bd44b03b14183a24cf2b4fddca.tar.bz2 gnurl-ebfe02f73c0723bd44b03b14183a24cf2b4fddca.zip | |
gtls: Values stored to but never read
Detected by clang-tidy
Closes #3176
| -rw-r--r-- | lib/vtls/gtls.c | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/lib/vtls/gtls.c b/lib/vtls/gtls.c index 8b8b64bde..37662a748 100644 --- a/lib/vtls/gtls.c +++ b/lib/vtls/gtls.c @@ -756,7 +756,6 @@ gtls_connect_step1(struct connectdata *conn, switch(SSL_CONN_CONFIG(version)) { case CURL_SSLVERSION_SSLv3: prioritylist = GNUTLS_CIPHERS ":-VERS-TLS-ALL:+VERS-SSL3.0"; - sni = false; break; case CURL_SSLVERSION_DEFAULT: case CURL_SSLVERSION_TLSv1: @@ -1153,8 +1152,8 @@ gtls_connect_step3(struct connectdata *conn, return CURLE_SSL_INVALIDCERTSTATUS; } - rc = gnutls_ocsp_resp_get_single(ocsp_resp, 0, NULL, NULL, NULL, NULL, - &status, NULL, NULL, NULL, &reason); + (void)gnutls_ocsp_resp_get_single(ocsp_resp, 0, NULL, NULL, NULL, NULL, + &status, NULL, NULL, NULL, &reason); switch(status) { case GNUTLS_OCSP_CERT_GOOD: @@ -1640,7 +1639,7 @@ static int Curl_gtls_shutdown(struct connectdata *conn, int sockindex) ssize_t result; int retval = 0; struct Curl_easy *data = conn->data; - int done = 0; + bool done = FALSE; char buf[120]; /* This has only been tested on the proftpd server, and the mod_tls code @@ -1664,7 +1663,7 @@ static int Curl_gtls_shutdown(struct connectdata *conn, int sockindex) case 0: /* This is the expected response. There was no data but only the close notify alert */ - done = 1; + done = TRUE; break; case GNUTLS_E_AGAIN: case GNUTLS_E_INTERRUPTED: @@ -1672,21 +1671,20 @@ static int Curl_gtls_shutdown(struct connectdata *conn, int sockindex) break; default: retval = -1; - done = 1; + done = TRUE; break; } } else if(0 == what) { /* timeout */ failf(data, "SSL shutdown timeout"); - done = 1; - break; + done = TRUE; } else { /* anything that gets here is fatally bad */ failf(data, "select/poll on SSL socket, errno: %d", SOCKERRNO); retval = -1; - done = 1; + done = TRUE; } } gnutls_deinit(BACKEND->session); |