summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSteve Holme <steve_holme@hotmail.com>2013-02-05 21:09:34 +0000
committerSteve Holme <steve_holme@hotmail.com>2013-02-05 21:09:34 +0000
commit1d22407863849fc3d5f5ba26735ef479295f3d57 (patch)
tree2ec3a0cae3db1a55377be18a0ca4ad0aab93995d
parentbb7c2ee37c46e6f1d75a4c4ba5e37209e4b9bf7b (diff)
downloadgnurl-1d22407863849fc3d5f5ba26735ef479295f3d57.tar.gz
gnurl-1d22407863849fc3d5f5ba26735ef479295f3d57.tar.bz2
gnurl-1d22407863849fc3d5f5ba26735ef479295f3d57.zip
email: Reworked comments in the endofresp() functions
Tidied up the comments in the endofresp() functions to be more meaningful prior to release.
-rw-r--r--lib/imap.c8
-rw-r--r--lib/pop3.c6
-rw-r--r--lib/smtp.c4
3 files changed, 9 insertions, 9 deletions
diff --git a/lib/imap.c b/lib/imap.c
index fd1d7e426..72ec871f9 100644
--- a/lib/imap.c
+++ b/lib/imap.c
@@ -323,8 +323,8 @@ static char* imap_atom(const char* str)
}
/* Function that checks for an ending imap status code at the start of the
- given string but also detects the supported mechanisms from the CAPABILITY
- response. */
+ given string but also detects the supported authentication mechanisms from
+ the CAPABILITY response. */
static int imap_endofresp(struct pingpong *pp, int *resp)
{
char *line = pp->linestart_resp;
@@ -378,11 +378,11 @@ static int imap_endofresp(struct pingpong *pp, int *resp)
line[wordlen] != '\n';)
wordlen++;
- /* Has the server explicitly disabled the LOGIN command? */
+ /* Has the server explicitly disabled clear text authentication? */
if(wordlen == 13 && !memcmp(line, "LOGINDISABLED", 13))
imapc->login_disabled = TRUE;
- /* Do we have an AUTH capability? */
+ /* Do we have a SASL based authentication mechanism? */
else if(wordlen > 5 && !memcmp(line, "AUTH=", 5)) {
line += 5;
len -= 5;
diff --git a/lib/pop3.c b/lib/pop3.c
index e9eeb3a8a..f0c6155c0 100644
--- a/lib/pop3.c
+++ b/lib/pop3.c
@@ -260,19 +260,19 @@ static int pop3_endofresp(struct pingpong *pp, int *resp)
return TRUE;
}
- /* Does the server support clear text? */
+ /* Does the server support clear text authentication? */
if(len >= 4 && !memcmp(line, "USER", 4)) {
pop3c->authtypes |= POP3_TYPE_CLEARTEXT;
return FALSE;
}
- /* Does the server support APOP? */
+ /* Does the server support APOP authentication? */
if(len >= 4 && !memcmp(line, "APOP", 4)) {
pop3c->authtypes |= POP3_TYPE_APOP;
return FALSE;
}
- /* Does the server support SASL? */
+ /* Does the server support SASL based authentication? */
if(len < 4 || memcmp(line, "SASL", 4))
return FALSE;
diff --git a/lib/smtp.c b/lib/smtp.c
index 02048b05d..d2d4aeb14 100644
--- a/lib/smtp.c
+++ b/lib/smtp.c
@@ -226,13 +226,13 @@ static int smtp_endofresp(struct pingpong *pp, int *resp)
line += 4;
len -= 4;
- /* Do we have a SIZE capability? */
+ /* Does the server support the SIZE capability? */
if(smtpc->state == SMTP_EHLO && len >= 4 && !memcmp(line, "SIZE", 4)) {
DEBUGF(infof(conn->data, "Server supports SIZE extension.\n"));
smtpc->size_supported = true;
}
- /* Do we have an AUTH capability? */
+ /* Do we have the authentication mechanism list? */
if(smtpc->state == SMTP_EHLO && len >= 5 && !memcmp(line, "AUTH ", 5)) {
line += 5;
len -= 5;