summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Stenberg <daniel@haxx.se>2004-10-11 17:23:41 +0000
committerDaniel Stenberg <daniel@haxx.se>2004-10-11 17:23:41 +0000
commit34342bcd194f372c48be3a216cdea075e35f2c40 (patch)
treefe77db64efc951b4be57b14d45010d7a0b981faf
parent5322a86313b84e5c6732b23bbea011b14e82fbbb (diff)
downloadgnurl-34342bcd194f372c48be3a216cdea075e35f2c40.tar.gz
gnurl-34342bcd194f372c48be3a216cdea075e35f2c40.tar.bz2
gnurl-34342bcd194f372c48be3a216cdea075e35f2c40.zip
SO_NOSIGPIPE
-rw-r--r--CHANGES6
-rw-r--r--lib/connect.c20
2 files changed, 26 insertions, 0 deletions
diff --git a/CHANGES b/CHANGES
index e57f62456..7c24347a9 100644
--- a/CHANGES
+++ b/CHANGES
@@ -6,6 +6,12 @@
Changelog
+Daniel (11 October 2004)
+- libcurl now uses SO_NOSIGPIPE for systems that support it (Mac OS X 10.2 or
+ later is one) to inhibit the SIGPIPE signal when writing to a socket while
+ the peer dies. The same effect is provide by the MSG_NOSIGNAL parameter to
+ send() on other systems. Alan Pinstein verified the fix.
+
Gisle (6 October 2004)
- For USE_LIBIDN builds: Added Top-Level-Domain (TLD) check of host-name
used in fix_hostname(). Checks if characters in 'host->name' (indirectly
diff --git a/lib/connect.c b/lib/connect.c
index 3ff73636d..7343756b9 100644
--- a/lib/connect.c
+++ b/lib/connect.c
@@ -558,6 +558,23 @@ static void tcpnodelay(struct connectdata *conn,
#endif
}
+#ifdef SO_NOSIGPIPE
+/* The preferred method on Mac OS X (10.2 and later) to prevent SIGPIPEs when
+ sending data to a dead peer (instead of relying on the 4th argument to send
+ being MSG_NOSIGNAL). Possibly also existing and in use on other BSD
+ systems? */
+static void nosigpipe(struct connectdata *conn,
+ curl_socket_t sockfd)
+{
+ struct SessionHandle *data= conn->data;
+ int onoff = 1;
+ if(setsockopt(sockfd, SOL_SOCKET, SO_NOSIGPIPE, (void *)&onoff,
+ sizeof(onoff)) < 0)
+ infof(data, "Could not set SO_NOSIGPIPE: %s\n",
+ Curl_strerror(conn, Curl_ourerrno()));
+}
+#endif
+
/* singleipconnect() connects to the given IP only, and it may return without
having connected if used from the multi interface. */
static curl_socket_t
@@ -584,6 +601,9 @@ singleipconnect(struct connectdata *conn,
if(data->set.tcp_nodelay)
tcpnodelay(conn, sockfd);
+#ifdef SO_NOSIGPIPE
+ nosigpipe(conn, sockfd);
+#endif
if(conn->data->set.device) {
/* user selected to bind the outgoing socket to a specified "device"
before doing connect */