summaryrefslogtreecommitdiff
path: root/src/lib/exchange_api_recoup.c
AgeCommit message (Collapse)Author
2022-02-21-big renaming of structs for consistent naming with P suffixChristian Grothoff
2022-02-17-fix CS nonce reuse check logicChristian Grothoff
2022-02-14-towards fixing the protocolChristian Grothoff
2022-02-12-remove legacy uncrustify workaroundChristian Grothoff
2022-02-12-remove addessed documentation FIXMEsChristian Grothoff
2022-02-11-simplify: nonce no longer hashedChristian Grothoff
2022-02-11-get tests to passChristian Grothoff
2022-02-10-get recoup/refresh to passChristian Grothoff
2022-02-09pass exchange values to /recoupChristian Grothoff
2022-02-06-fix refresh FTBFSChristian Grothoff
2022-02-06-fix melt FTBFSChristian Grothoff
2022-01-11The current recoup API is broken. I guess this is another example where ↵Christian Grothoff
"trivial" API changes turn out to have (multiple!) unexpected consequences. The current "/recoup" API does not have clear idempotency semantics, as we've discussed on the phone. This is already bad by itself, as it makes it hard to write down what the API does other than "whatever the implementation does". However, it actually breaks correctness in this (admittedly kinda contrived, but not impossible) case: Say that we have a coin A obtained via withdrawal and a coin B obtained via refreshing coin A. Now the denominations of A gets revoked.. The wallet does a recoup of A for EUR:1. Now the denomination of B also gets revoked. The wallet recoups B (incidentally also for EUR:1) and now A can be recouped again for EUR:1. But now the exchange is in a state where it will refuse a legitimate recoup request for A because the detection for an idempotent request kicks in. This is IMHO bad API design, and the exchange should simply always recoup the maximum amount. Furthermore, we usually follow the principle of "API calls that take up DB space are paid". With the current recoup API, I can do many tiny recoup requests which the exchange then has to store, right? I guess it would not be a big change to remove the "amount" value from the recoup/recoup-refresh request bodies, right? - Florian
2021-12-25protocol v12 changes (/recoup split, signature changes) plus database ↵Christian Grothoff
sharding plus O(n^2)=>O(n) worst-case complexity reduction on coin balance checks
2021-12-16-fix recoup uglinessChristian Grothoff
2021-12-14introducing GNUNET_TIME_Timestamp, recoup now with amountsChristian Grothoff
2021-10-27rename festChristian Grothoff
2021-10-27-fix more FTBFSChristian Grothoff
2021-07-31-more eliminations of json_packChristian Grothoff
2021-03-05fix #6786: do not die on bogus URLChristian Grothoff
2020-12-20do not log error on MHD_HTTP_GONE status code, revocation is a legitimate replyChristian Grothoff
2020-11-07adjust ECsChristian Grothoff
2020-07-08implement new behavior in exchange httpd and libtalerexchange (for #6416)Christian Grothoff
2020-04-08adapt to new GNUnet sign API (#6164)Christian Grothoff
2020-04-05make exchange API more uniform in how information is returnedChristian Grothoff
2020-03-20make recoup idempotent and simplify responseFlorian Dold
2020-03-20improving benchmarking logic, including more timingsChristian Grothoff
2020-03-03rename BANK_excecute_wire_transfer to BANK_transfer, improve error handling ↵Christian Grothoff
when curl_easy_init() fails
2020-02-29limit redirectsChristian Grothoff
2020-02-26updating libtalerexchange to new REST API (#6067)Christian Grothoff
2020-01-19fix copyright headers as per CAChristian Grothoff
2020-01-18payback -> recoup stranglersChristian Grothoff