Changing configuration structure to enable multiple accounts.

This change enables using multiple wire plugins at the same time.
Also, we now distinguish between the wire plugin (i.e. EBICS or
taler_bank) and the wire method (i.e. SEPA or x-taler-bank) that
the wire plugin is implementing.  The "taler-bank" wire method
was renamed from "test" to "x-taler-bank".

This also changes the format of the /wire response of the exchange,
as we now need to return multiple accounts.  Note that wire fees
are specified per wire method, not per wire account.

taler-exchange-keyup now automatically signs all of the /wire
responses in the location specified by the configuration.

Account identification in wire plugins was changed to use
payto://-URLs instead of method-specific JSON fields.  Signing
and validation of /wire responses was moved from each wire
plugin to a generic validation method in libtalerutil (crypto)
or libtalerjson (for JSON-formatted inputs).
Convenience methods were added to generate JSON for wire accounts
(salting, signing).

Various section and option names were adjusted to streamline the
configuration and make it more consistent overall.  Documentation
was updated as well.

1 files changed, 0 insertions, 269 deletions

diff --git a/src/wire/test_wire_plugin.c b/src/wire/test_wire_plugin.c
deleted file mode 100644
index f5dba01aa..000000000
--- a/src/wire/test_wire_plugin.c
+++ /dev/null
@@ -1,269 +0,0 @@
-/*
-  This file is part of TALER
-  (C) 2015, 2016, 2017 GNUnet e.V. and Inria
-
-  TALER is free software; you can redistribute it and/or modify it under the
-  terms of the GNU General Public License as published by the Free Software
-  Foundation; either version 3, or (at your option) any later version.
-
-  TALER is distributed in the hope that it will be useful, but WITHOUT ANY
-  WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-  A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
-
-  You should have received a copy of the GNU General Public License along with
-  TALER; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
-*/
-/**
- * @file wire/test_wire_plugin.c
- * @brief Tests for wire plugins
- * @author Christian Grothoff
- * @author Sree Harsha Totakura <sreeharsha@totakura.in>
- */
-#include "platform.h"
-#include "taler_util.h"
-#include "taler_wire_lib.h"
-#include "taler_wire_plugin.h"
-#include <gnunet/gnunet_json_lib.h>
-#include <jansson.h>
-
-
-/**
- * Definitions for a test with a plugin.
- */
-struct TestBlock {
-
-  /**
-   * Name of the plugin to test.
-   */
-  const char *plugin_name;
-
-  /**
-   * JSON template expected by the plugin for an account definition.
-   */
-  const char *json_proto;
-
-  /**
-   * Amount to give to the rounding function.
-   */
-  const char *round_in;
-
-  /**
-   * Expected result from rounding.
-   */
-  const char *round_out;
-
-  /**
-   * Currency to give to the plugin.
-   */ 
-  const char *currency;
-};
-
-
-/**
- * List of plugins and (unsigned) JSON account definitions
- * to use for the tests.
- */
-static struct TestBlock tests[] = {
-  {
-    .plugin_name = "sepa",
-    .json_proto = "{  \"type\":\"sepa\", \"iban\":\"DE67830654080004822650\", \"name\":\"GNUnet e.V.\", \"bic\":\"GENODEF1SLR\" }",
-    .round_in = "EUR:0.123456",
-    .round_out = "EUR:0.12",
-    .currency = "EUR"
-  },
-  {
-    .plugin_name = "test",
-    .json_proto = "{  \"type\":\"test\", \"bank_url\":\"http://localhost/\", \"account_number\":42 }",
-    .round_in = "KUDOS:0.123456",
-    .round_out = "KUDOS:0.12",
-    .currency = "KUDOS"
-  },
-  {
-    NULL, NULL, NULL, NULL, NULL
-  }
-};
-
-
-/**
- * Private key used to sign wire details.
- */
-static struct TALER_MasterPrivateKeyP priv_key;
-
-/**
- * Public key matching #priv_key.
- */
-static struct TALER_MasterPublicKeyP pub_key;
-
-/**
- * Our configuration.
- */
-static struct GNUNET_CONFIGURATION_Handle *cfg;
-
-
-/**
- * Run the test.
- *
- * @param test details of the test
- * @param plugin plugin to test
- * @param wire wire details for testing
- * @return #GNUNET_OK on success
- */
-static int
-run_test (const struct TestBlock *test,
-          struct TALER_WIRE_Plugin *plugin,
-          json_t *wire)
-{
-  struct GNUNET_HashCode salt;
-  struct TALER_MasterSignatureP sig;
-  json_t *lwire;
-  struct TALER_Amount in;
-  struct TALER_Amount expect;
-  char *emsg;
-
-  GNUNET_CRYPTO_random_block (GNUNET_CRYPTO_QUALITY_NONCE,
-                              &salt,
-                              sizeof (salt));
-  if (GNUNET_OK !=
-      plugin->sign_wire_details (plugin->cls,
-                                 wire,
-                                 &priv_key,
-                                 &salt,
-                                 &sig))
-  {
-    GNUNET_break (0);
-    return GNUNET_SYSERR;
-  }
-  json_object_set_new (wire,
-                       "salt",
-                       GNUNET_JSON_from_data (&salt,
-                                              sizeof (salt)));
-  json_object_set_new (wire,
-                       "sig",
-                       GNUNET_JSON_from_data (&sig,
-                                              sizeof (sig)));
-  if (TALER_EC_NONE !=
-      plugin->wire_validate (plugin->cls,
-                             wire,
-                             &pub_key,
-                             &emsg))
-  {
-    GNUNET_break (0);
-    GNUNET_free (emsg);
-    return GNUNET_SYSERR;
-  }
-  /* load wire details from file */
-  lwire = plugin->get_wire_details (plugin->cls,
-                                    cfg,
-                                    test->plugin_name);
-  if (NULL == lwire)
-  {
-    GNUNET_break (0);
-    return GNUNET_SYSERR;
-  }
-  if (TALER_EC_NONE !=
-      plugin->wire_validate (plugin->cls,
-                             lwire,
-                             &pub_key,
-                             &emsg))
-  {
-    GNUNET_break (0);
-    GNUNET_free (emsg);
-    json_decref (lwire);
-    return GNUNET_SYSERR;
-  }
-  json_decref (lwire);
-  GNUNET_assert (GNUNET_OK ==
-                 TALER_string_to_amount (test->round_in,
-                                         &in));
-  GNUNET_assert (GNUNET_OK ==
-                 TALER_string_to_amount (test->round_out,
-                                         &expect));
-  if (GNUNET_OK !=
-      plugin->amount_round (plugin->cls,
-                            &in))
-  {
-    GNUNET_break (0);
-    return GNUNET_SYSERR;
-  }
-  if (0 != TALER_amount_cmp (&in, &expect))
-  {
-    GNUNET_break (0);
-    return GNUNET_SYSERR;
-  }
-  if (GNUNET_NO !=
-      plugin->amount_round (plugin->cls,
-                            &in))
-  {
-    GNUNET_break (0);
-    return GNUNET_SYSERR;
-  }
-  memset (&in, 0, sizeof (in));
-  GNUNET_log_skip (GNUNET_ERROR_TYPE_ERROR, 1);
-  if (GNUNET_SYSERR !=
-      plugin->amount_round (plugin->cls,
-                            &in))
-  {
-    GNUNET_break (0);
-    return GNUNET_SYSERR;
-  }
-  return GNUNET_OK;
-}
-
-
-int
-main (int argc,
-      const char *const argv[])
-{
-  json_t *wire;
-  int ret;
-  struct TALER_WIRE_Plugin *plugin;
-  const struct TestBlock *test;
-  unsigned int i;
-  struct GNUNET_CRYPTO_EddsaPrivateKey *pk;
-
-  GNUNET_log_setup ("test-wire-plugin",
-                    "WARNING",
-                    NULL);
-  cfg = GNUNET_CONFIGURATION_create ();
-  GNUNET_assert (GNUNET_OK ==
-                 GNUNET_CONFIGURATION_load (cfg,
-                                            "test_wire_plugin.conf"));
-  pk = GNUNET_CRYPTO_eddsa_key_create_from_file ("test_wire_plugin_key.priv");
-  priv_key.eddsa_priv = *pk;
-  GNUNET_free (pk);
-  GNUNET_CRYPTO_eddsa_key_get_public (&priv_key.eddsa_priv,
-                                      &pub_key.eddsa_pub);
-  ret = GNUNET_OK;
-  for (i=0;NULL != (test = &tests[i])->plugin_name;i++)
-  {
-    GNUNET_CONFIGURATION_set_value_string (cfg,
-					   "taler",
-					   "CURRENCY",
-					   test->currency);
-    plugin = TALER_WIRE_plugin_load (cfg,
-                                     test->plugin_name);
-    GNUNET_assert (NULL != plugin);
-    wire = json_loads (test->json_proto, 0, NULL);
-    GNUNET_assert (NULL != wire);
-    ret = run_test (test, plugin, wire);
-    json_decref (wire);
-    TALER_WIRE_plugin_unload (plugin);
-    if (GNUNET_OK != ret)
-    {
-      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-		  "%s FAILED\n",
-		  test->plugin_name);
-      break;
-    }
-    else
-    {
-      GNUNET_log (GNUNET_ERROR_TYPE_MESSAGE,
-		  "%s PASS\n",
-		  test->plugin_name);
-    }
-  }
-  GNUNET_CONFIGURATION_destroy (cfg);
-  if (GNUNET_OK != ret)
-    return 1;
-  return 0;
-}