fix warnings

21 files changed, 57 insertions, 4 deletions

diff --git a/src/auditordb/plugin_auditordb_postgres.c b/src/auditordb/plugin_auditordb_postgres.c
index c5559131f..19714e129 100644
--- a/src/auditordb/plugin_auditordb_postgres.c
+++ b/src/auditordb/plugin_auditordb_postgres.c
@@ -1027,6 +1027,7 @@ postgres_start (void *cls,
     GNUNET_PQ_EXECUTE_STATEMENT_END
   };
 
+  (void) cls;
   if (GNUNET_OK !=
       GNUNET_PQ_exec_statements (session->conn,
                                  es))
diff --git a/src/exchange-tools/taler-exchange-dbinit.c b/src/exchange-tools/taler-exchange-dbinit.c
index afc1b837e..e9a1e3349 100644
--- a/src/exchange-tools/taler-exchange-dbinit.c
+++ b/src/exchange-tools/taler-exchange-dbinit.c
@@ -54,6 +54,9 @@ run (void *cls,
 {
   struct TALER_EXCHANGEDB_Plugin *plugin;
 
+  (void) cls;
+  (void) args;
+  (void) cfgfile;
   if (NULL ==
       (plugin = TALER_EXCHANGEDB_plugin_load (cfg)))
   {
diff --git a/src/exchange-tools/taler-exchange-keycheck.c b/src/exchange-tools/taler-exchange-keycheck.c
index 2c2ebcf9f..42b1b511b 100644
--- a/src/exchange-tools/taler-exchange-keycheck.c
+++ b/src/exchange-tools/taler-exchange-keycheck.c
@@ -57,6 +57,7 @@ signkeys_iter (void *cls,
                const char *filename,
                const struct TALER_EXCHANGEDB_PrivateSigningKeyInformationP *ski)
 {
+  (void) cls;
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Iterating over key `%s' for start time %s\n",
               filename,
@@ -135,6 +136,7 @@ denomkeys_iter (void *cls,
 {
   struct GNUNET_HashCode hc;
 
+  (void) cls;
   if (ntohl (dki->issue.properties.purpose.size) !=
       sizeof (struct TALER_DenominationKeyValidityPS))
   {
@@ -235,6 +237,9 @@ run (void *cls,
      const char *cfgfile,
      const struct GNUNET_CONFIGURATION_Handle *cfg)
 {
+  (void) cls;
+  (void) args;
+  (void) cfgfile;
   kcfg = cfg;
   if (GNUNET_OK !=
       GNUNET_CONFIGURATION_get_value_filename (kcfg,
diff --git a/src/exchange-tools/taler-exchange-keyup.c b/src/exchange-tools/taler-exchange-keyup.c
index 8e982d17e..d974ec46a 100644
--- a/src/exchange-tools/taler-exchange-keyup.c
+++ b/src/exchange-tools/taler-exchange-keyup.c
@@ -1201,6 +1201,9 @@ run (void *cls,
   struct GNUNET_TIME_Relative lookahead_sign;
   struct GNUNET_CRYPTO_EddsaPrivateKey *eddsa_priv;
 
+  (void) cls;
+  (void) args;
+  (void) cfgfile;
   kcfg = cfg;
 
   if (now.abs_value_us != now_tmp.abs_value_us)
diff --git a/src/exchange-tools/taler-exchange-wire.c b/src/exchange-tools/taler-exchange-wire.c
index 22920ed28..ae8a4a740 100644
--- a/src/exchange-tools/taler-exchange-wire.c
+++ b/src/exchange-tools/taler-exchange-wire.c
@@ -61,6 +61,7 @@ sign_account_data (void *cls,
   FILE *out;
   int ret;
 
+  (void) cls;
   if (GNUNET_NO == ai->credit_enabled)
     return;
   if (NULL == ai->wire_response_filename)
@@ -137,6 +138,9 @@ run (void *cls,
   struct GNUNET_CRYPTO_EddsaPublicKey mpub;
   struct GNUNET_CRYPTO_EddsaPublicKey mpub_cfg;
 
+  (void) cls;
+  (void) args;
+  (void) cfgfile;
   if ( (NULL == masterkeyfile) &&
        (GNUNET_OK !=
         GNUNET_CONFIGURATION_get_value_filename (cfg,
diff --git a/src/exchange-tools/taler-wire.c b/src/exchange-tools/taler-wire.c
index 4d6e0fcd7..12963324a 100644
--- a/src/exchange-tools/taler-wire.c
+++ b/src/exchange-tools/taler-wire.c
@@ -116,6 +116,7 @@ history_cb (void *cls,
 {
   char *row_off_enc;
 
+  (void) cls;
   if (TALER_BANK_DIRECTION_NONE == dir)
   {
     fprintf (stdout,
diff --git a/src/exchange/taler-exchange-httpd_deposit.c b/src/exchange/taler-exchange-httpd_deposit.c
index 9e96dfd81..e1b30272c 100644
--- a/src/exchange/taler-exchange-httpd_deposit.c
+++ b/src/exchange/taler-exchange-httpd_deposit.c
@@ -411,6 +411,7 @@ TEH_DEPOSIT_handler_deposit (struct TEH_RequestHandler *rh,
     GNUNET_JSON_spec_end ()
   };
 
+  (void) rh;
   res = TEH_PARSE_post_json (connection,
                              connection_cls,
                              upload_data,
diff --git a/src/exchange/taler-exchange-httpd_mhd.c b/src/exchange/taler-exchange-httpd_mhd.c
index dfea44adb..95e51c8ed 100644
--- a/src/exchange/taler-exchange-httpd_mhd.c
+++ b/src/exchange/taler-exchange-httpd_mhd.c
@@ -53,6 +53,9 @@ TEH_MHD_handler_static_response (struct TEH_RequestHandler *rh,
   struct MHD_Response *response;
   int ret;
 
+  (void) connection_cls;
+  (void) upload_data;
+  (void) upload_data_size;
   if (0 == rh->data_size)
     rh->data_size = strlen ((const char *) rh->data);
   response = MHD_create_response_from_buffer (rh->data_size,
@@ -99,6 +102,9 @@ TEH_MHD_handler_agpl_redirect (struct TEH_RequestHandler *rh,
   struct MHD_Response *response;
   int ret;
 
+  (void) connection_cls;
+  (void) upload_data;
+  (void) upload_data_size;
   response = MHD_create_response_from_buffer (strlen (agpl),
                                               (void *) agpl,
                                               MHD_RESPMEM_PERSISTENT);
@@ -147,6 +153,9 @@ TEH_MHD_handler_send_json_pack_error (struct TEH_RequestHandler *rh,
                                       const char *upload_data,
                                       size_t *upload_data_size)
 {
+  (void) connection_cls;
+  (void) upload_data;
+  (void) upload_data_size;
   return TEH_RESPONSE_reply_json_pack (connection,
                                        rh->response_code,
                                        "{s:s}",
diff --git a/src/exchange/taler-exchange-httpd_payback.c b/src/exchange/taler-exchange-httpd_payback.c
index 468d69b3f..8a881ffff 100644
--- a/src/exchange/taler-exchange-httpd_payback.c
+++ b/src/exchange/taler-exchange-httpd_payback.c
@@ -598,6 +598,7 @@ TEH_PAYBACK_handler_payback (struct TEH_RequestHandler *rh,
     GNUNET_JSON_spec_end ()
   };
 
+  (void) rh;
   res = TEH_PARSE_post_json (connection,
                              connection_cls,
                              upload_data,
diff --git a/src/exchange/taler-exchange-httpd_refresh_link.c b/src/exchange/taler-exchange-httpd_refresh_link.c
index d29d4e642..c51887a95 100644
--- a/src/exchange/taler-exchange-httpd_refresh_link.c
+++ b/src/exchange/taler-exchange-httpd_refresh_link.c
@@ -194,6 +194,10 @@ TEH_REFRESH_handler_refresh_link (struct TEH_RequestHandler *rh,
   int res;
   struct HTD_Context ctx;
 
+  (void) rh;
+  (void) connection_cls;
+  (void) upload_data;
+  (void) upload_data_size;
   memset (&ctx,
           0,
           sizeof (ctx));
diff --git a/src/exchange/taler-exchange-httpd_refresh_melt.c b/src/exchange/taler-exchange-httpd_refresh_melt.c
index 76f0fac72..538d8afe2 100644
--- a/src/exchange/taler-exchange-httpd_refresh_melt.c
+++ b/src/exchange/taler-exchange-httpd_refresh_melt.c
@@ -464,6 +464,7 @@ TEH_REFRESH_handler_refresh_melt (struct TEH_RequestHandler *rh,
     GNUNET_JSON_spec_end ()
   };
 
+  (void) rh;
   res = TEH_PARSE_post_json (connection,
                              connection_cls,
                              upload_data,
diff --git a/src/exchange/taler-exchange-httpd_refresh_reveal.c b/src/exchange/taler-exchange-httpd_refresh_reveal.c
index 29f0738ad..c1a7b6392 100644
--- a/src/exchange/taler-exchange-httpd_refresh_reveal.c
+++ b/src/exchange/taler-exchange-httpd_refresh_reveal.c
@@ -874,6 +874,7 @@ TEH_REFRESH_handler_refresh_reveal (struct TEH_RequestHandler *rh,
     GNUNET_JSON_spec_end ()
   };
 
+  (void) rh;
   res = TEH_PARSE_post_json (connection,
                              connection_cls,
                              upload_data,
diff --git a/src/exchange/taler-exchange-httpd_refund.c b/src/exchange/taler-exchange-httpd_refund.c
index ce66d6578..93df54c8a 100644
--- a/src/exchange/taler-exchange-httpd_refund.c
+++ b/src/exchange/taler-exchange-httpd_refund.c
@@ -509,6 +509,7 @@ TEH_REFUND_handler_refund (struct TEH_RequestHandler *rh,
     GNUNET_JSON_spec_end ()
   };
 
+  (void) rh;
   res = TEH_PARSE_post_json (connection,
                              connection_cls,
                              upload_data,
diff --git a/src/exchange/taler-exchange-httpd_reserve_status.c b/src/exchange/taler-exchange-httpd_reserve_status.c
index a3f4dac9d..4f9761485 100644
--- a/src/exchange/taler-exchange-httpd_reserve_status.c
+++ b/src/exchange/taler-exchange-httpd_reserve_status.c
@@ -91,7 +91,7 @@ struct ReserveStatusContext
  * @param connection MHD request which triggered the transaction
  * @param session database session to use
  * @param[out] mhd_ret set to MHD response status for @a connection,
- *             if transaction failed (!)
+ *             if transaction failed (!); unused
  * @return transaction status
  */
 static enum GNUNET_DB_QueryStatus
@@ -102,6 +102,8 @@ reserve_status_transaction (void *cls,
 {
   struct ReserveStatusContext *rsc = cls;
 
+  (void) connection;
+  (void) mhd_ret;
   return TEH_plugin->get_reserve_history (TEH_plugin->cls,
                                           session,
                                           &rsc->reserve_pub,
diff --git a/src/exchange/taler-exchange-httpd_reserve_withdraw.c b/src/exchange/taler-exchange-httpd_reserve_withdraw.c
index e5829d9dc..1199ed67d 100644
--- a/src/exchange/taler-exchange-httpd_reserve_withdraw.c
+++ b/src/exchange/taler-exchange-httpd_reserve_withdraw.c
@@ -380,6 +380,7 @@ TEH_RESERVE_handler_reserve_withdraw (struct TEH_RequestHandler *rh,
     GNUNET_JSON_spec_end ()
   };
 
+  (void) rh;
   res = TEH_PARSE_post_json (connection,
                              connection_cls,
                              upload_data,
diff --git a/src/exchange/taler-exchange-httpd_test.c b/src/exchange/taler-exchange-httpd_test.c
index b55a98885..0a64f267f 100644
--- a/src/exchange/taler-exchange-httpd_test.c
+++ b/src/exchange/taler-exchange-httpd_test.c
@@ -68,6 +68,7 @@ TEH_TEST_handler_test_base32 (struct TEH_RequestHandler *rh,
     GNUNET_JSON_spec_end ()
   };
 
+  (void) rh;
   res = TEH_PARSE_post_json (connection,
                              connection_cls,
                              upload_data,
diff --git a/src/exchange/taler-exchange-httpd_track_transaction.c b/src/exchange/taler-exchange-httpd_track_transaction.c
index c89192680..3b8d14a01 100644
--- a/src/exchange/taler-exchange-httpd_track_transaction.c
+++ b/src/exchange/taler-exchange-httpd_track_transaction.c
@@ -356,6 +356,7 @@ TEH_TRACKING_handler_track_transaction (struct TEH_RequestHandler *rh,
     GNUNET_JSON_spec_end ()
   };
 
+  (void) rh;
   res = TEH_PARSE_post_json (connection,
                              connection_cls,
                              upload_data,
diff --git a/src/exchange/taler-exchange-httpd_track_transfer.c b/src/exchange/taler-exchange-httpd_track_transfer.c
index 2aaeacd7e..cacbfaa85 100644
--- a/src/exchange/taler-exchange-httpd_track_transfer.c
+++ b/src/exchange/taler-exchange-httpd_track_transfer.c
@@ -280,6 +280,7 @@ handle_transaction_data (void *cls,
   struct TEH_TrackTransferDetail *wdd;
   char *wire_method;
 
+  (void) rowid;
   (void) denom_pub;
   if (GNUNET_SYSERR == ctx->is_valid)
     return;
diff --git a/src/exchange/taler-exchange-httpd_wire.c b/src/exchange/taler-exchange-httpd_wire.c
index 1bc4a8279..91c928f94 100644
--- a/src/exchange/taler-exchange-httpd_wire.c
+++ b/src/exchange/taler-exchange-httpd_wire.c
@@ -135,6 +135,10 @@ TEH_WIRE_handler_wire (struct TEH_RequestHandler *rh,
                        const char *upload_data,
                        size_t *upload_data_size)
 {
+  (void) rh;
+  (void) connection;
+  (void) upload_data;
+  (void) upload_data_size;
   GNUNET_assert (NULL != wire_methods);
   return TEH_RESPONSE_reply_json (connection,
                                   wire_methods,
diff --git a/src/exchange/taler-exchange-wirewatch.c b/src/exchange/taler-exchange-wirewatch.c
index 83d90c6e2..3699c9d3b 100644
--- a/src/exchange/taler-exchange-wirewatch.c
+++ b/src/exchange/taler-exchange-wirewatch.c
@@ -201,6 +201,7 @@ shutdown_task (void *cls)
 {
   struct WireAccount *wa;
 
+  (void) cls;
   if (NULL != task)
   {
     GNUNET_SCHEDULER_cancel (task);
@@ -583,6 +584,7 @@ find_transfers (void *cls)
   struct TALER_EXCHANGEDB_Session *session;
   enum GNUNET_DB_QueryStatus qs;
 
+  (void) cls;
   task = NULL;
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Checking for incoming wire transfers\n");
@@ -677,6 +679,9 @@ run (void *cls,
      const char *cfgfile,
      const struct GNUNET_CONFIGURATION_Handle *c)
 {
+  (void) cls;
+  (void) args;
+  (void) cfgfile;
   cfg = c;
   if (GNUNET_OK !=
       exchange_serve_process_config ())
diff --git a/src/wire-plugins/plugin_wire_taler-bank.c b/src/wire-plugins/plugin_wire_taler-bank.c
index b468496a8..ad8daa4ef 100644
--- a/src/wire-plugins/plugin_wire_taler-bank.c
+++ b/src/wire-plugins/plugin_wire_taler-bank.c
@@ -253,6 +253,7 @@ static void
 taler_bank_prepare_wire_transfer_cancel (void *cls,
                                          struct TALER_WIRE_PrepareHandle *pth)
 {
+  (void) cls;
   if (NULL != pth->task)
     GNUNET_SCHEDULER_cancel (pth->task);
   TALER_BANK_auth_free (&pth->auth);
@@ -547,6 +548,7 @@ execute_cb (void *cls,
   char *s;
   uint64_t serial_id_nbo;
 
+  (void) timestamp;
   eh->aaih = NULL;
   emsg = NULL;
   if (NULL != json)
@@ -567,15 +569,12 @@ execute_cb (void *cls,
                      "%u/%u",
                      http_status,
                      (unsigned int) ec);
-
   serial_id_nbo = GNUNET_htonll (serial_id);
-
   eh->cc (eh->cc_cls,
           (MHD_HTTP_OK == http_status) ? GNUNET_OK : GNUNET_SYSERR,
           &serial_id_nbo,
           sizeof (uint64_t),
           (MHD_HTTP_OK == http_status) ? NULL : s);
-
   GNUNET_free (s);
   GNUNET_free (eh);
 }
@@ -753,6 +752,7 @@ static void
 taler_bank_execute_wire_transfer_cancel (void *cls,
                                          struct TALER_WIRE_ExecuteHandle *eh)
 {
+  (void) cls;
   TALER_BANK_admin_add_incoming_cancel (eh->aaih);
   GNUNET_free (eh);
 }
@@ -841,6 +841,7 @@ bhist_cb (void *cls,
   uint64_t bserial_id = GNUNET_htonll (serial_id);
   struct TALER_WIRE_TransferDetails wd;
 
+  (void) json;
   switch (http_status)
   {
   case MHD_HTTP_OK:
@@ -1104,6 +1105,7 @@ reject_cb (void *cls,
 {
   struct TALER_WIRE_RejectHandle *rh = cls;
 
+  (void) http_status;
   rh->brh = NULL;
   rh->rej_cb (rh->rej_cb_cls,
               ec);
@@ -1129,6 +1131,7 @@ taler_bank_reject_transfer_cancel (void *cls,
 {
   void *ret = rh->rej_cb_cls;
 
+  (void) cls;
   if (NULL != rh->brh)
     TALER_BANK_reject_cancel (rh->brh);
   TALER_BANK_auth_free (&rh->auth);