aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Grothoff <christian@grothoff.org>2019-10-31 12:59:50 +0100
committerChristian Grothoff <christian@grothoff.org>2019-10-31 12:59:50 +0100
commit385b3e77dfa1b6bbaee5d0ec9da9bcbd69e91b70 (patch)
tree61550b547a56179e6abac9bee3502ecc5c537fa8
parent325aaddbd6612c3baa56d01f6777faf77d082588 (diff)
downloadexchange-385b3e77dfa1b6bbaee5d0ec9da9bcbd69e91b70.tar.gz
exchange-385b3e77dfa1b6bbaee5d0ec9da9bcbd69e91b70.zip
tighten formatting rules
-rw-r--r--contrib/uncrustify.cfg17
-rw-r--r--src/auditor/taler-auditor-exchange.c3
-rw-r--r--src/auditor/taler-auditor-httpd.c2
-rw-r--r--src/auditor/taler-auditor-httpd_parsing.c1
-rw-r--r--src/auditor/taler-auditor-sign.c1
-rw-r--r--src/auditor/taler-auditor.c7
-rw-r--r--src/auditor/taler-wire-auditor.c1
-rw-r--r--src/auditordb/auditordb_plugin.c1
-rw-r--r--src/auditordb/plugin_auditordb_postgres.c20
-rw-r--r--src/auditordb/test_auditordb.c2
-rw-r--r--src/bank-lib/bank_api_history.c2
-rw-r--r--src/bank-lib/fakebank.c5
-rw-r--r--src/bank-lib/fakebank.h1
-rw-r--r--src/bank-lib/fakebank_history.c1
-rw-r--r--src/bank-lib/taler-bank-transfer.c1
-rw-r--r--src/bank-lib/test_bank_api.c1
-rw-r--r--src/bank-lib/test_bank_api_new.c1
-rw-r--r--src/bank-lib/test_bank_api_twisted.c1
-rw-r--r--src/bank-lib/test_bank_api_with_fakebank.c1
-rw-r--r--src/bank-lib/test_bank_interpreter.c1
-rw-r--r--src/bank-lib/testing_api_cmd_history.c16
-rw-r--r--src/bank-lib/testing_api_cmd_reject.c1
-rw-r--r--src/bank-lib/testing_api_helpers.c1
-rw-r--r--src/benchmark/taler-exchange-benchmark.c4
-rw-r--r--src/exchange-tools/taler-exchange-keycheck.c1
-rw-r--r--src/exchange-tools/taler-exchange-keyup.c1
-rw-r--r--src/exchange-tools/taler-wire.c1
-rw-r--r--src/exchange/taler-exchange-aggregator.c2
-rw-r--r--src/exchange/taler-exchange-httpd.c3
-rw-r--r--src/exchange/taler-exchange-httpd_keystate.c3
-rw-r--r--src/exchange/taler-exchange-httpd_parsing.c1
-rw-r--r--src/exchange/taler-exchange-httpd_responses.c7
-rw-r--r--src/exchange/taler-exchange-httpd_wire.c1
-rw-r--r--src/exchange/taler-exchange-wirewatch.c1
-rw-r--r--src/exchange/test_taler_exchange_aggregator.c3
-rw-r--r--src/exchange/test_taler_exchange_wirewatch.c1
-rw-r--r--src/exchangedb/exchangedb_accounts.c1
-rw-r--r--src/exchangedb/exchangedb_plugin.c1
-rw-r--r--src/exchangedb/exchangedb_signkeys.c1
-rw-r--r--src/exchangedb/plugin_exchangedb_postgres.c25
-rw-r--r--src/exchangedb/test_exchangedb.c2
-rw-r--r--src/exchangedb/test_exchangedb_auditors.c1
-rw-r--r--src/include/taler_auditordb_plugin.h1
-rw-r--r--src/include/taler_crypto_lib.h1
-rw-r--r--src/include/taler_curl_lib.h1
-rw-r--r--src/include/taler_exchange_service.h2
-rw-r--r--src/include/taler_exchangedb_plugin.h1
-rw-r--r--src/include/taler_fakebank_lib.h1
-rw-r--r--src/include/taler_signatures.h1
-rw-r--r--src/include/taler_testing_bank_lib.h1
-rw-r--r--src/include/taler_testing_lib.h7
-rw-r--r--src/include/taler_util.h11
-rw-r--r--src/json/json.c2
-rw-r--r--src/json/json_helper.c1
-rw-r--r--src/json/test_json.c1
-rw-r--r--src/json/test_json_wire.c1
-rw-r--r--src/lib/auditor_api_handle.c1
-rw-r--r--src/lib/exchange_api_common.c10
-rw-r--r--src/lib/exchange_api_handle.c3
-rw-r--r--src/lib/exchange_api_refresh.c4
-rw-r--r--src/lib/exchange_api_refresh_link.c3
-rw-r--r--src/lib/exchange_api_reserve.c3
-rw-r--r--src/lib/test_auditor_api.c13
-rw-r--r--src/lib/test_auditor_api_version.c1
-rw-r--r--src/lib/test_exchange_api.c35
-rw-r--r--src/lib/test_exchange_api_interpreter_on-off.c1
-rw-r--r--src/lib/test_exchange_api_keys_cherry_picking.c11
-rw-r--r--src/lib/test_exchange_api_overlapping_keys_bug.c1
-rw-r--r--src/lib/test_exchange_api_revocation.c4
-rw-r--r--src/lib/test_exchange_api_twisted.c6
-rw-r--r--src/lib/testing_api_cmd_bank_check.c5
-rw-r--r--src/lib/testing_api_cmd_batch.c3
-rw-r--r--src/lib/testing_api_cmd_check_keys.c5
-rw-r--r--src/lib/testing_api_cmd_deposit.c1
-rw-r--r--src/lib/testing_api_cmd_exec_aggregator.c1
-rw-r--r--src/lib/testing_api_cmd_exec_auditor-sign.c1
-rw-r--r--src/lib/testing_api_cmd_exec_keyup.c2
-rw-r--r--src/lib/testing_api_cmd_exec_wirewatch.c2
-rw-r--r--src/lib/testing_api_cmd_fakebank_transfer.c2
-rw-r--r--src/lib/testing_api_cmd_payback.c1
-rw-r--r--src/lib/testing_api_cmd_refresh.c3
-rw-r--r--src/lib/testing_api_cmd_sleep.c1
-rw-r--r--src/lib/testing_api_cmd_status.c4
-rw-r--r--src/lib/testing_api_cmd_track.c8
-rw-r--r--src/lib/testing_api_cmd_wire.c1
-rw-r--r--src/lib/testing_api_cmd_withdraw.c1
-rw-r--r--src/lib/testing_api_helpers.c1
-rw-r--r--src/lib/testing_api_loop.c4
-rw-r--r--src/lib/testing_api_trait_blinding_key.c2
-rw-r--r--src/lib/testing_api_trait_cmd.c1
-rw-r--r--src/lib/testing_api_trait_coin_priv.c1
-rw-r--r--src/lib/testing_api_trait_denom_pub.c1
-rw-r--r--src/lib/testing_api_trait_exchange_pub.c1
-rw-r--r--src/lib/testing_api_trait_exchange_sig.c1
-rw-r--r--src/lib/testing_api_trait_fresh_coin.c1
-rw-r--r--src/lib/testing_api_trait_json.c2
-rw-r--r--src/lib/testing_api_trait_key_peer.c2
-rw-r--r--src/lib/testing_api_trait_number.c3
-rw-r--r--src/lib/testing_api_trait_process.c1
-rw-r--r--src/lib/testing_api_trait_reserve_priv.c1
-rw-r--r--src/lib/testing_api_trait_string.c8
-rw-r--r--src/lib/testing_api_trait_time.c2
-rw-r--r--src/lib/testing_api_trait_wtid.c1
-rw-r--r--src/lib/testing_api_traits.c2
-rw-r--r--src/lib/testing_auditor_api_cmd_exchanges.c1
-rw-r--r--src/lib/testing_auditor_api_cmd_exec_auditor.c1
-rw-r--r--src/lib/testing_auditor_api_cmd_exec_auditor_dbinit.c1
-rw-r--r--src/lib/testing_auditor_api_cmd_exec_wire_auditor.c1
-rw-r--r--src/lib/testing_auditor_api_helpers.c3
-rw-r--r--src/util/crypto.c3
-rw-r--r--src/util/test_amount.c1
-rw-r--r--src/util/test_crypto.c1
-rw-r--r--src/util/test_url.c1
-rw-r--r--src/util/util.c5
-rw-r--r--src/wire-plugins/plugin_wire_ebics.c2
-rw-r--r--src/wire-plugins/plugin_wire_taler-bank.c4
-rw-r--r--src/wire-plugins/plugin_wire_template.c1
-rw-r--r--src/wire-plugins/test_wire_plugin_transactions_taler-bank.c1
-rw-r--r--src/wire/payto.c1
-rw-r--r--src/wire/wire_helper.c1
120 files changed, 213 insertions, 167 deletions
diff --git a/contrib/uncrustify.cfg b/contrib/uncrustify.cfg
index f56c8e732..8c9df2c43 100644
--- a/contrib/uncrustify.cfg
+++ b/contrib/uncrustify.cfg
@@ -49,8 +49,12 @@ nl_assign_brace=remove
49 49
50# No extra newlines that cause noisy diffs 50# No extra newlines that cause noisy diffs
51nl_start_of_file=remove 51nl_start_of_file=remove
52nl_after_func_proto = 2
53nl_after_func_body = 3
52# If there's no new line, it's not a text file! 54# If there's no new line, it's not a text file!
53nl_end_of_file=add 55nl_end_of_file=add
56nl_max_blank_in_func = 3
57nl_max = 3
54 58
55sp_inside_paren = remove 59sp_inside_paren = remove
56 60
@@ -69,6 +73,7 @@ sp_between_ptr_star = remove
69sp_before_sparen = add 73sp_before_sparen = add
70 74
71sp_inside_fparen = remove 75sp_inside_fparen = remove
76sp_inside_sparen = remove
72 77
73# add space before function call and decl: "foo (x)" 78# add space before function call and decl: "foo (x)"
74sp_func_call_paren = add 79sp_func_call_paren = add
@@ -76,3 +81,15 @@ sp_func_proto_paren = add
76sp_func_proto_paren_empty = add 81sp_func_proto_paren_empty = add
77sp_func_def_paren = add 82sp_func_def_paren = add
78sp_func_def_paren_empty = add 83sp_func_def_paren_empty = add
84
85# We'd want it for "if ( (foo) || (bar) )", but not for "if (m())",
86# so as uncrustify doesn't give exactly what we want => ignore
87sp_paren_paren = ignore
88sp_inside_paren = remove
89sp_bool = force
90
91nl_func_type_name = force
92#nl_branch_else = add
93nl_else_brace = add
94nl_elseif_brace = add
95nl_for_brace = add
diff --git a/src/auditor/taler-auditor-exchange.c b/src/auditor/taler-auditor-exchange.c
index 0020a5b07..e97fd64df 100644
--- a/src/auditor/taler-auditor-exchange.c
+++ b/src/auditor/taler-auditor-exchange.c
@@ -132,7 +132,7 @@ main (int argc,
132 strlen ("http://"))) && 132 strlen ("http://"))) &&
133 (0 != strncasecmp ("https://", 133 (0 != strncasecmp ("https://",
134 exchange_url, 134 exchange_url,
135 strlen ("https://"))) ) || 135 strlen ("https://"))) ) ||
136 ('/' != exchange_url[strlen (exchange_url) - 1]) ) 136 ('/' != exchange_url[strlen (exchange_url) - 1]) )
137 { 137 {
138 fprintf (stderr, 138 fprintf (stderr,
@@ -211,4 +211,5 @@ main (int argc,
211 return 0; 211 return 0;
212} 212}
213 213
214
214/* end of taler-auditor-exchange.c */ 215/* end of taler-auditor-exchange.c */
diff --git a/src/auditor/taler-auditor-httpd.c b/src/auditor/taler-auditor-httpd.c
index 967a084ef..e37b4a0e8 100644
--- a/src/auditor/taler-auditor-httpd.c
+++ b/src/auditor/taler-auditor-httpd.c
@@ -269,7 +269,6 @@ signal_loop (void)
269} 269}
270 270
271 271
272
273/** 272/**
274 * Function called whenever MHD is done with a request. If the 273 * Function called whenever MHD is done with a request. If the
275 * request was a POST, we may have stored a `struct Buffer *` in the 274 * request was a POST, we may have stored a `struct Buffer *` in the
@@ -980,4 +979,5 @@ main (int argc,
980 return (GNUNET_SYSERR == ret) ? 1 : 0; 979 return (GNUNET_SYSERR == ret) ? 1 : 0;
981} 980}
982 981
982
983/* end of taler-auditor-httpd.c */ 983/* end of taler-auditor-httpd.c */
diff --git a/src/auditor/taler-auditor-httpd_parsing.c b/src/auditor/taler-auditor-httpd_parsing.c
index bac338cc0..fb707c88f 100644
--- a/src/auditor/taler-auditor-httpd_parsing.c
+++ b/src/auditor/taler-auditor-httpd_parsing.c
@@ -36,7 +36,6 @@
36#define REQUEST_BUFFER_MAX (1024 * 1024) 36#define REQUEST_BUFFER_MAX (1024 * 1024)
37 37
38 38
39
40/** 39/**
41 * Process a POST request containing a JSON object. This function 40 * Process a POST request containing a JSON object. This function
42 * realizes an MHD POST processor that will (incrementally) process 41 * realizes an MHD POST processor that will (incrementally) process
diff --git a/src/auditor/taler-auditor-sign.c b/src/auditor/taler-auditor-sign.c
index 2c7fe8293..f35b5de5b 100644
--- a/src/auditor/taler-auditor-sign.c
+++ b/src/auditor/taler-auditor-sign.c
@@ -439,4 +439,5 @@ main (int argc,
439 return 0; 439 return 0;
440} 440}
441 441
442
442/* end of taler-auditor-sign.c */ 443/* end of taler-auditor-sign.c */
diff --git a/src/auditor/taler-auditor.c b/src/auditor/taler-auditor.c
index dbbc6c235..fc9bc870e 100644
--- a/src/auditor/taler-auditor.c
+++ b/src/auditor/taler-auditor.c
@@ -4041,8 +4041,7 @@ refresh_session_cb (void *cls,
4041 accepted a forged coin (i.e. emergency situation after 4041 accepted a forged coin (i.e. emergency situation after
4042 private key compromise). In that case, we cannot even 4042 private key compromise). In that case, we cannot even
4043 subtract the profit we make from the fee from the escrow 4043 subtract the profit we make from the fee from the escrow
4044 balance. Tested as part of test-auditor.sh, case #18 */ 4044 balance. Tested as part of test-auditor.sh, case #18 */report_amount_arithmetic_inconsistency (
4045 report_amount_arithmetic_inconsistency (
4046 "subtracting refresh fee from escrow balance", 4045 "subtracting refresh fee from escrow balance",
4047 rowid, 4046 rowid,
4048 &total_escrow_balance, 4047 &total_escrow_balance,
@@ -4225,8 +4224,7 @@ deposit_cb (void *cls,
4225 accepted a forged coin (i.e. emergency situation after 4224 accepted a forged coin (i.e. emergency situation after
4226 private key compromise). In that case, we cannot even 4225 private key compromise). In that case, we cannot even
4227 subtract the profit we make from the fee from the escrow 4226 subtract the profit we make from the fee from the escrow
4228 balance. Tested as part of test-auditor.sh, case #18 */ 4227 balance. Tested as part of test-auditor.sh, case #18 */report_amount_arithmetic_inconsistency (
4229 report_amount_arithmetic_inconsistency (
4230 "subtracting deposit fee from escrow balance", 4228 "subtracting deposit fee from escrow balance",
4231 rowid, 4229 rowid,
4232 &total_escrow_balance, 4230 &total_escrow_balance,
@@ -5010,7 +5008,6 @@ analyze_deposit_confirmations (void *cls)
5010} 5008}
5011 5009
5012 5010
5013
5014/* *************************** General transaction logic ****************** */ 5011/* *************************** General transaction logic ****************** */
5015 5012
5016/** 5013/**
diff --git a/src/auditor/taler-wire-auditor.c b/src/auditor/taler-wire-auditor.c
index a945f9df2..276f3554e 100644
--- a/src/auditor/taler-wire-auditor.c
+++ b/src/auditor/taler-wire-auditor.c
@@ -624,7 +624,6 @@ report (json_t *array,
624} 624}
625 625
626 626
627
628/** 627/**
629 * Detect any entries in #reserve_closures that were not yet 628 * Detect any entries in #reserve_closures that were not yet
630 * observed on the wire transfer side and update the progress 629 * observed on the wire transfer side and update the progress
diff --git a/src/auditordb/auditordb_plugin.c b/src/auditordb/auditordb_plugin.c
index 51ae77c16..ffd96b495 100644
--- a/src/auditordb/auditordb_plugin.c
+++ b/src/auditordb/auditordb_plugin.c
@@ -84,5 +84,4 @@ TALER_AUDITORDB_plugin_unload (struct TALER_AUDITORDB_Plugin *plugin)
84} 84}
85 85
86 86
87
88/* end of auditordb_plugin.c */ 87/* end of auditordb_plugin.c */
diff --git a/src/auditordb/plugin_auditordb_postgres.c b/src/auditordb/plugin_auditordb_postgres.c
index e5445f2ad..c5559131f 100644
--- a/src/auditordb/plugin_auditordb_postgres.c
+++ b/src/auditordb/plugin_auditordb_postgres.c
@@ -206,8 +206,7 @@ postgres_create_tables (void *cls)
206 serial ID from the respective tables that we have 206 serial ID from the respective tables that we have
207 processed. Thus, we need to select those table entries that are 207 processed. Thus, we need to select those table entries that are
208 strictly larger (and process in monotonically increasing 208 strictly larger (and process in monotonically increasing
209 order). */ 209 order). */GNUNET_PQ_make_execute (
210 GNUNET_PQ_make_execute (
211 "CREATE TABLE IF NOT EXISTS auditor_progress_reserve" 210 "CREATE TABLE IF NOT EXISTS auditor_progress_reserve"
212 "(master_pub BYTEA CONSTRAINT master_pub_ref REFERENCES auditor_exchanges(master_pub) ON DELETE CASCADE" 211 "(master_pub BYTEA CONSTRAINT master_pub_ref REFERENCES auditor_exchanges(master_pub) ON DELETE CASCADE"
213 ",last_reserve_in_serial_id INT8 NOT NULL DEFAULT 0" 212 ",last_reserve_in_serial_id INT8 NOT NULL DEFAULT 0"
@@ -253,8 +252,7 @@ postgres_create_tables (void *cls)
253 "last_reserve_out_serial_id" marks the last withdrawal from 252 "last_reserve_out_serial_id" marks the last withdrawal from
254 "reserves_out" about this reserve that the auditor is aware of, 253 "reserves_out" about this reserve that the auditor is aware of,
255 and "last_reserve_in_serial_id" is the last "reserve_in" 254 and "last_reserve_in_serial_id" is the last "reserve_in"
256 operation about this reserve that the auditor is aware of. */ 255 operation about this reserve that the auditor is aware of. */GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS auditor_reserves"
257 GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS auditor_reserves"
258 "(reserve_pub BYTEA NOT NULL CHECK(LENGTH(reserve_pub)=32)" 256 "(reserve_pub BYTEA NOT NULL CHECK(LENGTH(reserve_pub)=32)"
259 ",master_pub BYTEA CONSTRAINT master_pub_ref REFERENCES auditor_exchanges(master_pub) ON DELETE CASCADE" 257 ",master_pub BYTEA CONSTRAINT master_pub_ref REFERENCES auditor_exchanges(master_pub) ON DELETE CASCADE"
260 ",reserve_balance_val INT8 NOT NULL" 258 ",reserve_balance_val INT8 NOT NULL"
@@ -289,8 +287,7 @@ postgres_create_tables (void *cls)
289 (outstanding as well as issued overall which implies the 287 (outstanding as well as issued overall which implies the
290 maximum value at risk). We also count the number of coins 288 maximum value at risk). We also count the number of coins
291 issued (withdraw, refresh-reveal) and the number of coins seen 289 issued (withdraw, refresh-reveal) and the number of coins seen
292 at the exchange (refresh-commit, deposit), not just the amounts. */ 290 at the exchange (refresh-commit, deposit), not just the amounts. */GNUNET_PQ_make_execute (
293 GNUNET_PQ_make_execute (
294 "CREATE TABLE IF NOT EXISTS auditor_denomination_pending" 291 "CREATE TABLE IF NOT EXISTS auditor_denomination_pending"
295 "(denom_pub_hash BYTEA PRIMARY KEY" 292 "(denom_pub_hash BYTEA PRIMARY KEY"
296 " REFERENCES auditor_denominations (denom_pub_hash) ON DELETE CASCADE" 293 " REFERENCES auditor_denominations (denom_pub_hash) ON DELETE CASCADE"
@@ -309,8 +306,7 @@ postgres_create_tables (void *cls)
309 respective's exchange's master public key); it represents the 306 respective's exchange's master public key); it represents the
310 auditor_balance_summary of the exchange at this point (modulo 307 auditor_balance_summary of the exchange at this point (modulo
311 unexpected historic_loss-style events where denomination keys are 308 unexpected historic_loss-style events where denomination keys are
312 compromised) */ 309 compromised) */GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS auditor_balance_summary"
313 GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS auditor_balance_summary"
314 "(master_pub BYTEA CONSTRAINT master_pub_ref REFERENCES auditor_exchanges(master_pub) ON DELETE CASCADE" 310 "(master_pub BYTEA CONSTRAINT master_pub_ref REFERENCES auditor_exchanges(master_pub) ON DELETE CASCADE"
315 ",denom_balance_val INT8 NOT NULL" 311 ",denom_balance_val INT8 NOT NULL"
316 ",denom_balance_frac INT4 NOT NULL" 312 ",denom_balance_frac INT4 NOT NULL"
@@ -333,8 +329,7 @@ postgres_create_tables (void *cls)
333 coin except for withdraw fees (which are in 329 coin except for withdraw fees (which are in
334 historic_reserve_revenue); the deposit, melt and refund fees are given 330 historic_reserve_revenue); the deposit, melt and refund fees are given
335 individually; the delta to the revenue_balance is from coins that 331 individually; the delta to the revenue_balance is from coins that
336 were withdrawn but never deposited prior to expiration. */ 332 were withdrawn but never deposited prior to expiration. */GNUNET_PQ_make_execute (
337 GNUNET_PQ_make_execute (
338 "CREATE TABLE IF NOT EXISTS auditor_historic_denomination_revenue" 333 "CREATE TABLE IF NOT EXISTS auditor_historic_denomination_revenue"
339 "(master_pub BYTEA CONSTRAINT master_pub_ref REFERENCES auditor_exchanges(master_pub) ON DELETE CASCADE" 334 "(master_pub BYTEA CONSTRAINT master_pub_ref REFERENCES auditor_exchanges(master_pub) ON DELETE CASCADE"
340 ",denom_pub_hash BYTEA PRIMARY KEY CHECK (LENGTH(denom_pub_hash)=64)" 335 ",denom_pub_hash BYTEA PRIMARY KEY CHECK (LENGTH(denom_pub_hash)=64)"
@@ -389,8 +384,7 @@ postgres_create_tables (void *cls)
389 the tables overall, we'll need a command-line tool to insert rows 384 the tables overall, we'll need a command-line tool to insert rows
390 into this table and update "auditor_predicted_result" accordingly. 385 into this table and update "auditor_predicted_result" accordingly.
391 (So this table for now just exists as a reminder of what we'll 386 (So this table for now just exists as a reminder of what we'll
392 need in the long term.) */ 387 need in the long term.) */GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS auditor_historic_ledger"
393 GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS auditor_historic_ledger"
394 "(master_pub BYTEA CONSTRAINT master_pub_ref REFERENCES auditor_exchanges(master_pub) ON DELETE CASCADE" 388 "(master_pub BYTEA CONSTRAINT master_pub_ref REFERENCES auditor_exchanges(master_pub) ON DELETE CASCADE"
395 ",purpose VARCHAR NOT NULL" 389 ",purpose VARCHAR NOT NULL"
396 ",timestamp INT8 NOT NULL" 390 ",timestamp INT8 NOT NULL"
@@ -1502,7 +1496,6 @@ postgres_get_deposit_confirmations (void *cls,
1502} 1496}
1503 1497
1504 1498
1505
1506/** 1499/**
1507 * Insert information about a denomination key and in particular 1500 * Insert information about a denomination key and in particular
1508 * the properties (value, fees, expiration times) the coins signed 1501 * the properties (value, fees, expiration times) the coins signed
@@ -3586,4 +3579,5 @@ libtaler_plugin_auditordb_postgres_done (void *cls)
3586 return NULL; 3579 return NULL;
3587} 3580}
3588 3581
3582
3589/* end of plugin_auditordb_postgres.c */ 3583/* end of plugin_auditordb_postgres.c */
diff --git a/src/auditordb/test_auditordb.c b/src/auditordb/test_auditordb.c
index 3968f0218..9b97d47bd 100644
--- a/src/auditordb/test_auditordb.c
+++ b/src/auditordb/test_auditordb.c
@@ -581,6 +581,7 @@ run (void *cls)
581 return GNUNET_OK; 581 return GNUNET_OK;
582 } 582 }
583 583
584
584 FAILIF (0 >= 585 FAILIF (0 >=
585 plugin->select_historic_denom_revenue (plugin->cls, 586 plugin->select_historic_denom_revenue (plugin->cls,
586 session, 587 session,
@@ -644,6 +645,7 @@ run (void *cls)
644 return GNUNET_OK; 645 return GNUNET_OK;
645 } 646 }
646 647
648
647 FAILIF (0 >= 649 FAILIF (0 >=
648 plugin->select_historic_reserve_revenue (plugin->cls, 650 plugin->select_historic_reserve_revenue (plugin->cls,
649 session, 651 session,
diff --git a/src/bank-lib/bank_api_history.c b/src/bank-lib/bank_api_history.c
index a29598a30..fcb68009f 100644
--- a/src/bank-lib/bank_api_history.c
+++ b/src/bank-lib/bank_api_history.c
@@ -251,7 +251,6 @@ handle_history_finished (void *cls,
251} 251}
252 252
253 253
254
255/** 254/**
256 * Backend of both the /history[-range] requests. 255 * Backend of both the /history[-range] requests.
257 * 256 *
@@ -407,7 +406,6 @@ TALER_BANK_history_range (struct GNUNET_CURL_Context *ctx,
407} 406}
408 407
409 408
410
411/** 409/**
412 * Request the wire transfer history of a bank account. 410 * Request the wire transfer history of a bank account.
413 * 411 *
diff --git a/src/bank-lib/fakebank.c b/src/bank-lib/fakebank.c
index 94e2e8d78..e1a5c9bbb 100644
--- a/src/bank-lib/fakebank.c
+++ b/src/bank-lib/fakebank.c
@@ -713,6 +713,7 @@ handle_history (struct TALER_FAKEBANK_Handle *h,
713 &TFH_handle_history_advance); 713 &TFH_handle_history_advance);
714} 714}
715 715
716
716/** 717/**
717 * Handle incoming HTTP request for /history-range. 718 * Handle incoming HTTP request for /history-range.
718 * 719 *
@@ -897,6 +898,8 @@ schedule_httpd (struct TALER_FAKEBANK_Handle *h)
897 &run_mhd, 898 &run_mhd,
898 h); 899 h);
899} 900}
901
902
900#else 903#else
901/** 904/**
902 * Schedule MHD. This function should be called initially when an 905 * Schedule MHD. This function should be called initially when an
@@ -957,6 +960,8 @@ schedule_httpd (struct TALER_FAKEBANK_Handle *h)
957 if (NULL != wws) 960 if (NULL != wws)
958 GNUNET_NETWORK_fdset_destroy (wws); 961 GNUNET_NETWORK_fdset_destroy (wws);
959} 962}
963
964
960#endif 965#endif
961 966
962 967
diff --git a/src/bank-lib/fakebank.h b/src/bank-lib/fakebank.h
index 321bc1336..cc2359014 100644
--- a/src/bank-lib/fakebank.h
+++ b/src/bank-lib/fakebank.h
@@ -188,7 +188,6 @@ struct HistoryArgs
188}; 188};
189 189
190 190
191
192/** 191/**
193 * Type for a function that decides whether or not 192 * Type for a function that decides whether or not
194 * the history-building loop should iterate once again. 193 * the history-building loop should iterate once again.
diff --git a/src/bank-lib/fakebank_history.c b/src/bank-lib/fakebank_history.c
index 2ad363b49..170574522 100644
--- a/src/bank-lib/fakebank_history.c
+++ b/src/bank-lib/fakebank_history.c
@@ -299,6 +299,7 @@ TFH_build_history_response (struct MHD_Connection *connection,
299 return ret; 299 return ret;
300} 300}
301 301
302
302/** 303/**
303 * Parse URL history arguments, of _both_ APIs: 304 * Parse URL history arguments, of _both_ APIs:
304 * /history and /history-range. 305 * /history and /history-range.
diff --git a/src/bank-lib/taler-bank-transfer.c b/src/bank-lib/taler-bank-transfer.c
index 1d6e2e9e6..625545b6b 100644
--- a/src/bank-lib/taler-bank-transfer.c
+++ b/src/bank-lib/taler-bank-transfer.c
@@ -270,4 +270,5 @@ main (int argc, char *const *argv)
270 return global_ret; 270 return global_ret;
271} 271}
272 272
273
273/* end taler-bank-transfer.c */ 274/* end taler-bank-transfer.c */
diff --git a/src/bank-lib/test_bank_api.c b/src/bank-lib/test_bank_api.c
index 6ad47c825..0a34e4b48 100644
--- a/src/bank-lib/test_bank_api.c
+++ b/src/bank-lib/test_bank_api.c
@@ -226,4 +226,5 @@ main (int argc,
226 return (GNUNET_OK == result) ? 0 : 1; 226 return (GNUNET_OK == result) ? 0 : 1;
227} 227}
228 228
229
229/* end of test_bank_api.c */ 230/* end of test_bank_api.c */
diff --git a/src/bank-lib/test_bank_api_new.c b/src/bank-lib/test_bank_api_new.c
index 31602a1ee..ce99904f3 100644
--- a/src/bank-lib/test_bank_api_new.c
+++ b/src/bank-lib/test_bank_api_new.c
@@ -178,6 +178,7 @@ run (void *cls,
178 commands); 178 commands);
179} 179}
180 180
181
181int 182int
182main (int argc, 183main (int argc,
183 char *const *argv) 184 char *const *argv)
diff --git a/src/bank-lib/test_bank_api_twisted.c b/src/bank-lib/test_bank_api_twisted.c
index 49ce94164..293bef30f 100644
--- a/src/bank-lib/test_bank_api_twisted.c
+++ b/src/bank-lib/test_bank_api_twisted.c
@@ -215,4 +215,5 @@ main (int argc,
215 return 1; 215 return 1;
216} 216}
217 217
218
218/* end of test_bank_api_twisted.c */ 219/* end of test_bank_api_twisted.c */
diff --git a/src/bank-lib/test_bank_api_with_fakebank.c b/src/bank-lib/test_bank_api_with_fakebank.c
index 331968120..c69a0e243 100644
--- a/src/bank-lib/test_bank_api_with_fakebank.c
+++ b/src/bank-lib/test_bank_api_with_fakebank.c
@@ -171,4 +171,5 @@ main (int argc,
171 return (GNUNET_OK == result) ? 0 : 1; 171 return (GNUNET_OK == result) ? 0 : 1;
172} 172}
173 173
174
174/* end of test_bank_api_with_fakebank.c */ 175/* end of test_bank_api_with_fakebank.c */
diff --git a/src/bank-lib/test_bank_interpreter.c b/src/bank-lib/test_bank_interpreter.c
index 7f30f5050..2512dff52 100644
--- a/src/bank-lib/test_bank_interpreter.c
+++ b/src/bank-lib/test_bank_interpreter.c
@@ -1047,4 +1047,5 @@ TBI_run_interpreter (int *resultp,
1047 GNUNET_SCHEDULER_add_shutdown (&do_shutdown, is); 1047 GNUNET_SCHEDULER_add_shutdown (&do_shutdown, is);
1048} 1048}
1049 1049
1050
1050/* end of test_bank_interpeter.c */ 1051/* end of test_bank_interpeter.c */
diff --git a/src/bank-lib/testing_api_cmd_history.c b/src/bank-lib/testing_api_cmd_history.c
index ca8613141..0b5184ad8 100644
--- a/src/bank-lib/testing_api_cmd_history.c
+++ b/src/bank-lib/testing_api_cmd_history.c
@@ -34,7 +34,6 @@
34#include "taler_fakebank_lib.h" 34#include "taler_fakebank_lib.h"
35 35
36 36
37
38/** 37/**
39 * State for a "history" CMD. 38 * State for a "history" CMD.
40 */ 39 */
@@ -267,7 +266,6 @@ print_expected (struct History *h,
267} 266}
268 267
269 268
270
271/** 269/**
272 * Tell if the current item is beyond the allowed limit. 270 * Tell if the current item is beyond the allowed limit.
273 * 271 *
@@ -338,8 +336,7 @@ build_history (struct TALER_TESTING_Interpreter *is,
338 * @var turns GNUNET_YES whenever either no 'start' value was 336 * @var turns GNUNET_YES whenever either no 'start' value was
339 * given for the history query, or the given value is found 337 * given for the history query, or the given value is found
340 * in the list of all the CMDs. 338 * in the list of all the CMDs.
341 */ 339 */int ok;
342 int ok;
343 const uint64_t *row_id_start = NULL; 340 const uint64_t *row_id_start = NULL;
344 341
345 if (NULL != hs->start_row_reference) 342 if (NULL != hs->start_row_reference)
@@ -399,8 +396,7 @@ build_history (struct TALER_TESTING_Interpreter *is,
399 * The following command allows us to skip over those CMDs 396 * The following command allows us to skip over those CMDs
400 * that do not offer a "row_id" trait. Such skipped CMDs are 397 * that do not offer a "row_id" trait. Such skipped CMDs are
401 * not interesting for building a history. 398 * not interesting for building a history.
402 */ 399 */if (GNUNET_OK != TALER_TESTING_get_trait_uint64 (pos,
403 if (GNUNET_OK != TALER_TESTING_get_trait_uint64 (pos,
404 0, 400 0,
405 &row_id)) 401 &row_id))
406 continue; 402 continue;
@@ -533,8 +529,7 @@ build_history (struct TALER_TESTING_Interpreter *is,
533 * Warning: this zeroing is superfluous, as 529 * Warning: this zeroing is superfluous, as
534 * total doesn't get incremented if 'start' 530 * total doesn't get incremented if 'start'
535 * was given and couldn't be found. 531 * was given and couldn't be found.
536 */ 532 */total = 0;
537 total = 0;
538 ok = GNUNET_YES; 533 ok = GNUNET_YES;
539 continue; 534 continue;
540 } 535 }
@@ -598,8 +593,7 @@ build_history (struct TALER_TESTING_Interpreter *is,
598 * _both_ the credit and the debit roles, but _only if_ 593 * _both_ the credit and the debit roles, but _only if_
599 * the audit goes on both directions.. This needs more 594 * the audit goes on both directions.. This needs more
600 * explaination! 595 * explaination!
601 */ 596 */if ( ( (0 != (hs->direction & TALER_BANK_DIRECTION_CREDIT)) &&
602 if ( ( (0 != (hs->direction & TALER_BANK_DIRECTION_CREDIT)) &&
603 (hs->account_no == *credit_account_no)) && 597 (hs->account_no == *credit_account_no)) &&
604 ( (0 != (hs->direction & TALER_BANK_DIRECTION_DEBIT)) && 598 ( (0 != (hs->direction & TALER_BANK_DIRECTION_DEBIT)) &&
605 (hs->account_no == *debit_account_no)) ) 599 (hs->account_no == *debit_account_no)) )
@@ -775,6 +769,7 @@ check_result (struct TALER_TESTING_Interpreter *is,
775 return GNUNET_OK; 769 return GNUNET_OK;
776} 770}
777 771
772
778/** 773/**
779 * This callback will (1) check that the HTTP response code 774 * This callback will (1) check that the HTTP response code
780 * is acceptable and (2) that the history is consistent. The 775 * is acceptable and (2) that the history is consistent. The
@@ -1191,4 +1186,5 @@ TALER_TESTING_cmd_bank_history_range_with_dates
1191 } 1186 }
1192} 1187}
1193 1188
1189
1194/* end of testing_api_cmd_history.c */ 1190/* end of testing_api_cmd_history.c */
diff --git a/src/bank-lib/testing_api_cmd_reject.c b/src/bank-lib/testing_api_cmd_reject.c
index 8d37266d1..01c189f16 100644
--- a/src/bank-lib/testing_api_cmd_reject.c
+++ b/src/bank-lib/testing_api_cmd_reject.c
@@ -183,6 +183,7 @@ reject_traits (void *cls,
183 index); 183 index);
184} 184}
185 185
186
186/** 187/**
187 * Create a "reject" CMD. 188 * Create a "reject" CMD.
188 * 189 *
diff --git a/src/bank-lib/testing_api_helpers.c b/src/bank-lib/testing_api_helpers.c
index 5d371a1a5..2f5ea36f5 100644
--- a/src/bank-lib/testing_api_helpers.c
+++ b/src/bank-lib/testing_api_helpers.c
@@ -120,6 +120,7 @@ TALER_TESTING_has_in_name (const char *prog_name,
120 return strstr (prog_name + name_pos, marker) != NULL; 120 return strstr (prog_name + name_pos, marker) != NULL;
121} 121}
122 122
123
123/** 124/**
124 * Start the (Python) bank process. Assume the port 125 * Start the (Python) bank process. Assume the port
125 * is available and the database is clean. Use the "prepare 126 * is available and the database is clean. Use the "prepare
diff --git a/src/benchmark/taler-exchange-benchmark.c b/src/benchmark/taler-exchange-benchmark.c
index 87b5167b2..da10762cf 100644
--- a/src/benchmark/taler-exchange-benchmark.c
+++ b/src/benchmark/taler-exchange-benchmark.c
@@ -645,8 +645,8 @@ parallel_benchmark (TALER_TESTING_Main main_cb,
645 if (MODE_EXCHANGE == mode) 645 if (MODE_EXCHANGE == mode)
646 (void) getchar (); 646 (void) getchar ();
647 647
648 if ( (GNUNET_YES == linger) && ( ((mode == MODE_BOTH)|| (mode == 648 if ( (GNUNET_YES == linger) && ( ((mode == MODE_BOTH) || (mode ==
649 MODE_CLIENT) ) ) ) 649 MODE_CLIENT) ) ) )
650 { 650 {
651 printf ("press ENTER to stop\n"); 651 printf ("press ENTER to stop\n");
652 (void) getchar (); 652 (void) getchar ();
diff --git a/src/exchange-tools/taler-exchange-keycheck.c b/src/exchange-tools/taler-exchange-keycheck.c
index ac452a058..e91ab34ff 100644
--- a/src/exchange-tools/taler-exchange-keycheck.c
+++ b/src/exchange-tools/taler-exchange-keycheck.c
@@ -286,4 +286,5 @@ main (int argc, char *const *argv)
286 286
287} 287}
288 288
289
289/* end of taler-exchange-keycheck.c */ 290/* end of taler-exchange-keycheck.c */
diff --git a/src/exchange-tools/taler-exchange-keyup.c b/src/exchange-tools/taler-exchange-keyup.c
index 40dabf14b..8e982d17e 100644
--- a/src/exchange-tools/taler-exchange-keyup.c
+++ b/src/exchange-tools/taler-exchange-keyup.c
@@ -1483,4 +1483,5 @@ main (int argc,
1483 return global_ret; 1483 return global_ret;
1484} 1484}
1485 1485
1486
1486/* end of taler-exchange-keyup.c */ 1487/* end of taler-exchange-keyup.c */
diff --git a/src/exchange-tools/taler-wire.c b/src/exchange-tools/taler-wire.c
index f9c4a3579..4d6e0fcd7 100644
--- a/src/exchange-tools/taler-wire.c
+++ b/src/exchange-tools/taler-wire.c
@@ -446,4 +446,5 @@ main (int argc,
446 return global_ret; 446 return global_ret;
447} 447}
448 448
449
449/* end of taler-wire.c */ 450/* end of taler-wire.c */
diff --git a/src/exchange/taler-exchange-aggregator.c b/src/exchange/taler-exchange-aggregator.c
index fffb652c7..95f56d0df 100644
--- a/src/exchange/taler-exchange-aggregator.c
+++ b/src/exchange/taler-exchange-aggregator.c
@@ -291,7 +291,6 @@ static unsigned int aggregation_limit =
291 TALER_EXCHANGEDB_MATCHING_DEPOSITS_LIMIT; 291 TALER_EXCHANGEDB_MATCHING_DEPOSITS_LIMIT;
292 292
293 293
294
295/** 294/**
296 * Advance the "af" pointer in @a wp to point to the 295 * Advance the "af" pointer in @a wp to point to the
297 * currently valid record. 296 * currently valid record.
@@ -1968,4 +1967,5 @@ main (int argc,
1968 return global_ret; 1967 return global_ret;
1969} 1968}
1970 1969
1970
1971/* end of taler-exchange-aggregator.c */ 1971/* end of taler-exchange-aggregator.c */
diff --git a/src/exchange/taler-exchange-httpd.c b/src/exchange/taler-exchange-httpd.c
index bdb213a87..af38a605a 100644
--- a/src/exchange/taler-exchange-httpd.c
+++ b/src/exchange/taler-exchange-httpd.c
@@ -839,6 +839,7 @@ connection_done (void *cls,
839 "kill"); 839 "kill");
840} 840}
841 841
842
842/* end of HAVE_DEVELOPER */ 843/* end of HAVE_DEVELOPER */
843#endif 844#endif
844 845
@@ -1026,7 +1027,6 @@ write_stats ()
1026} 1027}
1027 1028
1028 1029
1029
1030/** 1030/**
1031 * The main function of the taler-exchange-httpd server ("the exchange"). 1031 * The main function of the taler-exchange-httpd server ("the exchange").
1032 * 1032 *
@@ -1261,4 +1261,5 @@ main (int argc,
1261 return (GNUNET_SYSERR == ret) ? 1 : 0; 1261 return (GNUNET_SYSERR == ret) ? 1 : 0;
1262} 1262}
1263 1263
1264
1264/* end of taler-exchange-httpd.c */ 1265/* end of taler-exchange-httpd.c */
diff --git a/src/exchange/taler-exchange-httpd_keystate.c b/src/exchange/taler-exchange-httpd_keystate.c
index f9cda8a5f..ce6a856d9 100644
--- a/src/exchange/taler-exchange-httpd_keystate.c
+++ b/src/exchange/taler-exchange-httpd_keystate.c
@@ -262,7 +262,6 @@ struct ResponseFactoryContext
262}; 262};
263 263
264 264
265
266/** 265/**
267 * Snapshot of the (coin and signing) keys (including private keys) of 266 * Snapshot of the (coin and signing) keys (including private keys) of
268 * the exchange. There can be multiple instances of this struct, as it is 267 * the exchange. There can be multiple instances of this struct, as it is
@@ -327,7 +326,6 @@ struct TEH_KS_StateHandle
327}; 326};
328 327
329 328
330
331/** 329/**
332 * Exchange key state. This is the long-term, read-only internal global state, 330 * Exchange key state. This is the long-term, read-only internal global state,
333 * which the various threads "lock" to use in read-only ways. We eventually 331 * which the various threads "lock" to use in read-only ways. We eventually
@@ -346,7 +344,6 @@ static struct TEH_KS_StateHandle *internal_key_state;
346static pthread_mutex_t internal_key_state_mutex = PTHREAD_MUTEX_INITIALIZER; 344static pthread_mutex_t internal_key_state_mutex = PTHREAD_MUTEX_INITIALIZER;
347 345
348 346
349
350/* ************************** Clean up logic *********************** */ 347/* ************************** Clean up logic *********************** */
351 348
352 349
diff --git a/src/exchange/taler-exchange-httpd_parsing.c b/src/exchange/taler-exchange-httpd_parsing.c
index dc77d1822..fb8932b9a 100644
--- a/src/exchange/taler-exchange-httpd_parsing.c
+++ b/src/exchange/taler-exchange-httpd_parsing.c
@@ -36,7 +36,6 @@
36#define REQUEST_BUFFER_MAX (1024 * 1024) 36#define REQUEST_BUFFER_MAX (1024 * 1024)
37 37
38 38
39
40/** 39/**
41 * Process a POST request containing a JSON object. This function 40 * Process a POST request containing a JSON object. This function
42 * realizes an MHD POST processor that will (incrementally) process 41 * realizes an MHD POST processor that will (incrementally) process
diff --git a/src/exchange/taler-exchange-httpd_responses.c b/src/exchange/taler-exchange-httpd_responses.c
index 1c2f92f0e..2e1835845 100644
--- a/src/exchange/taler-exchange-httpd_responses.c
+++ b/src/exchange/taler-exchange-httpd_responses.c
@@ -698,8 +698,7 @@ TEH_RESPONSE_compile_transaction_history (const struct
698 the denomination key's RSA signature over coin_pub, but as the 698 the denomination key's RSA signature over coin_pub, but as the
699 wallet should really already have this information (and cannot 699 wallet should really already have this information (and cannot
700 check or do anything with it anyway if it doesn't), it seems 700 check or do anything with it anyway if it doesn't), it seems
701 strictly unnecessary. */ 701 strictly unnecessary. */if (0 !=
702 if (0 !=
703 json_array_append_new (history, 702 json_array_append_new (history,
704 json_pack ("{s:s, s:o, s:o, s:o, s:o, s:o}", 703 json_pack ("{s:s, s:o, s:o, s:o, s:o, s:o}",
705 "type", "OLD-COIN-PAYBACK", 704 "type", "OLD-COIN-PAYBACK",
@@ -801,8 +800,7 @@ TEH_RESPONSE_compile_transaction_history (const struct
801 hash and the denomination key's RSA signature over coin_pub, but as 800 hash and the denomination key's RSA signature over coin_pub, but as
802 the wallet should really already have this information (and cannot 801 the wallet should really already have this information (and cannot
803 check or do anything with it anyway if it doesn't), it seems 802 check or do anything with it anyway if it doesn't), it seems
804 strictly unnecessary. */ 803 strictly unnecessary. */if (0 !=
805 if (0 !=
806 json_array_append_new (history, 804 json_array_append_new (history,
807 json_pack ("{s:s, s:o, s:o, s:o, s:o, s:o}", 805 json_pack ("{s:s, s:o, s:o, s:o, s:o, s:o}",
808 "type", "PAYBACK-REFRESH", 806 "type", "PAYBACK-REFRESH",
@@ -1172,4 +1170,5 @@ TEH_RESPONSE_reply_transaction_unknown (struct MHD_Connection *connection,
1172 "code", (json_int_t) ec); 1170 "code", (json_int_t) ec);
1173} 1171}
1174 1172
1173
1175/* end of taler-exchange-httpd_responses.c */ 1174/* end of taler-exchange-httpd_responses.c */
diff --git a/src/exchange/taler-exchange-httpd_wire.c b/src/exchange/taler-exchange-httpd_wire.c
index 797ed8bed..1bc4a8279 100644
--- a/src/exchange/taler-exchange-httpd_wire.c
+++ b/src/exchange/taler-exchange-httpd_wire.c
@@ -176,5 +176,4 @@ TEH_wire_cleanup ()
176} 176}
177 177
178 178
179
180/* end of taler-exchange-httpd_wire.c */ 179/* end of taler-exchange-httpd_wire.c */
diff --git a/src/exchange/taler-exchange-wirewatch.c b/src/exchange/taler-exchange-wirewatch.c
index ea737b7b5..83d90c6e2 100644
--- a/src/exchange/taler-exchange-wirewatch.c
+++ b/src/exchange/taler-exchange-wirewatch.c
@@ -735,4 +735,5 @@ main (int argc,
735 return global_ret; 735 return global_ret;
736} 736}
737 737
738
738/* end of taler-exchange-wirewatch.c */ 739/* end of taler-exchange-wirewatch.c */
diff --git a/src/exchange/test_taler_exchange_aggregator.c b/src/exchange/test_taler_exchange_aggregator.c
index 274a28ac7..9a187add5 100644
--- a/src/exchange/test_taler_exchange_aggregator.c
+++ b/src/exchange/test_taler_exchange_aggregator.c
@@ -28,7 +28,6 @@
28#include "taler_fakebank_lib.h" 28#include "taler_fakebank_lib.h"
29 29
30 30
31
32/** 31/**
33 * Commands for the interpreter. 32 * Commands for the interpreter.
34 */ 33 */
@@ -351,6 +350,7 @@ maint_child_death (void *cls)
351 interpreter (state); 350 interpreter (state);
352} 351}
353 352
353
354/** 354/**
355 * Setup (fake) information about a coin used in deposit. 355 * Setup (fake) information about a coin used in deposit.
356 * 356 *
@@ -1333,4 +1333,5 @@ main (int argc,
1333 return result; 1333 return result;
1334} 1334}
1335 1335
1336
1336/* end of test_taler_exchange_aggregator.c */ 1337/* end of test_taler_exchange_aggregator.c */
diff --git a/src/exchange/test_taler_exchange_wirewatch.c b/src/exchange/test_taler_exchange_wirewatch.c
index 27b98bb06..da2da615a 100644
--- a/src/exchange/test_taler_exchange_wirewatch.c
+++ b/src/exchange/test_taler_exchange_wirewatch.c
@@ -857,4 +857,5 @@ main (int argc,
857 return result; 857 return result;
858} 858}
859 859
860
860/* end of test_taler_exchange_wirewatch.c */ 861/* end of test_taler_exchange_wirewatch.c */
diff --git a/src/exchangedb/exchangedb_accounts.c b/src/exchangedb/exchangedb_accounts.c
index f336b53a4..e31509021 100644
--- a/src/exchangedb/exchangedb_accounts.c
+++ b/src/exchangedb/exchangedb_accounts.c
@@ -139,4 +139,5 @@ TALER_EXCHANGEDB_find_accounts (const struct GNUNET_CONFIGURATION_Handle *cfg,
139 &ctx); 139 &ctx);
140} 140}
141 141
142
142/* end of exchangedb_accounts.c */ 143/* end of exchangedb_accounts.c */
diff --git a/src/exchangedb/exchangedb_plugin.c b/src/exchangedb/exchangedb_plugin.c
index 50394c6e3..8e61f860b 100644
--- a/src/exchangedb/exchangedb_plugin.c
+++ b/src/exchangedb/exchangedb_plugin.c
@@ -83,5 +83,4 @@ TALER_EXCHANGEDB_plugin_unload (struct TALER_EXCHANGEDB_Plugin *plugin)
83} 83}
84 84
85 85
86
87/* end of exchangedb_plugin.c */ 86/* end of exchangedb_plugin.c */
diff --git a/src/exchangedb/exchangedb_signkeys.c b/src/exchangedb/exchangedb_signkeys.c
index 0c46c1ff1..c58423c52 100644
--- a/src/exchangedb/exchangedb_signkeys.c
+++ b/src/exchangedb/exchangedb_signkeys.c
@@ -194,4 +194,5 @@ TALER_EXCHANGEDB_signing_key_write (const char *exchange_base_dir,
194 return GNUNET_OK; 194 return GNUNET_OK;
195} 195}
196 196
197
197/* end of exchangedb_signkeys.c */ 198/* end of exchangedb_signkeys.c */
diff --git a/src/exchangedb/plugin_exchangedb_postgres.c b/src/exchangedb/plugin_exchangedb_postgres.c
index 1dd408752..6ddbead9e 100644
--- a/src/exchangedb/plugin_exchangedb_postgres.c
+++ b/src/exchangedb/plugin_exchangedb_postgres.c
@@ -230,8 +230,7 @@ postgres_create_tables (void *cls)
230 funds are added and existing funds are withdrawn. The 'expiration_date' 230 funds are added and existing funds are withdrawn. The 'expiration_date'
231 can be used to eventually get rid of reserves that have not been used 231 can be used to eventually get rid of reserves that have not been used
232 for a very long time (either by refunding the owner or by greedily 232 for a very long time (either by refunding the owner or by greedily
233 grabbing the money, depending on the Exchange's terms of service) */ 233 grabbing the money, depending on the Exchange's terms of service) */GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS reserves"
234 GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS reserves"
235 "(reserve_pub BYTEA PRIMARY KEY CHECK(LENGTH(reserve_pub)=32)" 234 "(reserve_pub BYTEA PRIMARY KEY CHECK(LENGTH(reserve_pub)=32)"
236 ",account_details TEXT NOT NULL " 235 ",account_details TEXT NOT NULL "
237 ",current_balance_val INT8 NOT NULL" 236 ",current_balance_val INT8 NOT NULL"
@@ -292,8 +291,7 @@ postgres_create_tables (void *cls)
292 The 'h_blind_ev' is the hash of the blinded coin. It serves as a primary 291 The 'h_blind_ev' is the hash of the blinded coin. It serves as a primary
293 key, as (broken) clients that use a non-random coin and blinding factor 292 key, as (broken) clients that use a non-random coin and blinding factor
294 should fail to even withdraw, as otherwise the coins will fail to deposit 293 should fail to even withdraw, as otherwise the coins will fail to deposit
295 (as they really must be unique). */ 294 (as they really must be unique). */GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS reserves_out"
296 GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS reserves_out"
297 "(reserve_out_serial_id BIGSERIAL UNIQUE" 295 "(reserve_out_serial_id BIGSERIAL UNIQUE"
298 ",h_blind_ev BYTEA PRIMARY KEY CHECK (LENGTH(h_blind_ev)=64)" 296 ",h_blind_ev BYTEA PRIMARY KEY CHECK (LENGTH(h_blind_ev)=64)"
299 ",denom_pub_hash BYTEA NOT NULL REFERENCES denominations (denom_pub_hash)" /* do NOT CASCADE on DELETE, we may keep the denomination key alive! */ 297 ",denom_pub_hash BYTEA NOT NULL REFERENCES denominations (denom_pub_hash)" /* do NOT CASCADE on DELETE, we may keep the denomination key alive! */
@@ -341,8 +339,7 @@ postgres_create_tables (void *cls)
341 index and the index of the new coin, and the envelope of the new 339 index and the index of the new coin, and the envelope of the new
342 coin to be signed, as well as the encrypted information about the 340 coin to be signed, as well as the encrypted information about the
343 private key and the blinding factor for the coin (for verification 341 private key and the blinding factor for the coin (for verification
344 in case this newcoin_index is chosen to be revealed) */ 342 in case this newcoin_index is chosen to be revealed) */GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS refresh_revealed_coins "
345 GNUNET_PQ_make_execute ("CREATE TABLE IF NOT EXISTS refresh_revealed_coins "
346 "(rc BYTEA NOT NULL REFERENCES refresh_commitments (rc) ON DELETE CASCADE" 343 "(rc BYTEA NOT NULL REFERENCES refresh_commitments (rc) ON DELETE CASCADE"
347 ",newcoin_index INT4 NOT NULL" 344 ",newcoin_index INT4 NOT NULL"
348 ",link_sig BYTEA NOT NULL CHECK(LENGTH(link_sig)=64)" 345 ",link_sig BYTEA NOT NULL CHECK(LENGTH(link_sig)=64)"
@@ -797,8 +794,7 @@ postgres_get_session (void *cls)
797 the coin's denomination information (public key, signature) 794 the coin's denomination information (public key, signature)
798 and the blinded message as well as the reserve that the coin 795 and the blinded message as well as the reserve that the coin
799 is being withdrawn from and the signature of the message 796 is being withdrawn from and the signature of the message
800 authorizing the withdrawal. */ 797 authorizing the withdrawal. */GNUNET_PQ_make_prepare ("insert_withdraw_info",
801 GNUNET_PQ_make_prepare ("insert_withdraw_info",
802 "INSERT INTO reserves_out " 798 "INSERT INTO reserves_out "
803 "(h_blind_ev" 799 "(h_blind_ev"
804 ",denom_pub_hash" 800 ",denom_pub_hash"
@@ -2207,8 +2203,7 @@ postgres_reserves_in_insert (void *cls,
2207 Note that for a non-drained reserve we should not switch, 2203 Note that for a non-drained reserve we should not switch,
2208 as that opens an attack vector for an adversary who can see 2204 as that opens an attack vector for an adversary who can see
2209 the wire transfer subjects (i.e. when using Bitcoin). 2205 the wire transfer subjects (i.e. when using Bitcoin).
2210 */ 2206 */}
2211 }
2212 2207
2213 GNUNET_log (GNUNET_ERROR_TYPE_INFO, 2208 GNUNET_log (GNUNET_ERROR_TYPE_INFO,
2214 "Creating reserve %s with expiration in %s\n", 2209 "Creating reserve %s with expiration in %s\n",
@@ -2225,8 +2220,7 @@ postgres_reserves_in_insert (void *cls,
2225 before adding the actual transaction to "reserves_in", as 2220 before adding the actual transaction to "reserves_in", as
2226 for a new reserve it can't be a duplicate 'add' operation, 2221 for a new reserve it can't be a duplicate 'add' operation,
2227 and as the 'add' operation may need the reserve entry 2222 and as the 'add' operation may need the reserve entry
2228 as a foreign key. */ 2223 as a foreign key. */struct GNUNET_PQ_QueryParam params[] = {
2229 struct GNUNET_PQ_QueryParam params[] = {
2230 GNUNET_PQ_query_param_auto_from_type (reserve_pub), 2224 GNUNET_PQ_query_param_auto_from_type (reserve_pub),
2231 GNUNET_PQ_query_param_string (sender_account_details), 2225 GNUNET_PQ_query_param_string (sender_account_details),
2232 TALER_PQ_query_param_amount (balance), 2226 TALER_PQ_query_param_amount (balance),
@@ -2283,8 +2277,7 @@ postgres_reserves_in_insert (void *cls,
2283 balance; we do this after checking for duplication, as 2277 balance; we do this after checking for duplication, as
2284 otherwise we might have to actually pay the cost to roll this 2278 otherwise we might have to actually pay the cost to roll this
2285 back for duplicate transactions; like this, we should virtually 2279 back for duplicate transactions; like this, we should virtually
2286 never actually have to rollback anything. */ 2280 never actually have to rollback anything. */struct TALER_EXCHANGEDB_Reserve updated_reserve;
2287 struct TALER_EXCHANGEDB_Reserve updated_reserve;
2288 2281
2289 updated_reserve.pub = reserve.pub; 2282 updated_reserve.pub = reserve.pub;
2290 if (GNUNET_OK != 2283 if (GNUNET_OK !=
@@ -5711,8 +5704,7 @@ postgres_gc (void *cls)
5711 payback and reserves_out tables to known_coins; these 5704 payback and reserves_out tables to known_coins; these
5712 are NOT using 'ON DROP CASCADE' and might keep denomination 5705 are NOT using 'ON DROP CASCADE' and might keep denomination
5713 keys alive for a bit longer, thus causing this statement 5706 keys alive for a bit longer, thus causing this statement
5714 to fail. */ 5707 to fail. */(void) GNUNET_PQ_eval_prepared_non_select (conn,
5715 (void) GNUNET_PQ_eval_prepared_non_select (conn,
5716 "gc_denominations", 5708 "gc_denominations",
5717 params_time); 5709 params_time);
5718 GNUNET_PQ_disconnect (conn); 5710 GNUNET_PQ_disconnect (conn);
@@ -7717,4 +7709,5 @@ libtaler_plugin_exchangedb_postgres_done (void *cls)
7717 return NULL; 7709 return NULL;
7718} 7710}
7719 7711
7712
7720/* end of plugin_exchangedb_postgres.c */ 7713/* end of plugin_exchangedb_postgres.c */
diff --git a/src/exchangedb/test_exchangedb.c b/src/exchangedb/test_exchangedb.c
index b093df4be..a1e20e83a 100644
--- a/src/exchangedb/test_exchangedb.c
+++ b/src/exchangedb/test_exchangedb.c
@@ -292,6 +292,7 @@ create_denom_key_pair (unsigned int size,
292 return dkp; 292 return dkp;
293} 293}
294 294
295
295static struct TALER_Amount value; 296static struct TALER_Amount value;
296static struct TALER_Amount fee_withdraw; 297static struct TALER_Amount fee_withdraw;
297static struct TALER_Amount fee_deposit; 298static struct TALER_Amount fee_deposit;
@@ -2257,4 +2258,5 @@ main (int argc,
2257 return result; 2258 return result;
2258} 2259}
2259 2260
2261
2260/* end of test_exchangedb.c */ 2262/* end of test_exchangedb.c */
diff --git a/src/exchangedb/test_exchangedb_auditors.c b/src/exchangedb/test_exchangedb_auditors.c
index e0af3f157..9f1b2d679 100644
--- a/src/exchangedb/test_exchangedb_auditors.c
+++ b/src/exchangedb/test_exchangedb_auditors.c
@@ -42,7 +42,6 @@ static struct TALER_MasterPublicKeyP want_mpub;
42static struct TALER_DenominationKeyValidityPS want_dki; 42static struct TALER_DenominationKeyValidityPS want_dki;
43 43
44 44
45
46/** 45/**
47 * @brief Function called with auditor information. 46 * @brief Function called with auditor information.
48 * 47 *
diff --git a/src/include/taler_auditordb_plugin.h b/src/include/taler_auditordb_plugin.h
index 6241d8196..03a1c6d47 100644
--- a/src/include/taler_auditordb_plugin.h
+++ b/src/include/taler_auditordb_plugin.h
@@ -1462,7 +1462,6 @@ struct TALER_AUDITORDB_Plugin
1462 void *cb_cls); 1462 void *cb_cls);
1463 1463
1464 1464
1465
1466 /** 1465 /**
1467 * Insert information about the predicted exchange's bank 1466 * Insert information about the predicted exchange's bank
1468 * account balance. 1467 * account balance.
diff --git a/src/include/taler_crypto_lib.h b/src/include/taler_crypto_lib.h
index 5eb4fbf45..81ea0bb95 100644
--- a/src/include/taler_crypto_lib.h
+++ b/src/include/taler_crypto_lib.h
@@ -237,7 +237,6 @@ struct TALER_MasterSignatureP
237}; 237};
238 238
239 239
240
241/** 240/**
242 * @brief Type of public keys for Taler coins. The same key material is used 241 * @brief Type of public keys for Taler coins. The same key material is used
243 * for EdDSA and ECDHE operations. 242 * for EdDSA and ECDHE operations.
diff --git a/src/include/taler_curl_lib.h b/src/include/taler_curl_lib.h
index 6629704fb..52aa3d803 100644
--- a/src/include/taler_curl_lib.h
+++ b/src/include/taler_curl_lib.h
@@ -74,5 +74,4 @@ void
74TALER_curl_easy_post_finished (struct TEAH_PostContext *ctx); 74TALER_curl_easy_post_finished (struct TEAH_PostContext *ctx);
75 75
76 76
77
78#endif 77#endif
diff --git a/src/include/taler_exchange_service.h b/src/include/taler_exchange_service.h
index 0aeffd324..eb1452561 100644
--- a/src/include/taler_exchange_service.h
+++ b/src/include/taler_exchange_service.h
@@ -1681,7 +1681,6 @@ TALER_EXCHANGE_track_transaction_cancel (struct
1681 dwh); 1681 dwh);
1682 1682
1683 1683
1684
1685/** 1684/**
1686 * Convenience function. Verifies a coin's transaction history as 1685 * Convenience function. Verifies a coin's transaction history as
1687 * returned by the exchange. 1686 * returned by the exchange.
@@ -1777,5 +1776,4 @@ void
1777TALER_EXCHANGE_payback_cancel (struct TALER_EXCHANGE_PaybackHandle *ph); 1776TALER_EXCHANGE_payback_cancel (struct TALER_EXCHANGE_PaybackHandle *ph);
1778 1777
1779 1778
1780
1781#endif /* _TALER_EXCHANGE_SERVICE_H */ 1779#endif /* _TALER_EXCHANGE_SERVICE_H */
diff --git a/src/include/taler_exchangedb_plugin.h b/src/include/taler_exchangedb_plugin.h
index 90643d62e..0dcf4b841 100644
--- a/src/include/taler_exchangedb_plugin.h
+++ b/src/include/taler_exchangedb_plugin.h
@@ -2173,7 +2173,6 @@ struct TALER_EXCHANGEDB_Plugin
2173 struct TALER_EXCHANGEDB_Session *session); 2173 struct TALER_EXCHANGEDB_Session *session);
2174 2174
2175 2175
2176
2177 /** 2176 /**
2178 * Store information about an outgoing wire transfer that was executed. 2177 * Store information about an outgoing wire transfer that was executed.
2179 * 2178 *
diff --git a/src/include/taler_fakebank_lib.h b/src/include/taler_fakebank_lib.h
index 5e0d7d1d1..f3f92534d 100644
--- a/src/include/taler_fakebank_lib.h
+++ b/src/include/taler_fakebank_lib.h
@@ -81,7 +81,6 @@ TALER_FAKEBANK_make_transfer (struct TALER_FAKEBANK_Handle *h,
81 const char *exchange_base_url); 81 const char *exchange_base_url);
82 82
83 83
84
85/** 84/**
86 * Check that the @a want_amount was transferred from the @a 85 * Check that the @a want_amount was transferred from the @a
87 * want_debit to the @a want_credit account. If so, set the @a subject 86 * want_debit to the @a want_credit account. If so, set the @a subject
diff --git a/src/include/taler_signatures.h b/src/include/taler_signatures.h
index bc0ae214e..9fa98d8c0 100644
--- a/src/include/taler_signatures.h
+++ b/src/include/taler_signatures.h
@@ -956,7 +956,6 @@ struct TALER_MasterWireDetailsPS
956}; 956};
957 957
958 958
959
960/** 959/**
961 * @brief Information signed by the exchange's master 960 * @brief Information signed by the exchange's master
962 * key stating the wire fee to be paid per wire transfer. 961 * key stating the wire fee to be paid per wire transfer.
diff --git a/src/include/taler_testing_bank_lib.h b/src/include/taler_testing_bank_lib.h
index 57a7c0f9b..27db9d599 100644
--- a/src/include/taler_testing_bank_lib.h
+++ b/src/include/taler_testing_bank_lib.h
@@ -199,4 +199,5 @@ struct TALER_TESTING_Command
199TALER_TESTING_cmd_bank_reject (const char *label, 199TALER_TESTING_cmd_bank_reject (const char *label,
200 const char *bank_url, 200 const char *bank_url,
201 const char *deposit_reference); 201 const char *deposit_reference);
202
202#endif 203#endif
diff --git a/src/include/taler_testing_lib.h b/src/include/taler_testing_lib.h
index 4f69a0d01..fc00dcc1e 100644
--- a/src/include/taler_testing_lib.h
+++ b/src/include/taler_testing_lib.h
@@ -388,8 +388,6 @@ struct TALER_TESTING_Interpreter
388}; 388};
389 389
390 390
391
392
393/** 391/**
394 * A command to be run by the interpreter. 392 * A command to be run by the interpreter.
395 */ 393 */
@@ -486,7 +484,6 @@ TALER_TESTING_interpreter_get_current_label (struct
486 TALER_TESTING_Interpreter *is); 484 TALER_TESTING_Interpreter *is);
487 485
488 486
489
490/** 487/**
491 * Get connection handle to the fakebank. 488 * Get connection handle to the fakebank.
492 * 489 *
@@ -1275,7 +1272,6 @@ TALER_TESTING_cmd_check_bank_transfer (const char *label,
1275 uint64_t credit_account); 1272 uint64_t credit_account);
1276 1273
1277 1274
1278
1279/** 1275/**
1280 * Define a "bank check" CMD that takes the input 1276 * Define a "bank check" CMD that takes the input
1281 * data from another CMD that offers it. 1277 * data from another CMD that offers it.
@@ -1585,7 +1581,6 @@ struct TALER_TESTING_Trait
1585}; 1581};
1586 1582
1587 1583
1588
1589/** 1584/**
1590 * "end" trait. Because traits are offered into arrays, 1585 * "end" trait. Because traits are offered into arrays,
1591 * this type of trait is used to mark the end of such arrays; 1586 * this type of trait is used to mark the end of such arrays;
@@ -2077,6 +2072,7 @@ TALER_TESTING_get_trait_peer_key (const struct TALER_TESTING_Command *cmd,
2077 unsigned int index, 2072 unsigned int index,
2078 const struct 2073 const struct
2079 GNUNET_CRYPTO_EddsaPrivateKey **priv); 2074 GNUNET_CRYPTO_EddsaPrivateKey **priv);
2075
2080// FIXME: private get_trait_merchant_priv instead, rather have 2076// FIXME: private get_trait_merchant_priv instead, rather have
2081// more traits with precise types than this! 2077// more traits with precise types than this!
2082 2078
@@ -2094,6 +2090,7 @@ struct TALER_TESTING_Trait
2094TALER_TESTING_make_trait_peer_key (unsigned int index, 2090TALER_TESTING_make_trait_peer_key (unsigned int index,
2095 const struct 2091 const struct
2096 GNUNET_CRYPTO_EddsaPrivateKey *priv); 2092 GNUNET_CRYPTO_EddsaPrivateKey *priv);
2093
2097// FIXME: private get_trait_merchant_priv instead, rather have 2094// FIXME: private get_trait_merchant_priv instead, rather have
2098// more traits with precise types than this! 2095// more traits with precise types than this!
2099 2096
diff --git a/src/include/taler_util.h b/src/include/taler_util.h
index c767a32e3..e1b42f134 100644
--- a/src/include/taler_util.h
+++ b/src/include/taler_util.h
@@ -193,7 +193,8 @@ TALER_buffer_write_fstr (struct TALER_Buffer *buf, const char *fmt, ...);
193 * @param args format argument list 193 * @param args format argument list
194 */ 194 */
195void 195void
196TALER_buffer_write_vfstr (struct TALER_Buffer *buf, const char *fmt, va_list args); 196TALER_buffer_write_vfstr (struct TALER_Buffer *buf, const char *fmt, va_list
197 args);
197 198
198 199
199/** 200/**
@@ -360,10 +361,10 @@ TALER_url_absolute_raw (const char *proto,
360 */ 361 */
361char * 362char *
362TALER_url_absolute_raw_va (const char *proto, 363TALER_url_absolute_raw_va (const char *proto,
363 const char *host, 364 const char *host,
364 const char *prefix, 365 const char *prefix,
365 const char *path, 366 const char *path,
366 va_list args); 367 va_list args);
367 368
368 369
369/** 370/**
diff --git a/src/json/json.c b/src/json/json.c
index 700b58a5a..90fe3dd4f 100644
--- a/src/json/json.c
+++ b/src/json/json.c
@@ -53,7 +53,6 @@ TALER_JSON_hash (const json_t *json,
53} 53}
54 54
55 55
56
57/** 56/**
58 * Extract the Taler error code from the given @a json object. 57 * Extract the Taler error code from the given @a json object.
59 * Note that #TALER_EC_NONE is returned if no "code" is present. 58 * Note that #TALER_EC_NONE is returned if no "code" is present.
@@ -80,4 +79,5 @@ TALER_JSON_get_error_code (const json_t *json)
80 return TALER_EC_INVALID; 79 return TALER_EC_INVALID;
81} 80}
82 81
82
83/* End of json/json.c */ 83/* End of json/json.c */
diff --git a/src/json/json_helper.c b/src/json/json_helper.c
index 9e601ccd9..0f67e9d80 100644
--- a/src/json/json_helper.c
+++ b/src/json/json_helper.c
@@ -47,7 +47,6 @@ TALER_JSON_from_amount (const struct TALER_Amount *amount)
47} 47}
48 48
49 49
50
51/** 50/**
52 * Convert a TALER amount to a JSON object. 51 * Convert a TALER amount to a JSON object.
53 * 52 *
diff --git a/src/json/test_json.c b/src/json/test_json.c
index 5d751bf47..401d07b80 100644
--- a/src/json/test_json.c
+++ b/src/json/test_json.c
@@ -68,4 +68,5 @@ main (int argc,
68 return 0; 68 return 0;
69} 69}
70 70
71
71/* end of test_json.c */ 72/* end of test_json.c */
diff --git a/src/json/test_json_wire.c b/src/json/test_json_wire.c
index ad6b2342f..594c4b834 100644
--- a/src/json/test_json_wire.c
+++ b/src/json/test_json_wire.c
@@ -56,4 +56,5 @@ main (int argc,
56 return 0; 56 return 0;
57} 57}
58 58
59
59/* end of test_json_wire.c */ 60/* end of test_json_wire.c */
diff --git a/src/lib/auditor_api_handle.c b/src/lib/auditor_api_handle.c
index dfccedaa9..a3264c020 100644
--- a/src/lib/auditor_api_handle.c
+++ b/src/lib/auditor_api_handle.c
@@ -258,6 +258,7 @@ decode_version_json (const json_t *resp_obj,
258 return GNUNET_OK; 258 return GNUNET_OK;
259} 259}
260 260
261
261/** 262/**
262 * Initiate download of /version from the auditor. 263 * Initiate download of /version from the auditor.
263 * 264 *
diff --git a/src/lib/exchange_api_common.c b/src/lib/exchange_api_common.c
index 2e13b678e..2c7923cef 100644
--- a/src/lib/exchange_api_common.c
+++ b/src/lib/exchange_api_common.c
@@ -224,10 +224,8 @@ TALER_EXCHANGE_verify_coin_history (const char *currency,
224 for the exchange to lie here, so not checking is probably OK 224 for the exchange to lie here, so not checking is probably OK
225 (an auditor ought to check, though). Then again, we similarly 225 (an auditor ought to check, though). Then again, we similarly
226 had no reason to check the merchant's signature (other than a 226 had no reason to check the merchant's signature (other than a
227 well-formendess check). */ 227 well-formendess check). *//* TODO: check that deposit fee and coin value match
228 /* TODO: check that deposit fee and coin value match 228 our expectations from /keys! */add = GNUNET_NO;
229 our expectations from /keys! */
230 add = GNUNET_NO;
231 } 229 }
232 else if (0 == strcasecmp (type, 230 else if (0 == strcasecmp (type,
233 "PAYBACK")) 231 "PAYBACK"))
@@ -297,8 +295,7 @@ TALER_EXCHANGE_verify_coin_history (const char *currency,
297 However, for the implementation, we first *add* up all of 295 However, for the implementation, we first *add* up all of
298 these negative amounts, as we might get refunds before 296 these negative amounts, as we might get refunds before
299 deposits from a semi-evil exchange. Then, at the end, we do 297 deposits from a semi-evil exchange. Then, at the end, we do
300 the subtraction by calculating "total = total - rtotal" */ 298 the subtraction by calculating "total = total - rtotal" */GNUNET_assert (GNUNET_NO == add);
301 GNUNET_assert (GNUNET_NO == add);
302 if (GNUNET_OK != 299 if (GNUNET_OK !=
303 TALER_amount_add (&rtotal, 300 TALER_amount_add (&rtotal,
304 &rtotal, 301 &rtotal,
@@ -353,4 +350,5 @@ TALER_EXCHANGE_get_exchange_signing_key_info (const struct
353 return NULL; 350 return NULL;
354} 351}
355 352
353
356/* end of exchange_api_common.c */ 354/* end of exchange_api_common.c */
diff --git a/src/lib/exchange_api_handle.c b/src/lib/exchange_api_handle.c
index f4a193d30..efac70777 100644
--- a/src/lib/exchange_api_handle.c
+++ b/src/lib/exchange_api_handle.c
@@ -1138,6 +1138,7 @@ TALER_EXCHANGE_set_now (struct TALER_EXCHANGE_Handle *exchange,
1138 exchange->now = now; 1138 exchange->now = now;
1139} 1139}
1140 1140
1141
1141/** 1142/**
1142 * Unset the fake now to be used when requesting "/keys". 1143 * Unset the fake now to be used when requesting "/keys".
1143 * 1144 *
@@ -1389,6 +1390,7 @@ TEAH_handle_reset (struct TALER_EXCHANGE_Handle *h)
1389 h->state = MHS_INIT; 1390 h->state = MHS_INIT;
1390} 1391}
1391 1392
1393
1392/** 1394/**
1393 * Check if the handle is ready to process requests. 1395 * Check if the handle is ready to process requests.
1394 * 1396 *
@@ -1926,7 +1928,6 @@ TALER_EXCHANGE_connect
1926} 1928}
1927 1929
1928 1930
1929
1930/** 1931/**
1931 * Initiate download of /keys from the exchange. 1932 * Initiate download of /keys from the exchange.
1932 * 1933 *
diff --git a/src/lib/exchange_api_refresh.c b/src/lib/exchange_api_refresh.c
index f99f3ab02..db3692bcd 100644
--- a/src/lib/exchange_api_refresh.c
+++ b/src/lib/exchange_api_refresh.c
@@ -617,14 +617,14 @@ deserialize_melt_data (const char *buf,
617 &buf[off], 617 &buf[off],
618 buf_size - off, 618 buf_size - off,
619 &ok); 619 &ok);
620 for (unsigned int i = 0; (i<md->num_fresh_coins)&&(GNUNET_YES == ok); i++) 620 for (unsigned int i = 0; (i<md->num_fresh_coins) && (GNUNET_YES == ok); i++)
621 off += deserialize_denomination_key (&md->fresh_pks[i], 621 off += deserialize_denomination_key (&md->fresh_pks[i],
622 &buf[off], 622 &buf[off],
623 buf_size - off, 623 buf_size - off,
624 &ok); 624 &ok);
625 625
626 for (unsigned int i = 0; i<TALER_CNC_KAPPA; i++) 626 for (unsigned int i = 0; i<TALER_CNC_KAPPA; i++)
627 for (unsigned int j = 0; (j<md->num_fresh_coins)&&(GNUNET_YES == ok); j++) 627 for (unsigned int j = 0; (j<md->num_fresh_coins) && (GNUNET_YES == ok); j++)
628 off += deserialize_fresh_coin (&md->fresh_coins[i][j], 628 off += deserialize_fresh_coin (&md->fresh_coins[i][j],
629 &buf[off], 629 &buf[off],
630 buf_size - off, 630 buf_size - off,
diff --git a/src/lib/exchange_api_refresh_link.c b/src/lib/exchange_api_refresh_link.c
index 2369b90b3..234043120 100644
--- a/src/lib/exchange_api_refresh_link.c
+++ b/src/lib/exchange_api_refresh_link.c
@@ -203,8 +203,7 @@ parse_refresh_link_ok (struct TALER_EXCHANGE_RefreshLinkHandle *rlh,
203 loop once for 'session=0' in most cases. 203 loop once for 'session=0' in most cases.
204 204
205 num_coins tracks the size of the 1d array we return, 205 num_coins tracks the size of the 1d array we return,
206 whilst 'i' and 'session' track the 2d array. */ 206 whilst 'i' and 'session' track the 2d array. */for (session = 0; session<json_array_size (json); session++)
207 for (session = 0; session<json_array_size (json); session++)
208 { 207 {
209 json_t *jsona; 208 json_t *jsona;
210 struct GNUNET_JSON_Specification spec[] = { 209 struct GNUNET_JSON_Specification spec[] = {
diff --git a/src/lib/exchange_api_reserve.c b/src/lib/exchange_api_reserve.c
index f90bdbb8c..a57d4e9dc 100644
--- a/src/lib/exchange_api_reserve.c
+++ b/src/lib/exchange_api_reserve.c
@@ -233,8 +233,7 @@ parse_reserve_history (struct TALER_EXCHANGE_Handle *exchange,
233 isn't listed twice by the exchange. We use the 233 isn't listed twice by the exchange. We use the
234 "uuid" array to remember the hashes of all 234 "uuid" array to remember the hashes of all
235 purposes, and compare the hashes to find 235 purposes, and compare the hashes to find
236 duplicates. */ 236 duplicates. */GNUNET_CRYPTO_hash (&withdraw_purpose,
237 GNUNET_CRYPTO_hash (&withdraw_purpose,
238 ntohl (withdraw_purpose.purpose.size), 237 ntohl (withdraw_purpose.purpose.size),
239 &uuid[uuid_off]); 238 &uuid[uuid_off]);
240 for (i = 0; i<uuid_off; i++) 239 for (i = 0; i<uuid_off; i++)
diff --git a/src/lib/test_auditor_api.c b/src/lib/test_auditor_api.c
index 656819aa3..85983277e 100644
--- a/src/lib/test_auditor_api.c
+++ b/src/lib/test_auditor_api.c
@@ -203,8 +203,7 @@ run (void *cls,
203 * test-suite gave a account number of _424_ to the user at 203 * test-suite gave a account number of _424_ to the user at
204 * this step; to type less, here the _42_ number is reused. 204 * this step; to type less, here the _42_ number is reused.
205 * Does this change the tests semantics? 205 * Does this change the tests semantics?
206 */ 206 */CMD_TRANSFER_TO_EXCHANGE ("refresh-create-reserve-1",
207 CMD_TRANSFER_TO_EXCHANGE ("refresh-create-reserve-1",
208 "EUR:5.01"), 207 "EUR:5.01"),
209 /** 208 /**
210 * Make previous command effective. 209 * Make previous command effective.
@@ -265,8 +264,7 @@ run (void *cls,
265 * fresh merchant public key! NOTE: this comment comes 264 * fresh merchant public key! NOTE: this comment comes
266 * "verbatim" from the old test-suite, and IMO does not explain 265 * "verbatim" from the old test-suite, and IMO does not explain
267 * a lot! 266 * a lot!
268 */ 267 */CMD_EXEC_AGGREGATOR ("run-aggregator"),
269 CMD_EXEC_AGGREGATOR ("run-aggregator"),
270 268
271 /** 269 /**
272 * Check all the transfers took place. 270 * Check all the transfers took place.
@@ -490,8 +488,7 @@ run (void *cls,
490 * These commands should close the reserve because the aggregator 488 * These commands should close the reserve because the aggregator
491 * is given a config file that ovverrides the reserve expiration 489 * is given a config file that ovverrides the reserve expiration
492 * time (making it now-ish) 490 * time (making it now-ish)
493 */ 491 */CMD_TRANSFER_TO_EXCHANGE ("short-lived-reserve",
494 CMD_TRANSFER_TO_EXCHANGE ("short-lived-reserve",
495 "EUR:5.01"), 492 "EUR:5.01"),
496 TALER_TESTING_cmd_exec_wirewatch ("short-lived-aggregation", 493 TALER_TESTING_cmd_exec_wirewatch ("short-lived-aggregation",
497 CONFIG_FILE_EXPIRE_RESERVE_NOW), 494 CONFIG_FILE_EXPIRE_RESERVE_NOW),
@@ -503,8 +500,7 @@ run (void *cls,
503 * then have the rest paid back. Check deposit of other coin 500 * then have the rest paid back. Check deposit of other coin
504 * fails. (Do not use EUR:5 here as the EUR:5 coin was 501 * fails. (Do not use EUR:5 here as the EUR:5 coin was
505 * revoked and we did not bother to create a new one...) 502 * revoked and we did not bother to create a new one...)
506 */ 503 */CMD_TRANSFER_TO_EXCHANGE ("payback-create-reserve-2",
507 CMD_TRANSFER_TO_EXCHANGE ("payback-create-reserve-2",
508 "EUR:2.02"), 504 "EUR:2.02"),
509 /** 505 /**
510 * Make previous command effective. 506 * Make previous command effective.
@@ -795,4 +791,5 @@ main (int argc,
795 return 0; 791 return 0;
796} 792}
797 793
794
798/* end of test_auditor_api.c */ 795/* end of test_auditor_api.c */
diff --git a/src/lib/test_auditor_api_version.c b/src/lib/test_auditor_api_version.c
index 696e3db27..7444786b8 100644
--- a/src/lib/test_auditor_api_version.c
+++ b/src/lib/test_auditor_api_version.c
@@ -160,4 +160,5 @@ main (int argc,
160 return global_ret; 160 return global_ret;
161} 161}
162 162
163
163/* end of test_auditor_api_version.c */ 164/* end of test_auditor_api_version.c */
diff --git a/src/lib/test_exchange_api.c b/src/lib/test_exchange_api.c
index eeccd3bc2..23a52be1f 100644
--- a/src/lib/test_exchange_api.c
+++ b/src/lib/test_exchange_api.c
@@ -248,8 +248,7 @@ run (void *cls,
248 * contract terms' hashes. So since the contract terms are 248 * contract terms' hashes. So since the contract terms are
249 * exactly the same as the previous command, 249 * exactly the same as the previous command,
250 * how can a different id be generated? 250 * how can a different id be generated?
251 */ 251 */TALER_TESTING_cmd_deposit
252 TALER_TESTING_cmd_deposit
253 ("deposit-double-1", "withdraw-coin-1", 0, 252 ("deposit-double-1", "withdraw-coin-1", 0,
254 TALER_TESTING_make_wire_details (43, 253 TALER_TESTING_make_wire_details (43,
255 fakebank_url), 254 fakebank_url),
@@ -277,8 +276,7 @@ run (void *cls,
277 * test-suite gave a account number of _424_ to the user at 276 * test-suite gave a account number of _424_ to the user at
278 * this step; to type less, here the _42_ number is reused. 277 * this step; to type less, here the _42_ number is reused.
279 * Does this change the tests semantics? 278 * Does this change the tests semantics?
280 */ 279 */CMD_TRANSFER_TO_EXCHANGE ("refresh-create-reserve-1",
281 CMD_TRANSFER_TO_EXCHANGE ("refresh-create-reserve-1",
282 "EUR:5.01"), 280 "EUR:5.01"),
283 281
284 /** 282 /**
@@ -298,8 +296,7 @@ run (void *cls,
298 * Try to partially spend (deposit) 1 EUR of the 5 EUR coin 296 * Try to partially spend (deposit) 1 EUR of the 5 EUR coin
299 * (in full) (merchant would receive EUR:0.99 due to 1 ct 297 * (in full) (merchant would receive EUR:0.99 due to 1 ct
300 * deposit fee) 298 * deposit fee)
301 */ 299 */TALER_TESTING_cmd_deposit
302 TALER_TESTING_cmd_deposit
303 ("refresh-deposit-partial", 300 ("refresh-deposit-partial",
304 "refresh-withdraw-coin-1", 0, 301 "refresh-withdraw-coin-1", 0,
305 TALER_TESTING_make_wire_details (42, 302 TALER_TESTING_make_wire_details (42,
@@ -381,8 +378,7 @@ run (void *cls,
381 * Try resolving a deposit's WTID, as we never triggered 378 * Try resolving a deposit's WTID, as we never triggered
382 * execution of transactions, the answer should be that 379 * execution of transactions, the answer should be that
383 * the exchange knows about the deposit, but has no WTID yet. 380 * the exchange knows about the deposit, but has no WTID yet.
384 */ 381 */TALER_TESTING_cmd_track_transaction
385 TALER_TESTING_cmd_track_transaction
386 ("deposit-wtid-found", 382 ("deposit-wtid-found",
387 "deposit-simple", 0, MHD_HTTP_ACCEPTED, NULL), 383 "deposit-simple", 0, MHD_HTTP_ACCEPTED, NULL),
388 384
@@ -390,8 +386,7 @@ run (void *cls,
390 * Try resolving a deposit's WTID for a failed deposit. 386 * Try resolving a deposit's WTID for a failed deposit.
391 * As the deposit failed, the answer should be that the 387 * As the deposit failed, the answer should be that the
392 * exchange does NOT know about the deposit. 388 * exchange does NOT know about the deposit.
393 */ 389 */TALER_TESTING_cmd_track_transaction
394 TALER_TESTING_cmd_track_transaction
395 ("deposit-wtid-failing", 390 ("deposit-wtid-failing",
396 "deposit-double-2", 0, MHD_HTTP_NOT_FOUND, NULL), 391 "deposit-double-2", 0, MHD_HTTP_NOT_FOUND, NULL),
397 392
@@ -399,8 +394,7 @@ run (void *cls,
399 * Try resolving an undefined (all zeros) WTID; this 394 * Try resolving an undefined (all zeros) WTID; this
400 * should fail as obviously the exchange didn't use that 395 * should fail as obviously the exchange didn't use that
401 * WTID value for any transaction. 396 * WTID value for any transaction.
402 */ 397 */TALER_TESTING_cmd_track_transfer_empty
403 TALER_TESTING_cmd_track_transfer_empty
404 ("wire-deposit-failing", 398 ("wire-deposit-failing",
405 NULL, 0, MHD_HTTP_NOT_FOUND), 399 NULL, 0, MHD_HTTP_NOT_FOUND),
406 400
@@ -410,8 +404,7 @@ run (void *cls,
410 * fresh merchant public key! NOTE: this comment comes 404 * fresh merchant public key! NOTE: this comment comes
411 * "verbatim" from the old test-suite, and IMO does not explain 405 * "verbatim" from the old test-suite, and IMO does not explain
412 * a lot! 406 * a lot!
413 */ 407 */CMD_EXEC_AGGREGATOR ("run-aggregator"),
414 CMD_EXEC_AGGREGATOR ("run-aggregator"),
415 408
416 /** 409 /**
417 * Check all the transfers took place. 410 * Check all the transfers took place.
@@ -560,9 +553,7 @@ run (void *cls,
560 * the preliminary transfer (used to withdraw) from the 553 * the preliminary transfer (used to withdraw) from the
561 * fakebank and the second to actually check there are not 554 * fakebank and the second to actually check there are not
562 * other transfers around. 555 * other transfers around.
563 */ 556 */TALER_TESTING_cmd_check_bank_transfer
564
565 TALER_TESTING_cmd_check_bank_transfer
566 ("check_bank_transfer-pre-refund", exchange_url, 557 ("check_bank_transfer-pre-refund", exchange_url,
567 "EUR:5.01", 42, 2), 558 "EUR:5.01", 42, 2),
568 559
@@ -657,8 +648,7 @@ run (void *cls,
657 * Run transfers. This will do the transfer as refund deadline 648 * Run transfers. This will do the transfer as refund deadline
658 * was 0, except of course because the refund succeeded, the 649 * was 0, except of course because the refund succeeded, the
659 * transfer should no longer be done. 650 * transfer should no longer be done.
660 */ 651 */CMD_EXEC_AGGREGATOR ("run-aggregator-3b"),
661 CMD_EXEC_AGGREGATOR ("run-aggregator-3b"),
662 652
663 /* check that aggregator didn't do anything, as expected */ 653 /* check that aggregator didn't do anything, as expected */
664 TALER_TESTING_cmd_check_bank_empty 654 TALER_TESTING_cmd_check_bank_empty
@@ -729,8 +719,7 @@ run (void *cls,
729 * These commands should close the reserve because 719 * These commands should close the reserve because
730 * the aggregator is given a config file that ovverrides 720 * the aggregator is given a config file that ovverrides
731 * the reserve expiration time (making it now-ish) 721 * the reserve expiration time (making it now-ish)
732 */ 722 */CMD_TRANSFER_TO_EXCHANGE
733 CMD_TRANSFER_TO_EXCHANGE
734 ("short-lived-reserve", 723 ("short-lived-reserve",
735 "EUR:5.01"), 724 "EUR:5.01"),
736 725
@@ -773,8 +762,7 @@ run (void *cls,
773 * then have the rest paid back. Check deposit of other coin 762 * then have the rest paid back. Check deposit of other coin
774 * fails. (Do not use EUR:5 here as the EUR:5 coin was 763 * fails. (Do not use EUR:5 here as the EUR:5 coin was
775 * revoked and we did not bother to create a new one...) 764 * revoked and we did not bother to create a new one...)
776 */ 765 */CMD_TRANSFER_TO_EXCHANGE ("payback-create-reserve-2",
777 CMD_TRANSFER_TO_EXCHANGE ("payback-create-reserve-2",
778 "EUR:2.02"), 766 "EUR:2.02"),
779 767
780 /* Make previous command effective. */ 768 /* Make previous command effective. */
@@ -1008,4 +996,5 @@ main (int argc,
1008 return 0; 996 return 0;
1009} 997}
1010 998
999
1011/* end of test_exchange_api.c */ 1000/* end of test_exchange_api.c */
diff --git a/src/lib/test_exchange_api_interpreter_on-off.c b/src/lib/test_exchange_api_interpreter_on-off.c
index 40094ad4b..d30dee952 100644
--- a/src/lib/test_exchange_api_interpreter_on-off.c
+++ b/src/lib/test_exchange_api_interpreter_on-off.c
@@ -124,4 +124,5 @@ main (int argc,
124 return 0; 124 return 0;
125} 125}
126 126
127
127/* end of test_exchange_api_keys_cherry_picking_new.c */ 128/* end of test_exchange_api_keys_cherry_picking_new.c */
diff --git a/src/lib/test_exchange_api_keys_cherry_picking.c b/src/lib/test_exchange_api_keys_cherry_picking.c
index 3acc27536..8805e7c56 100644
--- a/src/lib/test_exchange_api_keys_cherry_picking.c
+++ b/src/lib/test_exchange_api_keys_cherry_picking.c
@@ -166,8 +166,7 @@ run (void *cls,
166 * key set. The new KS will have only one key, because the 166 * key set. The new KS will have only one key, because the
167 * current lookahead_sign == 60 seconds and the key's withdraw 167 * current lookahead_sign == 60 seconds and the key's withdraw
168 * duration is 80 seconds. 168 * duration is 80 seconds.
169 */ 169 */TALER_TESTING_cmd_exec_keyup_with_now
170 TALER_TESTING_cmd_exec_keyup_with_now
171 ("keyup-1", 170 ("keyup-1",
172 CONFIG_FILE, 171 CONFIG_FILE,
173 TTH_parse_time (JAN2030)), 172 TTH_parse_time (JAN2030)),
@@ -175,8 +174,7 @@ run (void *cls,
175 * Should return 1 new key, + the original one. NOTE: the 174 * Should return 1 new key, + the original one. NOTE: the
176 * original DK will never be 'cancelled' as for the current 175 * original DK will never be 'cancelled' as for the current
177 * libtalerexchange logic, so it must always be counted. 176 * libtalerexchange logic, so it must always be counted.
178 */ 177 */TALER_TESTING_cmd_check_keys_with_now
179 TALER_TESTING_cmd_check_keys_with_now
180 ("check-keys-2", 178 ("check-keys-2",
181 2, /* generation */ 179 2, /* generation */
182 2, 180 2,
@@ -204,9 +202,7 @@ run (void *cls,
204 * very initial setup, and 1 from the 'keyup-1' CMD) 202 * very initial setup, and 1 from the 'keyup-1' CMD)
205 * ---- 203 * ----
206 * 46 204 * 46
207 */ 205 */TALER_TESTING_cmd_check_keys_with_now
208
209 TALER_TESTING_cmd_check_keys_with_now
210 ("check-keys-3", 206 ("check-keys-3",
211 3, 207 3,
212 NDKS_RIGHT_BEFORE_SERIALIZATION, 208 NDKS_RIGHT_BEFORE_SERIALIZATION,
@@ -269,4 +265,5 @@ main (int argc,
269 return 0; 265 return 0;
270} 266}
271 267
268
272/* end of test_exchange_api_keys_cherry_picking.c */ 269/* end of test_exchange_api_keys_cherry_picking.c */
diff --git a/src/lib/test_exchange_api_overlapping_keys_bug.c b/src/lib/test_exchange_api_overlapping_keys_bug.c
index 6680fbbc9..a5ddac516 100644
--- a/src/lib/test_exchange_api_overlapping_keys_bug.c
+++ b/src/lib/test_exchange_api_overlapping_keys_bug.c
@@ -132,4 +132,5 @@ main (int argc,
132 return 0; 132 return 0;
133} 133}
134 134
135
135/* end of test_exchange_api_overlapping_keys_bug.c */ 136/* end of test_exchange_api_overlapping_keys_bug.c */
diff --git a/src/lib/test_exchange_api_revocation.c b/src/lib/test_exchange_api_revocation.c
index c0c96766c..dfe185450 100644
--- a/src/lib/test_exchange_api_revocation.c
+++ b/src/lib/test_exchange_api_revocation.c
@@ -134,8 +134,7 @@ run (void *cls,
134 * Try to partially spend (deposit) 1 EUR of the 5 EUR coin 134 * Try to partially spend (deposit) 1 EUR of the 5 EUR coin
135 * (in full) (merchant would receive EUR:0.99 due to 1 ct 135 * (in full) (merchant would receive EUR:0.99 due to 1 ct
136 * deposit fee) 136 * deposit fee)
137 */ 137 */TALER_TESTING_cmd_deposit
138 TALER_TESTING_cmd_deposit
139 ("deposit-partial", 138 ("deposit-partial",
140 "withdraw-coin-1", 0, 139 "withdraw-coin-1", 0,
141 TALER_TESTING_make_wire_details (42, 140 TALER_TESTING_make_wire_details (42,
@@ -278,4 +277,5 @@ main (int argc,
278 return 0; 277 return 0;
279} 278}
280 279
280
281/* end of test_exchange_api_revocation.c */ 281/* end of test_exchange_api_revocation.c */
diff --git a/src/lib/test_exchange_api_twisted.c b/src/lib/test_exchange_api_twisted.c
index 52c928341..739669b97 100644
--- a/src/lib/test_exchange_api_twisted.c
+++ b/src/lib/test_exchange_api_twisted.c
@@ -213,8 +213,7 @@ run (void *cls,
213 * NOTE: not all CMDs actually need the twister, 213 * NOTE: not all CMDs actually need the twister,
214 * so it may be better to move those into the "main" 214 * so it may be better to move those into the "main"
215 * lib test suite. 215 * lib test suite.
216 */ 216 */struct TALER_TESTING_Command refund[] = {
217 struct TALER_TESTING_Command refund[] = {
218 217
219 CMD_TRANSFER_TO_EXCHANGE 218 CMD_TRANSFER_TO_EXCHANGE
220 ("create-reserve-r1", 219 ("create-reserve-r1",
@@ -328,6 +327,7 @@ run (void *cls,
328 fakebank_url); 327 fakebank_url);
329} 328}
330 329
330
331/** 331/**
332 * Kill, wait, and destroy convenience function. 332 * Kill, wait, and destroy convenience function.
333 * 333 *
@@ -341,6 +341,7 @@ purge_process (struct GNUNET_OS_Process *process)
341 GNUNET_OS_process_destroy (process); 341 GNUNET_OS_process_destroy (process);
342} 342}
343 343
344
344int 345int
345main (int argc, 346main (int argc,
346 char *const *argv) 347 char *const *argv)
@@ -395,4 +396,5 @@ main (int argc,
395 return 0; 396 return 0;
396} 397}
397 398
399
398/* end of test_exchange_api_twisted.c */ 400/* end of test_exchange_api_twisted.c */
diff --git a/src/lib/testing_api_cmd_bank_check.c b/src/lib/testing_api_cmd_bank_check.c
index 0006b6e5e..f51c535a1 100644
--- a/src/lib/testing_api_cmd_bank_check.c
+++ b/src/lib/testing_api_cmd_bank_check.c
@@ -172,6 +172,7 @@ check_bank_transfer_run (void *cls,
172 TALER_TESTING_interpreter_next (is); 172 TALER_TESTING_interpreter_next (is);
173} 173}
174 174
175
175/** 176/**
176 * Free the state of a "bank check" CMD. 177 * Free the state of a "bank check" CMD.
177 * 178 *
@@ -189,6 +190,7 @@ check_bank_transfer_cleanup
189 GNUNET_free (bcs); 190 GNUNET_free (bcs);
190} 191}
191 192
193
192/** 194/**
193 * Offer internal data from a "bank check" CMD state. 195 * Offer internal data from a "bank check" CMD state.
194 * 196 *
@@ -230,7 +232,6 @@ check_bank_transfer_traits (void *cls,
230} 232}
231 233
232 234
233
234/** 235/**
235 * Make a "bank check" CMD. It checks whether a 236 * Make a "bank check" CMD. It checks whether a
236 * particular wire transfer has been made or not. 237 * particular wire transfer has been made or not.
@@ -273,6 +274,7 @@ TALER_TESTING_cmd_check_bank_transfer
273 return cmd; 274 return cmd;
274} 275}
275 276
277
276/** 278/**
277 * Cleanup the state, only defined to respect the API. 279 * Cleanup the state, only defined to respect the API.
278 * 280 *
@@ -287,6 +289,7 @@ check_bank_empty_cleanup
287 return; 289 return;
288} 290}
289 291
292
290/** 293/**
291 * Run the command. 294 * Run the command.
292 * 295 *
diff --git a/src/lib/testing_api_cmd_batch.c b/src/lib/testing_api_cmd_batch.c
index f5fbc8117..84bd51b69 100644
--- a/src/lib/testing_api_cmd_batch.c
+++ b/src/lib/testing_api_cmd_batch.c
@@ -136,6 +136,7 @@ batch_traits (void *cls,
136 index); 136 index);
137} 137}
138 138
139
139/** 140/**
140 * Create a "batch" command. Such command takes a 141 * Create a "batch" command. Such command takes a
141 * end_CMD-terminated array of CMDs and executed them. 142 * end_CMD-terminated array of CMDs and executed them.
@@ -179,6 +180,7 @@ TALER_TESTING_cmd_batch (const char *label,
179 return cmd; 180 return cmd;
180} 181}
181 182
183
182/** 184/**
183 * Advance internal pointer to next command. 185 * Advance internal pointer to next command.
184 * 186 *
@@ -200,7 +202,6 @@ TALER_TESTING_cmd_batch_next
200} 202}
201 203
202 204
203
204/** 205/**
205 * Test if this command is a batch command. 206 * Test if this command is a batch command.
206 * 207 *
diff --git a/src/lib/testing_api_cmd_check_keys.c b/src/lib/testing_api_cmd_check_keys.c
index a0b61c1b0..b4db78697 100644
--- a/src/lib/testing_api_cmd_check_keys.c
+++ b/src/lib/testing_api_cmd_check_keys.c
@@ -141,8 +141,7 @@ check_keys_run (void *cls,
141 * a "maybe" basis, so it can get quite hard to track /keys 141 * a "maybe" basis, so it can get quite hard to track /keys
142 * request. Rather, this CMD should just check if /keys was 142 * request. Rather, this CMD should just check if /keys was
143 * requested AT LEAST n times before going ahead with checks. 143 * requested AT LEAST n times before going ahead with checks.
144 */ 144 */if (is->key_generation > cks->generation)
145 if (is->key_generation > cks->generation)
146 { 145 {
147 /* We got /keys too often, strange. Fatal. May theoretically 146 /* We got /keys too often, strange. Fatal. May theoretically
148 happen if somehow we were really unlucky and /keys expired 147 happen if somehow we were really unlucky and /keys expired
@@ -237,6 +236,7 @@ TALER_TESTING_cmd_check_keys_with_last_denom
237 return cmd; 236 return cmd;
238} 237}
239 238
239
240/** 240/**
241 * Make a "check keys" command. This type of command 241 * Make a "check keys" command. This type of command
242 * checks whether the number of denomination keys from 242 * checks whether the number of denomination keys from
@@ -321,7 +321,6 @@ TALER_TESTING_cmd_check_keys_with_now
321} 321}
322 322
323 323
324
325/** 324/**
326 * Make a "check keys" command that forcedly does NOT cherry pick; 325 * Make a "check keys" command that forcedly does NOT cherry pick;
327 * just redownload the whole /keys. Then checks whether the number 326 * just redownload the whole /keys. Then checks whether the number
diff --git a/src/lib/testing_api_cmd_deposit.c b/src/lib/testing_api_cmd_deposit.c
index 84fba8f31..fcc9a6375 100644
--- a/src/lib/testing_api_cmd_deposit.c
+++ b/src/lib/testing_api_cmd_deposit.c
@@ -485,6 +485,7 @@ deposit_traits (void *cls,
485 index); 485 index);
486} 486}
487 487
488
488/** 489/**
489 * Create a "deposit" command. 490 * Create a "deposit" command.
490 * 491 *
diff --git a/src/lib/testing_api_cmd_exec_aggregator.c b/src/lib/testing_api_cmd_exec_aggregator.c
index c51d44989..7046f162a 100644
--- a/src/lib/testing_api_cmd_exec_aggregator.c
+++ b/src/lib/testing_api_cmd_exec_aggregator.c
@@ -163,4 +163,5 @@ TALER_TESTING_cmd_exec_aggregator (const char *label,
163 return cmd; 163 return cmd;
164} 164}
165 165
166
166/* end of testing_api_cmd_exec_aggregator.c */ 167/* end of testing_api_cmd_exec_aggregator.c */
diff --git a/src/lib/testing_api_cmd_exec_auditor-sign.c b/src/lib/testing_api_cmd_exec_auditor-sign.c
index 1a722ad2f..a37638821 100644
--- a/src/lib/testing_api_cmd_exec_auditor-sign.c
+++ b/src/lib/testing_api_cmd_exec_auditor-sign.c
@@ -229,4 +229,5 @@ TALER_TESTING_cmd_exec_auditor_sign (const char *label,
229 } 229 }
230} 230}
231 231
232
232/* end of testing_api_cmd_exec_auditor-sign.c */ 233/* end of testing_api_cmd_exec_auditor-sign.c */
diff --git a/src/lib/testing_api_cmd_exec_keyup.c b/src/lib/testing_api_cmd_exec_keyup.c
index 65f23693e..89b9d597e 100644
--- a/src/lib/testing_api_cmd_exec_keyup.c
+++ b/src/lib/testing_api_cmd_exec_keyup.c
@@ -201,6 +201,7 @@ TALER_TESTING_cmd_exec_keyup_with_now
201 return cmd; 201 return cmd;
202} 202}
203 203
204
204/** 205/**
205 * Make the "keyup" CMD. 206 * Make the "keyup" CMD.
206 * 207 *
@@ -229,4 +230,5 @@ TALER_TESTING_cmd_exec_keyup (const char *label,
229 return cmd; 230 return cmd;
230} 231}
231 232
233
232/* end of testing_api_cmd_exec_keyup.c */ 234/* end of testing_api_cmd_exec_keyup.c */
diff --git a/src/lib/testing_api_cmd_exec_wirewatch.c b/src/lib/testing_api_cmd_exec_wirewatch.c
index c9ca42549..c5a5c2f36 100644
--- a/src/lib/testing_api_cmd_exec_wirewatch.c
+++ b/src/lib/testing_api_cmd_exec_wirewatch.c
@@ -31,7 +31,6 @@
31#include "taler_testing_lib.h" 31#include "taler_testing_lib.h"
32 32
33 33
34
35/** 34/**
36 * State for a "wirewatch" CMD. 35 * State for a "wirewatch" CMD.
37 */ 36 */
@@ -165,4 +164,5 @@ TALER_TESTING_cmd_exec_wirewatch (const char *label,
165 return cmd; 164 return cmd;
166} 165}
167 166
167
168/* end of testing_api_cmd_exec_wirewatch.c */ 168/* end of testing_api_cmd_exec_wirewatch.c */
diff --git a/src/lib/testing_api_cmd_fakebank_transfer.c b/src/lib/testing_api_cmd_fakebank_transfer.c
index 729536b56..81378238c 100644
--- a/src/lib/testing_api_cmd_fakebank_transfer.c
+++ b/src/lib/testing_api_cmd_fakebank_transfer.c
@@ -417,6 +417,7 @@ fakebank_transfer_cleanup (void *cls,
417 GNUNET_free (fts); 417 GNUNET_free (fts);
418} 418}
419 419
420
420/** 421/**
421 * Offer internal data from a "fakebank transfer" CMD to other 422 * Offer internal data from a "fakebank transfer" CMD to other
422 * commands. 423 * commands.
@@ -766,4 +767,5 @@ TALER_TESTING_cmd_fakebank_transfer_retry (struct TALER_TESTING_Command cmd)
766 return cmd; 767 return cmd;
767} 768}
768 769
770
769/* end of testing_api_cmd_fakebank_transfer.c */ 771/* end of testing_api_cmd_fakebank_transfer.c */
diff --git a/src/lib/testing_api_cmd_payback.c b/src/lib/testing_api_cmd_payback.c
index c69d1d089..1591b64ab 100644
--- a/src/lib/testing_api_cmd_payback.c
+++ b/src/lib/testing_api_cmd_payback.c
@@ -485,6 +485,7 @@ revoke_traits (void *cls,
485 index); 485 index);
486} 486}
487 487
488
488/** 489/**
489 * Run the "revoke" command. The core of the function 490 * Run the "revoke" command. The core of the function
490 * is to call the "keyup" utility passing it the base32 491 * is to call the "keyup" utility passing it the base32
diff --git a/src/lib/testing_api_cmd_refresh.c b/src/lib/testing_api_cmd_refresh.c
index 5d1472a01..bf0f4ea19 100644
--- a/src/lib/testing_api_cmd_refresh.c
+++ b/src/lib/testing_api_cmd_refresh.c
@@ -884,7 +884,8 @@ refresh_melt_run (void *cls,
884 rms->noreveal_index = UINT16_MAX; 884 rms->noreveal_index = UINT16_MAX;
885 for (num_fresh_coins = 0; 885 for (num_fresh_coins = 0;
886 NULL != melt_fresh_amounts[num_fresh_coins]; 886 NULL != melt_fresh_amounts[num_fresh_coins];
887 num_fresh_coins++); 887 num_fresh_coins++)
888 ;
888 rms->num_fresh_coins = num_fresh_coins; 889 rms->num_fresh_coins = num_fresh_coins;
889 rms->fresh_pks = GNUNET_new_array 890 rms->fresh_pks = GNUNET_new_array
890 (num_fresh_coins, 891 (num_fresh_coins,
diff --git a/src/lib/testing_api_cmd_sleep.c b/src/lib/testing_api_cmd_sleep.c
index 4d270331e..f3235b8e8 100644
--- a/src/lib/testing_api_cmd_sleep.c
+++ b/src/lib/testing_api_cmd_sleep.c
@@ -224,4 +224,5 @@ TALER_TESTING_cmd_wait_service (const char *label,
224 return cmd; 224 return cmd;
225} 225}
226 226
227
227/* end of testing_api_cmd_sleep.c */ 228/* end of testing_api_cmd_sleep.c */
diff --git a/src/lib/testing_api_cmd_status.c b/src/lib/testing_api_cmd_status.c
index 0dcea1233..398221a10 100644
--- a/src/lib/testing_api_cmd_status.c
+++ b/src/lib/testing_api_cmd_status.c
@@ -126,9 +126,7 @@ reserve_status_cb
126 * "reserve history update trait" which returns information about 126 * "reserve history update trait" which returns information about
127 * how the command changes the history (provided only by commands 127 * how the command changes the history (provided only by commands
128 * that change reserve balances)? 128 * that change reserve balances)?
129 */ 129 */TALER_TESTING_interpreter_next (ss->is);
130
131 TALER_TESTING_interpreter_next (ss->is);
132} 130}
133 131
134 132
diff --git a/src/lib/testing_api_cmd_track.c b/src/lib/testing_api_cmd_track.c
index e32d24ce2..41c6be171 100644
--- a/src/lib/testing_api_cmd_track.c
+++ b/src/lib/testing_api_cmd_track.c
@@ -589,9 +589,7 @@ track_transfer_cb
589 * or any operation that could provide wire-details. (2) 589 * or any operation that could provide wire-details. (2)
590 * Total amount for this transfer matches the one from any 590 * Total amount for this transfer matches the one from any
591 * referenced command that could provide one. 591 * referenced command that could provide one.
592 */ 592 */if (NULL != tts->wire_details_reference)
593
594 if (NULL != tts->wire_details_reference)
595 { 593 {
596 const struct TALER_TESTING_Command *wire_details_cmd; 594 const struct TALER_TESTING_Command *wire_details_cmd;
597 const json_t *wire_details; 595 const json_t *wire_details;
@@ -674,6 +672,7 @@ track_transfer_cb
674 TALER_TESTING_interpreter_next (is); 672 TALER_TESTING_interpreter_next (is);
675} 673}
676 674
675
677/** 676/**
678 * Run the command. 677 * Run the command.
679 * 678 *
@@ -727,6 +726,7 @@ track_transfer_run (void *cls,
727 GNUNET_assert (NULL != tts->tth); 726 GNUNET_assert (NULL != tts->tth);
728} 727}
729 728
729
730/** 730/**
731 * Make a "track transfer" CMD where no "expected"-arguments, 731 * Make a "track transfer" CMD where no "expected"-arguments,
732 * except the HTTP response code, are given. The best use case 732 * except the HTTP response code, are given. The best use case
@@ -769,6 +769,7 @@ TALER_TESTING_cmd_track_transfer_empty
769 return cmd; 769 return cmd;
770} 770}
771 771
772
772/** 773/**
773 * Make a "track transfer" command, specifying which amount and 774 * Make a "track transfer" command, specifying which amount and
774 * wire fee are expected. 775 * wire fee are expected.
@@ -814,4 +815,5 @@ TALER_TESTING_cmd_track_transfer
814 return cmd; 815 return cmd;
815} 816}
816 817
818
817/* end of testing_api_cmd_track.c */ 819/* end of testing_api_cmd_track.c */
diff --git a/src/lib/testing_api_cmd_wire.c b/src/lib/testing_api_cmd_wire.c
index e2a8d7f1f..950ed62f7 100644
--- a/src/lib/testing_api_cmd_wire.c
+++ b/src/lib/testing_api_cmd_wire.c
@@ -201,6 +201,7 @@ wire_cleanup (void *cls,
201 GNUNET_free (ws); 201 GNUNET_free (ws);
202} 202}
203 203
204
204/** 205/**
205 * Create a "wire" command. 206 * Create a "wire" command.
206 * 207 *
diff --git a/src/lib/testing_api_cmd_withdraw.c b/src/lib/testing_api_cmd_withdraw.c
index 92b587b5a..550ea9577 100644
--- a/src/lib/testing_api_cmd_withdraw.c
+++ b/src/lib/testing_api_cmd_withdraw.c
@@ -32,7 +32,6 @@
32#include "backoff.h" 32#include "backoff.h"
33 33
34 34
35
36/** 35/**
37 * State for a "withdraw" CMD. 36 * State for a "withdraw" CMD.
38 */ 37 */
diff --git a/src/lib/testing_api_helpers.c b/src/lib/testing_api_helpers.c
index a7b45e600..2e1fb2d06 100644
--- a/src/lib/testing_api_helpers.c
+++ b/src/lib/testing_api_helpers.c
@@ -1077,4 +1077,5 @@ TALER_TESTING_prepare_fakebank (const char *config_filename,
1077 return fakebank_url; 1077 return fakebank_url;
1078} 1078}
1079 1079
1080
1080/* end of testing_api_helpers.c */ 1081/* end of testing_api_helpers.c */
diff --git a/src/lib/testing_api_loop.c b/src/lib/testing_api_loop.c
index 38139de25..fa723eb6e 100644
--- a/src/lib/testing_api_loop.c
+++ b/src/lib/testing_api_loop.c
@@ -491,7 +491,8 @@ TALER_TESTING_run2 (struct TALER_TESTING_Interpreter *is,
491 is->timeout_task = NULL; 491 is->timeout_task = NULL;
492 } 492 }
493 /* get the number of commands */ 493 /* get the number of commands */
494 for (i = 0; NULL != commands[i].label; i++); 494 for (i = 0; NULL != commands[i].label; i++)
495 ;
495 is->commands = GNUNET_new_array (i + 1, 496 is->commands = GNUNET_new_array (i + 1,
496 struct TALER_TESTING_Command); 497 struct TALER_TESTING_Command);
497 memcpy (is->commands, 498 memcpy (is->commands,
@@ -831,4 +832,5 @@ TALER_TESTING_setup (TALER_TESTING_Main main_cb,
831 return is.result; 832 return is.result;
832} 833}
833 834
835
834/* end of testing_api_loop.c */ 836/* end of testing_api_loop.c */
diff --git a/src/lib/testing_api_trait_blinding_key.c b/src/lib/testing_api_trait_blinding_key.c
index b723e5cfc..e6b9e485d 100644
--- a/src/lib/testing_api_trait_blinding_key.c
+++ b/src/lib/testing_api_trait_blinding_key.c
@@ -54,7 +54,6 @@ TALER_TESTING_get_trait_blinding_key
54} 54}
55 55
56 56
57
58/** 57/**
59 * Offer blinding key. 58 * Offer blinding key.
60 * 59 *
@@ -77,4 +76,5 @@ TALER_TESTING_make_trait_blinding_key
77 return ret; 76 return ret;
78} 77}
79 78
79
80/* end of testing_api_trait_blinding_key.c */ 80/* end of testing_api_trait_blinding_key.c */
diff --git a/src/lib/testing_api_trait_cmd.c b/src/lib/testing_api_trait_cmd.c
index faf8799be..9c25fd886 100644
--- a/src/lib/testing_api_trait_cmd.c
+++ b/src/lib/testing_api_trait_cmd.c
@@ -79,4 +79,5 @@ TALER_TESTING_make_trait_cmd
79 return ret; 79 return ret;
80} 80}
81 81
82
82/* end of testing_api_trait_cmd.c */ 83/* end of testing_api_trait_cmd.c */
diff --git a/src/lib/testing_api_trait_coin_priv.c b/src/lib/testing_api_trait_coin_priv.c
index 85331de7e..b7ca1b8f6 100644
--- a/src/lib/testing_api_trait_coin_priv.c
+++ b/src/lib/testing_api_trait_coin_priv.c
@@ -75,4 +75,5 @@ TALER_TESTING_make_trait_coin_priv
75 return ret; 75 return ret;
76} 76}
77 77
78
78/* end of testing_api_trait_coin_priv.c */ 79/* end of testing_api_trait_coin_priv.c */
diff --git a/src/lib/testing_api_trait_denom_pub.c b/src/lib/testing_api_trait_denom_pub.c
index b11c459ee..3bb3182a2 100644
--- a/src/lib/testing_api_trait_denom_pub.c
+++ b/src/lib/testing_api_trait_denom_pub.c
@@ -75,4 +75,5 @@ TALER_TESTING_make_trait_denom_pub
75 return ret; 75 return ret;
76} 76}
77 77
78
78/* end of testing_api_trait_denom_pub.c */ 79/* end of testing_api_trait_denom_pub.c */
diff --git a/src/lib/testing_api_trait_exchange_pub.c b/src/lib/testing_api_trait_exchange_pub.c
index 711d56f0c..3e3adb75c 100644
--- a/src/lib/testing_api_trait_exchange_pub.c
+++ b/src/lib/testing_api_trait_exchange_pub.c
@@ -74,4 +74,5 @@ TALER_TESTING_make_trait_exchange_pub
74 return ret; 74 return ret;
75} 75}
76 76
77
77/* end of testing_api_trait_exchange_pub.c */ 78/* end of testing_api_trait_exchange_pub.c */
diff --git a/src/lib/testing_api_trait_exchange_sig.c b/src/lib/testing_api_trait_exchange_sig.c
index c7ed29b2c..4b2672d74 100644
--- a/src/lib/testing_api_trait_exchange_sig.c
+++ b/src/lib/testing_api_trait_exchange_sig.c
@@ -74,4 +74,5 @@ TALER_TESTING_make_trait_exchange_sig
74 return ret; 74 return ret;
75} 75}
76 76
77
77/* end of testing_api_trait_exchange_sig.c */ 78/* end of testing_api_trait_exchange_sig.c */
diff --git a/src/lib/testing_api_trait_fresh_coin.c b/src/lib/testing_api_trait_fresh_coin.c
index 92d6d4b9c..3c0ee1df1 100644
--- a/src/lib/testing_api_trait_fresh_coin.c
+++ b/src/lib/testing_api_trait_fresh_coin.c
@@ -76,4 +76,5 @@ TALER_TESTING_make_trait_fresh_coins
76 return ret; 76 return ret;
77} 77}
78 78
79
79/* end of testing_api_trait_fresh_coin.c */ 80/* end of testing_api_trait_fresh_coin.c */
diff --git a/src/lib/testing_api_trait_json.c b/src/lib/testing_api_trait_json.c
index 5307dc370..b3370162b 100644
--- a/src/lib/testing_api_trait_json.c
+++ b/src/lib/testing_api_trait_json.c
@@ -74,6 +74,7 @@ TALER_TESTING_make_trait_exchange_keys
74 return ret; 74 return ret;
75} 75}
76 76
77
77/** 78/**
78 * Obtain wire details from @a cmd. 79 * Obtain wire details from @a cmd.
79 * 80 *
@@ -119,4 +120,5 @@ TALER_TESTING_make_trait_wire_details
119 return ret; 120 return ret;
120} 121}
121 122
123
122/* end of testing_api_trait_json.c */ 124/* end of testing_api_trait_json.c */
diff --git a/src/lib/testing_api_trait_key_peer.c b/src/lib/testing_api_trait_key_peer.c
index f26169eb6..e5d1e82f2 100644
--- a/src/lib/testing_api_trait_key_peer.c
+++ b/src/lib/testing_api_trait_key_peer.c
@@ -54,6 +54,7 @@ TALER_TESTING_get_trait_peer_key
54 index); 54 index);
55} 55}
56 56
57
57/** 58/**
58 * Offer private key, typically done when CMD_1 needs it to 59 * Offer private key, typically done when CMD_1 needs it to
59 * sign a request. 60 * sign a request.
@@ -100,6 +101,7 @@ TALER_TESTING_get_trait_peer_key_pub
100 index); 101 index);
101} 102}
102 103
104
103/** 105/**
104 * Offer public key. 106 * Offer public key.
105 * 107 *
diff --git a/src/lib/testing_api_trait_number.c b/src/lib/testing_api_trait_number.c
index b2c545457..ff7741650 100644
--- a/src/lib/testing_api_trait_number.c
+++ b/src/lib/testing_api_trait_number.c
@@ -73,6 +73,7 @@ TALER_TESTING_make_trait_uint
73 return ret; 73 return ret;
74} 74}
75 75
76
76/** 77/**
77 * Obtain a "number" value from @a cmd, 64-bit version. 78 * Obtain a "number" value from @a cmd, 64-bit version.
78 * 79 *
@@ -94,6 +95,7 @@ TALER_TESTING_get_trait_uint64
94 index); 95 index);
95} 96}
96 97
98
97/** 99/**
98 * Offer number trait, 64-bit version. 100 * Offer number trait, 64-bit version.
99 * 101 *
@@ -113,4 +115,5 @@ TALER_TESTING_make_trait_uint64
113 return ret; 115 return ret;
114} 116}
115 117
118
116/* end of testing_api_trait_number.c */ 119/* end of testing_api_trait_number.c */
diff --git a/src/lib/testing_api_trait_process.c b/src/lib/testing_api_trait_process.c
index a35314ef3..5145ff5d8 100644
--- a/src/lib/testing_api_trait_process.c
+++ b/src/lib/testing_api_trait_process.c
@@ -80,4 +80,5 @@ TALER_TESTING_make_trait_process
80 return ret; 80 return ret;
81} 81}
82 82
83
83/* end of testing_api_trait_process.c */ 84/* end of testing_api_trait_process.c */
diff --git a/src/lib/testing_api_trait_reserve_priv.c b/src/lib/testing_api_trait_reserve_priv.c
index b920c43d9..8a60687fc 100644
--- a/src/lib/testing_api_trait_reserve_priv.c
+++ b/src/lib/testing_api_trait_reserve_priv.c
@@ -73,4 +73,5 @@ TALER_TESTING_make_trait_reserve_priv
73 return ret; 73 return ret;
74} 74}
75 75
76
76/* end of testing_api_trait_reserve_priv.c */ 77/* end of testing_api_trait_reserve_priv.c */
diff --git a/src/lib/testing_api_trait_string.c b/src/lib/testing_api_trait_string.c
index 606c6e0b6..8d3d5df04 100644
--- a/src/lib/testing_api_trait_string.c
+++ b/src/lib/testing_api_trait_string.c
@@ -57,6 +57,7 @@ TALER_TESTING_get_trait_contract_terms
57 index); 57 index);
58} 58}
59 59
60
60/** 61/**
61 * Offer contract terms. 62 * Offer contract terms.
62 * 63 *
@@ -100,6 +101,7 @@ TALER_TESTING_get_trait_transfer_subject
100 index); 101 index);
101} 102}
102 103
104
103/** 105/**
104 * Offer transfer subject. 106 * Offer transfer subject.
105 * 107 *
@@ -145,6 +147,7 @@ TALER_TESTING_get_trait_amount
145 index); 147 index);
146} 148}
147 149
150
148/** 151/**
149 * Offer amount in a trait. 152 * Offer amount in a trait.
150 * 153 *
@@ -190,6 +193,7 @@ TALER_TESTING_get_trait_url
190 index); 193 index);
191} 194}
192 195
196
193/** 197/**
194 * Offer url in a trait. 198 * Offer url in a trait.
195 * 199 *
@@ -235,6 +239,7 @@ TALER_TESTING_get_trait_order_id
235 index); 239 index);
236} 240}
237 241
242
238/** 243/**
239 * Offer order id in a trait. 244 * Offer order id in a trait.
240 * 245 *
@@ -257,6 +262,7 @@ TALER_TESTING_make_trait_order_id
257 return ret; 262 return ret;
258} 263}
259 264
265
260/** 266/**
261 * Obtain the reference to a "reject" CMD. Usually offered 267 * Obtain the reference to a "reject" CMD. Usually offered
262 * by _rejected_ bank transfers. 268 * by _rejected_ bank transfers.
@@ -280,6 +286,7 @@ TALER_TESTING_get_trait_rejected
280 index); 286 index);
281} 287}
282 288
289
283/** 290/**
284 * Offer a "reject" CMD reference. 291 * Offer a "reject" CMD reference.
285 * 292 *
@@ -302,4 +309,5 @@ TALER_TESTING_make_trait_rejected
302 return ret; 309 return ret;
303} 310}
304 311
312
305/* end of testing_api_trait_string.c */ 313/* end of testing_api_trait_string.c */
diff --git a/src/lib/testing_api_trait_time.c b/src/lib/testing_api_trait_time.c
index 0cd71ad94..316527d75 100644
--- a/src/lib/testing_api_trait_time.c
+++ b/src/lib/testing_api_trait_time.c
@@ -52,6 +52,7 @@ TALER_TESTING_get_trait_absolute_time
52 index); 52 index);
53} 53}
54 54
55
55/** 56/**
56 * Offer a absolute time. 57 * Offer a absolute time.
57 * 58 *
@@ -72,4 +73,5 @@ TALER_TESTING_make_trait_absolute_time
72 return ret; 73 return ret;
73} 74}
74 75
76
75/* end of testing_api_trait_time.c */ 77/* end of testing_api_trait_time.c */
diff --git a/src/lib/testing_api_trait_wtid.c b/src/lib/testing_api_trait_wtid.c
index 1353327af..81690f036 100644
--- a/src/lib/testing_api_trait_wtid.c
+++ b/src/lib/testing_api_trait_wtid.c
@@ -73,4 +73,5 @@ TALER_TESTING_make_trait_wtid
73 return ret; 73 return ret;
74} 74}
75 75
76
76/* end of testing_api_trait_number.c */ 77/* end of testing_api_trait_number.c */
diff --git a/src/lib/testing_api_traits.c b/src/lib/testing_api_traits.c
index 45e7668ee..703e14c8a 100644
--- a/src/lib/testing_api_traits.c
+++ b/src/lib/testing_api_traits.c
@@ -46,6 +46,7 @@ TALER_TESTING_trait_end ()
46 return end; 46 return end;
47} 47}
48 48
49
49/** 50/**
50 * Pick the chosen trait from the traits array. 51 * Pick the chosen trait from the traits array.
51 * 52 *
@@ -77,4 +78,5 @@ TALER_TESTING_get_trait (const struct TALER_TESTING_Trait *traits,
77 return GNUNET_SYSERR; 78 return GNUNET_SYSERR;
78} 79}
79 80
81
80/* end of testing_api_traits.c */ 82/* end of testing_api_traits.c */
diff --git a/src/lib/testing_auditor_api_cmd_exchanges.c b/src/lib/testing_auditor_api_cmd_exchanges.c
index 014441761..9cc07553d 100644
--- a/src/lib/testing_auditor_api_cmd_exchanges.c
+++ b/src/lib/testing_auditor_api_cmd_exchanges.c
@@ -335,6 +335,7 @@ TALER_TESTING_cmd_exchanges_with_url
335 return cmd; 335 return cmd;
336} 336}
337 337
338
338/** 339/**
339 * Modify an exchanges command to enable retries when we get 340 * Modify an exchanges command to enable retries when we get
340 * transient errors from the auditor. 341 * transient errors from the auditor.
diff --git a/src/lib/testing_auditor_api_cmd_exec_auditor.c b/src/lib/testing_auditor_api_cmd_exec_auditor.c
index afe9d38fc..cff234691 100644
--- a/src/lib/testing_auditor_api_cmd_exec_auditor.c
+++ b/src/lib/testing_auditor_api_cmd_exec_auditor.c
@@ -159,4 +159,5 @@ TALER_TESTING_cmd_exec_auditor (const char *label,
159 return cmd; 159 return cmd;
160} 160}
161 161
162
162/* end of testing_auditor_api_cmd_exec_auditor.c */ 163/* end of testing_auditor_api_cmd_exec_auditor.c */
diff --git a/src/lib/testing_auditor_api_cmd_exec_auditor_dbinit.c b/src/lib/testing_auditor_api_cmd_exec_auditor_dbinit.c
index 09771660c..3b7e3aa0b 100644
--- a/src/lib/testing_auditor_api_cmd_exec_auditor_dbinit.c
+++ b/src/lib/testing_auditor_api_cmd_exec_auditor_dbinit.c
@@ -160,4 +160,5 @@ TALER_TESTING_cmd_exec_auditor_dbinit (const char *label,
160 return cmd; 160 return cmd;
161} 161}
162 162
163
163/* end of testing_auditor_api_cmd_exec_auditor_dbinit.c */ 164/* end of testing_auditor_api_cmd_exec_auditor_dbinit.c */
diff --git a/src/lib/testing_auditor_api_cmd_exec_wire_auditor.c b/src/lib/testing_auditor_api_cmd_exec_wire_auditor.c
index 8371f9690..744420d3f 100644
--- a/src/lib/testing_auditor_api_cmd_exec_wire_auditor.c
+++ b/src/lib/testing_auditor_api_cmd_exec_wire_auditor.c
@@ -159,4 +159,5 @@ TALER_TESTING_cmd_exec_wire_auditor (const char *label,
159 return cmd; 159 return cmd;
160} 160}
161 161
162
162/* end of testing_auditor_api_cmd_exec_wire_auditor.c */ 163/* end of testing_auditor_api_cmd_exec_wire_auditor.c */
diff --git a/src/lib/testing_auditor_api_helpers.c b/src/lib/testing_auditor_api_helpers.c
index 59b0e05de..cf15131da 100644
--- a/src/lib/testing_auditor_api_helpers.c
+++ b/src/lib/testing_auditor_api_helpers.c
@@ -70,6 +70,7 @@ cleanup_auditor (void *cls)
70 GNUNET_free (cc); 70 GNUNET_free (cc);
71} 71}
72 72
73
73/** 74/**
74 * Closure for #auditor_main_wrapper() 75 * Closure for #auditor_main_wrapper()
75 */ 76 */
@@ -122,6 +123,7 @@ auditor_version_cb
122 is->auditor_working = GNUNET_YES; 123 is->auditor_working = GNUNET_YES;
123} 124}
124 125
126
125/** 127/**
126 * Setup the @a is 'auditor' member before running the main test loop. 128 * Setup the @a is 'auditor' member before running the main test loop.
127 * 129 *
@@ -227,5 +229,4 @@ TALER_TESTING_AUDITOR_setup (TALER_TESTING_Main main_cb,
227} 229}
228 230
229 231
230
231/* end of testing_auditor_api_helpers.c */ 232/* end of testing_auditor_api_helpers.c */
diff --git a/src/util/crypto.c b/src/util/crypto.c
index b21397914..077f049eb 100644
--- a/src/util/crypto.c
+++ b/src/util/crypto.c
@@ -213,8 +213,7 @@ patch_private_key (struct GNUNET_CRYPTO_EddsaPrivateKey *pk)
213 * Is it worth also adding a test case that runs gcry_pk_testkey on 213 * Is it worth also adding a test case that runs gcry_pk_testkey on
214 * this key after first parsing it into libgcrypt's s-expression mess 214 * this key after first parsing it into libgcrypt's s-expression mess
215 * ala decode_private_eddsa_key from gnunet/src/util/crypto_ecc.c? 215 * ala decode_private_eddsa_key from gnunet/src/util/crypto_ecc.c?
216 * It'd run check_secret_key but not test_keys from libgcrypt/cipher/ecc.c */ 216 * It'd run check_secret_key but not test_keys from libgcrypt/cipher/ecc.c */}
217}
218 217
219 218
220/** 219/**
diff --git a/src/util/test_amount.c b/src/util/test_amount.c
index a8b37823c..d9110eaf8 100644
--- a/src/util/test_amount.c
+++ b/src/util/test_amount.c
@@ -238,4 +238,5 @@ main (int argc,
238 return 0; 238 return 0;
239} 239}
240 240
241
241/* end of test_amount.c */ 242/* end of test_amount.c */
diff --git a/src/util/test_crypto.c b/src/util/test_crypto.c
index c3c7b957c..e19a5f5e8 100644
--- a/src/util/test_crypto.c
+++ b/src/util/test_crypto.c
@@ -134,4 +134,5 @@ main (int argc,
134 return 0; 134 return 0;
135} 135}
136 136
137
137/* end of test_crypto.c */ 138/* end of test_crypto.c */
diff --git a/src/util/test_url.c b/src/util/test_url.c
index da43f81ac..5fc47137c 100644
--- a/src/util/test_url.c
+++ b/src/util/test_url.c
@@ -84,4 +84,5 @@ main (int argc,
84 return 0; 84 return 0;
85} 85}
86 86
87
87/* end of test_url.c */ 88/* end of test_url.c */
diff --git a/src/util/util.c b/src/util/util.c
index 3cc494fad..42977a16c 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -93,8 +93,6 @@ TALER_config_get_denom (const struct GNUNET_CONFIGURATION_Handle *cfg,
93} 93}
94 94
95 95
96
97
98/** 96/**
99 * Set an option with an amount from the command line. A pointer to 97 * Set an option with an amount from the command line. A pointer to
100 * this function should be passed as part of the 'struct 98 * this function should be passed as part of the 'struct
@@ -193,6 +191,7 @@ is_reserved (char c)
193 return GNUNET_YES; 191 return GNUNET_YES;
194} 192}
195 193
194
196/** 195/**
197 * Get the length of a string after it has been 196 * Get the length of a string after it has been
198 * urlencoded. 197 * urlencoded.
@@ -210,6 +209,7 @@ urlencode_len (const char *s)
210 return len; 209 return len;
211} 210}
212 211
212
213/** 213/**
214 * URL-encode a string according to rfc3986. 214 * URL-encode a string according to rfc3986.
215 * 215 *
@@ -748,4 +748,5 @@ TALER_buffer_write_vfstr (struct TALER_Buffer *buf,
748 GNUNET_assert (buf->position <= buf->capacity); 748 GNUNET_assert (buf->position <= buf->capacity);
749} 749}
750 750
751
751/* end of util.c */ 752/* end of util.c */
diff --git a/src/wire-plugins/plugin_wire_ebics.c b/src/wire-plugins/plugin_wire_ebics.c
index 1c74efd54..d51b4567e 100644
--- a/src/wire-plugins/plugin_wire_ebics.c
+++ b/src/wire-plugins/plugin_wire_ebics.c
@@ -272,7 +272,6 @@ ebics_get_history_cancel (void *cls,
272} 272}
273 273
274 274
275
276/** 275/**
277 * Context for a rejection operation. 276 * Context for a rejection operation.
278 */ 277 */
@@ -444,4 +443,5 @@ libtaler_plugin_wire_ebics_done (void *cls)
444 return NULL; 443 return NULL;
445} 444}
446 445
446
447/* end of plugin_wire_ebics.c */ 447/* end of plugin_wire_ebics.c */
diff --git a/src/wire-plugins/plugin_wire_taler-bank.c b/src/wire-plugins/plugin_wire_taler-bank.c
index eed57cb97..b468496a8 100644
--- a/src/wire-plugins/plugin_wire_taler-bank.c
+++ b/src/wire-plugins/plugin_wire_taler-bank.c
@@ -999,8 +999,7 @@ taler_bank_get_history (void *cls,
999 * Probably something is wrong with the DB, some 999 * Probably something is wrong with the DB, some
1000 * other component wrote a wrong value to it. Instead 1000 * other component wrote a wrong value to it. Instead
1001 * of completely stopping to work, we just scan from the 1001 * of completely stopping to work, we just scan from the
1002 * beginning. */ 1002 * beginning. */start_off = NULL;
1003 start_off = NULL;
1004 } 1003 }
1005 if (NULL == start_off) 1004 if (NULL == start_off)
1006 { 1005 {
@@ -1300,4 +1299,5 @@ libtaler_plugin_wire_taler_bank_done (void *cls)
1300 return NULL; 1299 return NULL;
1301} 1300}
1302 1301
1302
1303/* end of plugin_wire_taler-bank.c */ 1303/* end of plugin_wire_taler-bank.c */
diff --git a/src/wire-plugins/plugin_wire_template.c b/src/wire-plugins/plugin_wire_template.c
index 29c4553aa..731885ac6 100644
--- a/src/wire-plugins/plugin_wire_template.c
+++ b/src/wire-plugins/plugin_wire_template.c
@@ -380,4 +380,5 @@ libtaler_plugin_wire_template_done (void *cls)
380 return NULL; 380 return NULL;
381} 381}
382 382
383
383/* end of plugin_wire_template.c */ 384/* end of plugin_wire_template.c */
diff --git a/src/wire-plugins/test_wire_plugin_transactions_taler-bank.c b/src/wire-plugins/test_wire_plugin_transactions_taler-bank.c
index fa0db5b41..79700818e 100644
--- a/src/wire-plugins/test_wire_plugin_transactions_taler-bank.c
+++ b/src/wire-plugins/test_wire_plugin_transactions_taler-bank.c
@@ -361,4 +361,5 @@ main (int argc,
361 return 0; 361 return 0;
362} 362}
363 363
364
364/* end of test_wire_plugin_transactions_taler-bank.c */ 365/* end of test_wire_plugin_transactions_taler-bank.c */
diff --git a/src/wire/payto.c b/src/wire/payto.c
index 5e762a864..741549772 100644
--- a/src/wire/payto.c
+++ b/src/wire/payto.c
@@ -526,4 +526,5 @@ TALER_WIRE_payto_to_account (const char *payto_url,
526 return TALER_EC_PAYTO_WRONG_METHOD; 526 return TALER_EC_PAYTO_WRONG_METHOD;
527} 527}
528 528
529
529/* end of payto.c */ 530/* end of payto.c */
diff --git a/src/wire/wire_helper.c b/src/wire/wire_helper.c
index e5ca8b168..76336f7d0 100644
--- a/src/wire/wire_helper.c
+++ b/src/wire/wire_helper.c
@@ -103,4 +103,5 @@ TALER_WIRE_get_plugin_from_method (const char *method)
103 return NULL; 103 return NULL;
104} 104}
105 105
106
106/* end of wire_helper.c */ 107/* end of wire_helper.c */