summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Dold <florian.dold@gmail.com>2020-01-18 20:03:54 +0100
committerFlorian Dold <florian.dold@gmail.com>2020-01-18 20:04:03 +0100
commit34e6425f9d01dd60ee014097f938c6fb65d9a35b (patch)
tree136a0bd9133046dedb227795500b550876ce47cf
parent6bdccb5c7bfa6728d7227e19b26f1bc9a0849fb3 (diff)
downloadexchange-34e6425f9d01dd60ee014097f938c6fb65d9a35b.tar.gz
exchange-34e6425f9d01dd60ee014097f938c6fb65d9a35b.tar.bz2
exchange-34e6425f9d01dd60ee014097f938c6fb65d9a35b.zip
doxygen fixes / redundant parameter elimination
-rw-r--r--src/include/taler_bank_service.h4
-rw-r--r--src/include/taler_testing_lib.h6
-rw-r--r--src/lib/testing_api_cmd_bank_admin_add_incoming.c8
-rw-r--r--src/lib/testing_api_cmd_withdraw.c4
-rw-r--r--src/lib/testing_api_helpers_bank.c1
5 files changed, 4 insertions, 19 deletions
diff --git a/src/include/taler_bank_service.h b/src/include/taler_bank_service.h
index dda338404..4b2aca664 100644
--- a/src/include/taler_bank_service.h
+++ b/src/include/taler_bank_service.h
@@ -165,7 +165,7 @@ TALER_BANK_admin_add_incoming_cancel (struct
/**
* Prepare for exeuction of a wire transfer.
*
- * @param destination_account_uri payto:// URL identifying where to send the money
+ * @param destination_account_payto_uri payto:// URL identifying where to send the money
* @param amount amount to transfer, already rounded
* @param exchange_base_url base URL of this exchange (included in subject
* to facilitate use of tracking API by merchant backend)
@@ -426,9 +426,7 @@ typedef int
* Request the wire credit history of an exchange's bank account.
*
* @param ctx curl context for the event loop
- * @param bank_base_url URL of the base INCLUDING account number
* @param auth authentication data to use
- * @param account_number which account number should we query
* @param start_row from which row on do we want to get results, use UINT64_MAX for the latest; exclusive
* @param num_results how many results do we want; negative numbers to go into the past,
* positive numbers to go into the future starting at @a start_row;
diff --git a/src/include/taler_testing_lib.h b/src/include/taler_testing_lib.h
index c90991ac4..02fd929ce 100644
--- a/src/include/taler_testing_lib.h
+++ b/src/include/taler_testing_lib.h
@@ -1024,8 +1024,6 @@ TALER_TESTING_cmd_admin_add_incoming (const char *label,
*
* @param label command label.
* @param amount the amount to transfer.
- * @param account_base_url base URL of the account that implements this
- * wire transer (which account receives money).
* @param payto_debit_account which account sends money.
* @param auth authentication data
* @param ref reference to a command that can offer a reserve
@@ -1035,7 +1033,6 @@ TALER_TESTING_cmd_admin_add_incoming (const char *label,
struct TALER_TESTING_Command
TALER_TESTING_cmd_admin_add_incoming_with_ref (const char *label,
const char *amount,
- const char *account_base_url,
const struct
TALER_BANK_AuthenticationData *
auth,
@@ -1052,8 +1049,6 @@ TALER_TESTING_cmd_admin_add_incoming_with_ref (const char *label,
*
* @param label command label.
* @param amount amount to transfer.
- * @param account_base_url base URL of the account that implements this
- * wire transer (which account receives money).
* @param payto_debit_account which account sends money.
* @param auth authentication data
* @param instance the instance that runs the tipping. Under this
@@ -1066,7 +1061,6 @@ TALER_TESTING_cmd_admin_add_incoming_with_ref (const char *label,
struct TALER_TESTING_Command
TALER_TESTING_cmd_admin_add_incoming_with_instance (const char *label,
const char *amount,
- const char *account_base_url,
const struct
TALER_BANK_AuthenticationData
*auth,
diff --git a/src/lib/testing_api_cmd_bank_admin_add_incoming.c b/src/lib/testing_api_cmd_bank_admin_add_incoming.c
index 294c933e1..d351081ad 100644
--- a/src/lib/testing_api_cmd_bank_admin_add_incoming.c
+++ b/src/lib/testing_api_cmd_bank_admin_add_incoming.c
@@ -521,7 +521,6 @@ struct TALER_TESTING_Command
TALER_TESTING_cmd_admin_add_incoming_with_ref
(const char *label,
const char *amount,
- const char *account_base_url,
const struct TALER_BANK_AuthenticationData *auth,
const char *payto_debit_account,
const char *ref)
@@ -529,7 +528,7 @@ TALER_TESTING_cmd_admin_add_incoming_with_ref
struct AdminAddIncomingState *fts;
fts = make_fts (amount,
- account_base_url,
+ auth->wire_gateway_url,
auth,
payto_debit_account);
fts->reserve_reference = ref;
@@ -547,8 +546,6 @@ TALER_TESTING_cmd_admin_add_incoming_with_ref
*
* @param label command label.
* @param amount amount to transfer.
- * @param account_bank_url base URL of the exchange bank account
- * that receives the wire transfer
* @param payto_debit_account which account (expressed as a number)
* gives money
* @param auth authentication data
@@ -563,7 +560,6 @@ struct TALER_TESTING_Command
TALER_TESTING_cmd_admin_add_incoming_with_instance
(const char *label,
const char *amount,
- const char *account_base_url,
const struct TALER_BANK_AuthenticationData *auth,
const char *payto_debit_account,
const char *instance,
@@ -572,7 +568,7 @@ TALER_TESTING_cmd_admin_add_incoming_with_instance
struct AdminAddIncomingState *fts;
fts = make_fts (amount,
- account_base_url,
+ auth->wire_gateway_url,
auth,
payto_debit_account);
fts->instance = instance;
diff --git a/src/lib/testing_api_cmd_withdraw.c b/src/lib/testing_api_cmd_withdraw.c
index 6494645ab..3a834c07b 100644
--- a/src/lib/testing_api_cmd_withdraw.c
+++ b/src/lib/testing_api_cmd_withdraw.c
@@ -233,10 +233,6 @@ reserve_withdraw_cb (void *cls,
/**
* Run the command.
- *
- * @param cls closure.
- * @param cmd the command being run, NULL when called from #do_retry()
- * @param is interpreter state.
*/
static void
withdraw_run (void *cls,
diff --git a/src/lib/testing_api_helpers_bank.c b/src/lib/testing_api_helpers_bank.c
index de4989272..c8a780ac6 100644
--- a/src/lib/testing_api_helpers_bank.c
+++ b/src/lib/testing_api_helpers_bank.c
@@ -219,6 +219,7 @@ TALER_TESTING_run_bank (const char *config_filename,
* and reset database.
*
* @param config_filename configuration file name.
+ * @param config_section section of the configuration with the exchange's account
* @param[out] bc set to the bank's configuration data
* @return the base url, or NULL upon errors. Must be freed
* by the caller.