From 081ffe994a6d39cbd332eefe6f58f8015154e4cb Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Wed, 4 Apr 2018 17:01:59 +0200
Subject: expand logging of HARD errors in DB reserve inserts

---
 src/exchange/taler-exchange-wirewatch.c     | 5 +++--
 src/exchangedb/plugin_exchangedb_postgres.c | 8 +++++++-
 2 files changed, 10 insertions(+), 3 deletions(-)

(limited to 'src')

diff --git a/src/exchange/taler-exchange-wirewatch.c b/src/exchange/taler-exchange-wirewatch.c
index e0985366d..f650690de 100644
--- a/src/exchange/taler-exchange-wirewatch.c
+++ b/src/exchange/taler-exchange-wirewatch.c
@@ -292,8 +292,8 @@ history_cb (void *cls,
   struct TALER_ReservePublicKeyP reserve_pub;
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Got history callback, direction %u!\n", (unsigned int) dir);
-
+              "Got history callback, direction %u!\n",
+              (unsigned int) dir);
   if (TALER_BANK_DIRECTION_NONE == dir)
   {
     hh = NULL;
@@ -308,6 +308,7 @@ history_cb (void *cls,
                 "End of list. Committing progress!\n");
     qs = db_plugin->commit (db_plugin->cls,
 			    session);
+    GNUNET_break (0 <= qs);
     if ( (GNUNET_YES == delay) &&
          (test_mode) )
     {
diff --git a/src/exchangedb/plugin_exchangedb_postgres.c b/src/exchangedb/plugin_exchangedb_postgres.c
index 6c6330556..63ed8874e 100644
--- a/src/exchangedb/plugin_exchangedb_postgres.c
+++ b/src/exchangedb/plugin_exchangedb_postgres.c
@@ -1912,7 +1912,10 @@ postgres_reserves_in_insert (void *cls,
 					     "reserve_create",
 					     params);
     if (0 > qs)
+    {
+      GNUNET_break (GNUNET_DB_STATUS_HARD_ERROR != qs);
       return qs;
+    }
     if (GNUNET_DB_STATUS_SUCCESS_NO_RESULTS == qs)
     {
       /* Maybe DB did not detect serializiability error already,
@@ -1938,7 +1941,10 @@ postgres_reserves_in_insert (void *cls,
 					     "reserves_in_add_transaction",
 					     params);
     if (GNUNET_DB_STATUS_SUCCESS_ONE_RESULT != qs)
+    {
+      GNUNET_break (GNUNET_DB_STATUS_HARD_ERROR != qs);
       return qs;
+    }
   }
 
   if (GNUNET_DB_STATUS_SUCCESS_ONE_RESULT == reserve_exists)
@@ -1957,7 +1963,7 @@ postgres_reserves_in_insert (void *cls,
                           balance))
     {
       /* currency overflow or incompatible currency */
-      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                   "Attempt to deposit incompatible amount into reserve\n");
       return GNUNET_DB_STATUS_HARD_ERROR;
     }
-- 
cgit v1.2.3