From bdaaa0f6cb8f99168ed9916064a5e4145426480c Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Fri, 19 Nov 2021 10:57:27 +0100
Subject: -fix misc. compiler warnings

---
 src/util/crypto_wire.c                 | 49 ----------------------------------
 src/util/taler-exchange-secmod-eddsa.c |  2 ++
 src/util/taler-exchange-secmod-rsa.c   |  1 +
 src/util/util.c                        |  9 -------
 4 files changed, 3 insertions(+), 58 deletions(-)

(limited to 'src/util')

diff --git a/src/util/crypto_wire.c b/src/util/crypto_wire.c
index 616ae410e..e1c7d9646 100644
--- a/src/util/crypto_wire.c
+++ b/src/util/crypto_wire.c
@@ -23,14 +23,6 @@
 #include "taler_signatures.h"
 
 
-/**
- * Check the signature in @a master_sig.
- *
- * @param payto_uri URL that is signed
- * @param master_pub master public key of the exchange
- * @param master_sig signature of the exchange
- * @return #GNUNET_OK if signature is valid
- */
 enum GNUNET_GenericReturnValue
 TALER_exchange_wire_signature_check (
   const char *payto_uri,
@@ -51,13 +43,6 @@ TALER_exchange_wire_signature_check (
 }
 
 
-/**
- * Create a signed wire statement for the given account.
- *
- * @param payto_uri account specification
- * @param master_priv private key to sign with
- * @param[out] master_sig where to write the signature
- */
 void
 TALER_exchange_wire_signature_make (
   const char *payto_uri,
@@ -77,15 +62,6 @@ TALER_exchange_wire_signature_make (
 }
 
 
-/**
- * Compute the hash of the given wire details.   The resulting
- * @a hc is what will be put into the contract between customer
- * and merchant for signing by both parties.
- *
- * @param payto_uri bank account
- * @param salt salt used to eliminate brute-force inversion
- * @param[out] hc set to the hash
- */
 void
 TALER_merchant_wire_signature_hash (const char *payto_uri,
                                     const struct TALER_WireSalt *salt,
@@ -104,23 +80,6 @@ TALER_merchant_wire_signature_hash (const char *payto_uri,
 }
 
 
-/**
- * Check the signature in @a merch_sig.
- * (Not yet used anywhere.)
- *
- * Expected to be used if/when we get @a merch_pub signed via
- * X.509 *and* have a way for the WebEx wallet to check that the
- * @a merch_pub provided matches that of the X.509 certificate
- * from the Web site. Until then, @a merch_pub cannto be
- * validated (no PKI), and hence there is no point in checking
- * these signatures. (See #5129 and #3946).
- *
- * @param payto_uri URL that is signed
- * @param salt the salt used to salt the @a payto_uri when hashing
- * @param merch_pub master public key of the merchant
- * @param merch_sig signature of the merchant
- * @return #GNUNET_OK if signature is valid
- */
 enum GNUNET_GenericReturnValue
 TALER_merchant_wire_signature_check (
   const char *payto_uri,
@@ -143,14 +102,6 @@ TALER_merchant_wire_signature_check (
 }
 
 
-/**
- * Create a signed wire statement for the given account. (Not yet used anywhere.)
- *
- * @param payto_uri account specification
- * @param salt the salt used to salt the @a payto_uri when hashing
- * @param merch_priv private key to sign with
- * @param[out] merch_sig where to write the signature
- */
 void
 TALER_merchant_wire_signature_make (
   const char *payto_uri,
diff --git a/src/util/taler-exchange-secmod-eddsa.c b/src/util/taler-exchange-secmod-eddsa.c
index 3b7ee3ded..a231c9f9a 100644
--- a/src/util/taler-exchange-secmod-eddsa.c
+++ b/src/util/taler-exchange-secmod-eddsa.c
@@ -419,6 +419,7 @@ handle_revoke_request (struct TES_Client *client,
   struct Key *key;
   struct Key *nkey;
 
+  (void) client;
   key = NULL;
   GNUNET_assert (0 == pthread_mutex_lock (&keys_lock));
   for (struct Key *pos = keys_head;
@@ -832,6 +833,7 @@ import_key (void *cls,
   int fd;
   struct stat sbuf;
 
+  (void) cls;
   {
     struct stat lsbuf;
 
diff --git a/src/util/taler-exchange-secmod-rsa.c b/src/util/taler-exchange-secmod-rsa.c
index 49121c70e..1a87c4cc1 100644
--- a/src/util/taler-exchange-secmod-rsa.c
+++ b/src/util/taler-exchange-secmod-rsa.c
@@ -561,6 +561,7 @@ handle_revoke_request (struct TES_Client *client,
   struct DenominationKey *ndk;
   struct Denomination *denom;
 
+  (void) client;
   GNUNET_assert (0 == pthread_mutex_lock (&keys_lock));
   dk = GNUNET_CONTAINER_multihashmap_get (keys,
                                           &rr->h_rsa.hash);
diff --git a/src/util/util.c b/src/util/util.c
index 19924b89a..274dad3cd 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -24,15 +24,6 @@
 #include "taler_util.h"
 
 
-/**
- * Convert a buffer to an 8-character string representative of the
- * contents. This is used for logging binary data when debugging.
- *
- * @param buf buffer to log
- * @param buf_size number of bytes in @a buf
- * @return text representation of buf, valid until next
- *         call to this function
- */
 const char *
 TALER_b2s (const void *buf,
            size_t buf_size)
-- 
cgit v1.2.3