From 292b6cf265ab2699c53796de1a2b89348202e184 Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Thu, 7 May 2015 14:01:26 +0200 Subject: note (theoretical) problem with 64 vs 63 bit integers --- src/pq/db_pq.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/pq') diff --git a/src/pq/db_pq.c b/src/pq/db_pq.c index 1decd3bbe..74126750b 100644 --- a/src/pq/db_pq.c +++ b/src/pq/db_pq.c @@ -176,6 +176,8 @@ TALER_PQ_exec_prepared (PGconn *db_conn, at_nbo = GNUNET_new (struct GNUNET_TIME_AbsoluteNBO); scratch[soff++] = at_nbo; + /* FIXME: this does not work for 'forever' as PQ uses 63-bit integers; + should check and handle! (Need testcase!) */ *at_nbo = GNUNET_TIME_absolute_hton (*at_hbo); param_values[off] = (void *) at_nbo; param_lengths[off] = sizeof (struct GNUNET_TIME_AbsoluteNBO); @@ -523,6 +525,8 @@ TALER_PQ_extract_result (PGresult *result, PQgetvalue (result, row, fnum); + /* FIXME: this does not work for 'forever' as PQ uses 63-bit integers; + should check and handle! (Need testcase!) */ *dst = GNUNET_TIME_absolute_ntoh (*res); break; } -- cgit v1.2.3