From 113f3891d13a15b87827a8b1b33508231a1409b7 Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Sun, 1 Mar 2020 17:51:46 +0100
Subject: removing dead code, using more named constants, checking return
 values better

---
 src/mhd/mhd_legal.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'src/mhd/mhd_legal.c')

diff --git a/src/mhd/mhd_legal.c b/src/mhd/mhd_legal.c
index f99289a2f..051c87e9c 100644
--- a/src/mhd/mhd_legal.c
+++ b/src/mhd/mhd_legal.c
@@ -403,7 +403,7 @@ load_terms (struct TALER_MHD_Legal *legal,
       GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
                                 "fstat",
                                 fn);
-      (void) close (fd);
+      GNUENT_break (0 == close (fd));
       GNUNET_free (fn);
       return;
     }
@@ -412,7 +412,7 @@ load_terms (struct TALER_MHD_Legal *legal,
       GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
                                 "fstat-size",
                                 fn);
-      (void) close (fd);
+      GNUNET_break (0 == close (fd));
       GNUNET_free (fn);
       return;
     }
@@ -427,7 +427,7 @@ load_terms (struct TALER_MHD_Legal *legal,
       {
         GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING,
                              "malloc");
-        (void) close (fd);
+        GNUNET_break (0 == close (fd));
         GNUNET_free (fn);
         return;
       }
@@ -440,12 +440,12 @@ load_terms (struct TALER_MHD_Legal *legal,
         GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_WARNING,
                                   "read",
                                   fn);
-        (void) close (fd);
+        GNUNET_break (0 == close (fd));
         GNUNET_free (buf);
         GNUNET_free (fn);
         return;
       }
-      (void) close (fd);
+      GNUNET_break (0 == close (fd));
       GNUNET_free (fn);
 
       /* append to global list of terms of service */
@@ -501,7 +501,7 @@ load_language (struct TALER_MHD_Legal *legal,
       continue;
     load_terms (legal, path, lang, fn);
   }
-  closedir (d);
+  GNUNET_break (0 == closedir (d));
   GNUNET_free (dname);
 }
 
@@ -577,7 +577,7 @@ TALER_MHD_legal_load (const struct GNUNET_CONFIGURATION_Handle *cfg,
       continue;
     load_language (legal, path, lang);
   }
-  closedir (d);
+  GNUNET_break (0 == closedir (d));
   GNUNET_free (path);
   return legal;
 }
-- 
cgit v1.2.3