From 7cf67b309465d7274457cdd12547daa836464fd9 Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Fri, 10 Jul 2020 21:27:06 +0200 Subject: this invariant does not actually hold, i.e. if there is a /recoup request for a coin we never saw --- src/exchangedb/exchangedb_transactions.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'src/exchangedb/exchangedb_transactions.c') diff --git a/src/exchangedb/exchangedb_transactions.c b/src/exchangedb/exchangedb_transactions.c index 11ed3ac77..39d5bfbb0 100644 --- a/src/exchangedb/exchangedb_transactions.c +++ b/src/exchangedb/exchangedb_transactions.c @@ -42,13 +42,11 @@ TALER_EXCHANGEDB_calculate_transaction_list_totals ( struct TALER_Amount refunded; struct TALER_Amount deposit_fee; bool have_refund; - bool have_deposit_or_melt_or_recoup; GNUNET_assert (GNUNET_OK == TALER_amount_get_zero (spent.currency, &refunded)); have_refund = false; - have_deposit_or_melt_or_recoup = false; for (struct TALER_EXCHANGEDB_TransactionList *pos = tl; NULL != pos; pos = pos->next) @@ -57,7 +55,6 @@ TALER_EXCHANGEDB_calculate_transaction_list_totals ( { case TALER_EXCHANGEDB_TT_DEPOSIT: /* spent += pos->amount_with_fee */ - have_deposit_or_melt_or_recoup = true; if (0 > TALER_amount_add (&spent, &spent, @@ -70,7 +67,6 @@ TALER_EXCHANGEDB_calculate_transaction_list_totals ( break; case TALER_EXCHANGEDB_TT_MELT: /* spent += pos->amount_with_fee */ - have_deposit_or_melt_or_recoup = true; if (0 > TALER_amount_add (&spent, &spent, @@ -112,7 +108,6 @@ TALER_EXCHANGEDB_calculate_transaction_list_totals ( } break; case TALER_EXCHANGEDB_TT_RECOUP: - have_deposit_or_melt_or_recoup = true; /* spent += pos->value */ if (0 > TALER_amount_add (&spent, @@ -157,7 +152,6 @@ TALER_EXCHANGEDB_calculate_transaction_list_totals ( GNUNET_break (0); return GNUNET_SYSERR; } - GNUNET_break (have_deposit_or_melt_or_recoup); *ret = spent; return GNUNET_OK; } -- cgit v1.2.3