From d821db366a9d2554c59e6450b352cddacd73b398 Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Fri, 30 Jul 2021 13:31:58 +0200
Subject: -fix misc enum confusions and other compiler warnings

---
 .../taler-exchange-httpd_management_post_keys.c    | 25 ++++++++++++----------
 1 file changed, 14 insertions(+), 11 deletions(-)

(limited to 'src/exchange/taler-exchange-httpd_management_post_keys.c')

diff --git a/src/exchange/taler-exchange-httpd_management_post_keys.c b/src/exchange/taler-exchange-httpd_management_post_keys.c
index 4fb65d414..0e4eb9894 100644
--- a/src/exchange/taler-exchange-httpd_management_post_keys.c
+++ b/src/exchange/taler-exchange-httpd_management_post_keys.c
@@ -336,7 +336,6 @@ TEH_handler_management_post_keys (
                            &signkey_sigs),
     GNUNET_JSON_spec_end ()
   };
-  enum GNUNET_DB_QueryStatus qs;
   bool ok;
   MHD_RESULT ret;
 
@@ -444,16 +443,20 @@ TEH_handler_management_post_keys (
               "Received %u denomination and %u signing key signatures\n",
               akc.nd_sigs,
               akc.ns_sigs);
-  qs = TEH_DB_run_transaction (connection,
-                               "add keys",
-                               &ret,
-                               &add_keys,
-                               &akc);
-  GNUNET_free (akc.d_sigs);
-  GNUNET_free (akc.s_sigs);
-  GNUNET_JSON_parse_free (spec);
-  if (qs < 0)
-    return ret;
+  {
+    enum GNUNET_GenericReturnValue res;
+
+    res = TEH_DB_run_transaction (connection,
+                                  "add keys",
+                                  &ret,
+                                  &add_keys,
+                                  &akc);
+    GNUNET_free (akc.d_sigs);
+    GNUNET_free (akc.s_sigs);
+    GNUNET_JSON_parse_free (spec);
+    if (GNUNET_SYSERR == res)
+      return ret;
+  }
   TEH_keys_update_states ();
   return TALER_MHD_reply_static (
     connection,
-- 
cgit v1.2.3