From d821db366a9d2554c59e6450b352cddacd73b398 Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Fri, 30 Jul 2021 13:31:58 +0200
Subject: -fix misc enum confusions and other compiler warnings

---
 ...exchange-httpd_management_auditors_AP_disable.c | 34 ++++++++++------------
 1 file changed, 15 insertions(+), 19 deletions(-)

(limited to 'src/exchange/taler-exchange-httpd_management_auditors_AP_disable.c')

diff --git a/src/exchange/taler-exchange-httpd_management_auditors_AP_disable.c b/src/exchange/taler-exchange-httpd_management_auditors_AP_disable.c
index 7fb022835..382b0f6b4 100644
--- a/src/exchange/taler-exchange-httpd_management_auditors_AP_disable.c
+++ b/src/exchange/taler-exchange-httpd_management_auditors_AP_disable.c
@@ -153,20 +153,16 @@ TEH_handler_management_auditors_AP_disable (
                                    &dac.validity_end),
     GNUNET_JSON_spec_end ()
   };
-  enum GNUNET_DB_QueryStatus qs;
   MHD_RESULT res;
-
-  {
-    enum GNUNET_GenericReturnValue res;
-
-    res = TALER_MHD_parse_json_data (connection,
-                                     root,
-                                     spec);
-    if (GNUNET_SYSERR == res)
-      return MHD_NO; /* hard failure */
-    if (GNUNET_NO == res)
-      return MHD_YES; /* failure */
-  }
+  enum GNUNET_GenericReturnValue ret;
+
+  ret = TALER_MHD_parse_json_data (connection,
+                                   root,
+                                   spec);
+  if (GNUNET_SYSERR == ret)
+    return MHD_NO;   /* hard failure */
+  if (GNUNET_NO == ret)
+    return MHD_YES;   /* failure */
   if (GNUNET_OK !=
       TALER_exchange_offline_auditor_del_verify (
         auditor_pub,
@@ -182,12 +178,12 @@ TEH_handler_management_auditors_AP_disable (
       NULL);
   }
 
-  qs = TEH_DB_run_transaction (connection,
-                               "del auditor",
-                               &res,
-                               &del_auditor,
-                               &dac);
-  if (qs < 0)
+  ret = TEH_DB_run_transaction (connection,
+                                "del auditor",
+                                &res,
+                                &del_auditor,
+                                &dac);
+  if (GNUNET_SYSERR == ret)
     return res;
   return TALER_MHD_reply_static (
     connection,
-- 
cgit v1.2.3