From 5e15bc6f285d42f31f48b63d0eaced6768b910c1 Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Sat, 13 Feb 2021 19:04:08 +0100
Subject: simplify logic

---
 src/exchange/taler-exchange-httpd_keys.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

(limited to 'src/exchange/taler-exchange-httpd_keys.c')

diff --git a/src/exchange/taler-exchange-httpd_keys.c b/src/exchange/taler-exchange-httpd_keys.c
index 6515bc3d8..910b47a6b 100644
--- a/src/exchange/taler-exchange-httpd_keys.c
+++ b/src/exchange/taler-exchange-httpd_keys.c
@@ -1640,6 +1640,7 @@ build_key_state (struct HelperState *hs,
         setup_key_helpers (ksh->helpers))
     {
       GNUNET_free (ksh->helpers);
+      GNUNET_assert (NULL == ksh->management_keys_reply);
       GNUNET_free (ksh);
       return NULL;
     }
@@ -1768,15 +1769,12 @@ get_key_state (bool management_only)
       GNUNET_break (0);
       if (NULL != ksh)
         destroy_key_state (ksh,
-                           (NULL == old_ksh));
+                           false);
       return NULL;
     }
-    if (NULL != old_ksh)
-    {
-      old_ksh->helpers = NULL;
-      destroy_key_state (old_ksh,
-                         false);
-    }
+    old_ksh->helpers = NULL;
+    destroy_key_state (old_ksh,
+                       false);
     return ksh;
   }
   sync_key_helpers (old_ksh->helpers);
-- 
cgit v1.2.3