From 783642272d83fae148edfd308c86b157c3e4a6d4 Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Tue, 9 May 2017 13:24:53 +0200
Subject: fix possible NULL deref, simplify logic

---
 src/bank-lib/fakebank.c | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

(limited to 'src/bank-lib')

diff --git a/src/bank-lib/fakebank.c b/src/bank-lib/fakebank.c
index f8edd082d..0359b4a4b 100644
--- a/src/bank-lib/fakebank.c
+++ b/src/bank-lib/fakebank.c
@@ -476,20 +476,15 @@ handle_history (struct TALER_FAKEBANK_Handle *h,
   }
   else
   {
-    if (NULL == h->transactions_head)
-    {
-      GNUNET_break (0);
-      return MHD_NO;
-    }
     for (pos = h->transactions_head;
-         pos->serial_id != start_number;
+         NULL != pos;
          pos = pos->next)
+      if (pos->serial_id == start_number)
+        break;
+    if (NULL == pos)
     {
-      if (NULL == pos)
-      {
-        GNUNET_break (0);
-        return MHD_NO;
-      }
+      GNUNET_break (0);
+      return MHD_NO;
     }
     /* range is exclusive, skip the matching entry */
     if (count > 0)
-- 
cgit v1.2.3