From 80660f2d882391118d7ad41f73d495d3f84e2244 Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Mon, 19 Dec 2022 14:13:55 +0100 Subject: return 204 on empty transaction history, as per API --- src/bank-lib/fakebank.c | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) (limited to 'src/bank-lib/fakebank.c') diff --git a/src/bank-lib/fakebank.c b/src/bank-lib/fakebank.c index b3d3250a1..810290417 100644 --- a/src/bank-lib/fakebank.c +++ b/src/bank-lib/fakebank.c @@ -2312,14 +2312,21 @@ handle_debit_history (struct TALER_FAKEBANK_Handle *h, pos = t; } } + if (0 == ha.delta) + { + GNUNET_log (GNUNET_ERROR_TYPE_INFO, + "No debit transactions exist after given starting point\n"); + return TALER_MHD_reply_static (connection, + MHD_HTTP_NO_CONTENT, + NULL, + NULL, + 0); + } if (NULL != pos) GNUNET_log (GNUNET_ERROR_TYPE_INFO, "Returning %lld debit transactions starting (inclusive) from %llu\n", (long long) ha.delta, (unsigned long long) pos->row_id); - else - GNUNET_log (GNUNET_ERROR_TYPE_INFO, - "No debit transactions exist after given starting point\n"); while ( (0 != ha.delta) && (NULL != pos) ) { @@ -2525,14 +2532,21 @@ handle_credit_history (struct TALER_FAKEBANK_Handle *h, pos = t; } } + if (0 == ha.delta) + { + GNUNET_log (GNUNET_ERROR_TYPE_INFO, + "No credit transactions exist after given starting point\n"); + return TALER_MHD_reply_static (connection, + MHD_HTTP_NO_CONTENT, + NULL, + NULL, + 0); + } if (NULL != pos) GNUNET_log (GNUNET_ERROR_TYPE_INFO, "Returning %lld credit transactions starting (inclusive) from %llu\n", (long long) ha.delta, (unsigned long long) pos->row_id); - else - GNUNET_log (GNUNET_ERROR_TYPE_INFO, - "No credit transactions exist after given starting point\n"); while ( (0 != ha.delta) && (NULL != pos) ) { -- cgit v1.2.3