From 7ebdac0a8bccd6842382376653403cd3d82ffab0 Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Mon, 2 May 2022 20:51:34 +0200 Subject: -investigate FIXME --- src/exchangedb/plugin_exchangedb_postgres.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/exchangedb/plugin_exchangedb_postgres.c b/src/exchangedb/plugin_exchangedb_postgres.c index 644b9f5ca..aa4066e6f 100644 --- a/src/exchangedb/plugin_exchangedb_postgres.c +++ b/src/exchangedb/plugin_exchangedb_postgres.c @@ -2198,10 +2198,11 @@ prepare_statements (struct PostgresClosure *pg) ",amount_frac" ",recoup_timestamp" ",recoup_uuid" - " FROM recoup" - // FIXME: suboptimal sub-query here: crosses shards! - // MAYBE: replace reserve_out_serial_id with - // reserve_pub and use new reserve_out_by_reserve table? + " FROM recoup rcp" + /* NOTE: suboptimal JOIN follows: crosses shards! + Could theoretically be improved via a materialized + index. But likely not worth it (query is rare and + number of reserve shards might be limited) */ " JOIN reserves_out ro" " USING (reserve_out_serial_id)" " JOIN reserves" -- cgit v1.2.3