diff options
| author | Christian Grothoff <christian@grothoff.org> | 2020-07-10 21:27:06 +0200 |
|---|---|---|
| committer | Christian Grothoff <christian@grothoff.org> | 2020-07-10 21:27:06 +0200 |
| commit | 7cf67b309465d7274457cdd12547daa836464fd9 (patch) | |
| tree | f48d32ab36b41dbbe5c50a1fac1f3570b5a529c3 /src | |
| parent | af0a2c32a3592b3fe0a756ada1bf377c144a855b (diff) | |
| download | exchange-7cf67b309465d7274457cdd12547daa836464fd9.tar.gz exchange-7cf67b309465d7274457cdd12547daa836464fd9.tar.bz2 exchange-7cf67b309465d7274457cdd12547daa836464fd9.zip | |
this invariant does not actually hold, i.e. if there is a /recoup request for a coin we never saw
Diffstat (limited to 'src')
| -rw-r--r-- | src/exchangedb/exchangedb_transactions.c | 6 | ||||
| -rw-r--r-- | src/testing/test_exchange_api.c | 2 |
2 files changed, 1 insertions, 7 deletions
diff --git a/src/exchangedb/exchangedb_transactions.c b/src/exchangedb/exchangedb_transactions.c index 11ed3ac77..39d5bfbb0 100644 --- a/src/exchangedb/exchangedb_transactions.c +++ b/src/exchangedb/exchangedb_transactions.c @@ -42,13 +42,11 @@ TALER_EXCHANGEDB_calculate_transaction_list_totals ( struct TALER_Amount refunded; struct TALER_Amount deposit_fee; bool have_refund; - bool have_deposit_or_melt_or_recoup; GNUNET_assert (GNUNET_OK == TALER_amount_get_zero (spent.currency, &refunded)); have_refund = false; - have_deposit_or_melt_or_recoup = false; for (struct TALER_EXCHANGEDB_TransactionList *pos = tl; NULL != pos; pos = pos->next) @@ -57,7 +55,6 @@ TALER_EXCHANGEDB_calculate_transaction_list_totals ( { case TALER_EXCHANGEDB_TT_DEPOSIT: /* spent += pos->amount_with_fee */ - have_deposit_or_melt_or_recoup = true; if (0 > TALER_amount_add (&spent, &spent, @@ -70,7 +67,6 @@ TALER_EXCHANGEDB_calculate_transaction_list_totals ( break; case TALER_EXCHANGEDB_TT_MELT: /* spent += pos->amount_with_fee */ - have_deposit_or_melt_or_recoup = true; if (0 > TALER_amount_add (&spent, &spent, @@ -112,7 +108,6 @@ TALER_EXCHANGEDB_calculate_transaction_list_totals ( } break; case TALER_EXCHANGEDB_TT_RECOUP: - have_deposit_or_melt_or_recoup = true; /* spent += pos->value */ if (0 > TALER_amount_add (&spent, @@ -157,7 +152,6 @@ TALER_EXCHANGEDB_calculate_transaction_list_totals ( GNUNET_break (0); return GNUNET_SYSERR; } - GNUNET_break (have_deposit_or_melt_or_recoup); *ret = spent; return GNUNET_OK; } diff --git a/src/testing/test_exchange_api.c b/src/testing/test_exchange_api.c index 7912041da..b8ec36996 100644 --- a/src/testing/test_exchange_api.c +++ b/src/testing/test_exchange_api.c @@ -675,7 +675,7 @@ run (void *cls, "recoup-reveal-coin-1b", "recoup-melt-coin-1b", "EUR:5"), -#if FIXME +#if 1 /* "over-spend" 10 EUR recoup-refreshed coin */ TALER_TESTING_cmd_deposit ("recoup-refresh-deposit-failing", "recoup-withdraw-coin-1b", |