summaryrefslogtreecommitdiff
path: root/src/mint/taler-mint-httpd_deposit.c
diff options
context:
space:
mode:
authorChristian Grothoff <christian@grothoff.org>2015-01-16 15:14:18 +0100
committerChristian Grothoff <christian@grothoff.org>2015-01-16 15:14:18 +0100
commit3553e60733e4ad2c71a3daa4148182443958dd04 (patch)
tree1e459582f8e01a7cfca4e52f9d1aa82db327d3cd /src/mint/taler-mint-httpd_deposit.c
parent17865db5fc19e768200fabee5aa173106d96507b (diff)
downloadexchange-3553e60733e4ad2c71a3daa4148182443958dd04.tar.gz
exchange-3553e60733e4ad2c71a3daa4148182443958dd04.tar.bz2
exchange-3553e60733e4ad2c71a3daa4148182443958dd04.zip
remarks on deposit issues
Diffstat (limited to 'src/mint/taler-mint-httpd_deposit.c')
-rw-r--r--src/mint/taler-mint-httpd_deposit.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/mint/taler-mint-httpd_deposit.c b/src/mint/taler-mint-httpd_deposit.c
index eaced51c2..7c19e060e 100644
--- a/src/mint/taler-mint-httpd_deposit.c
+++ b/src/mint/taler-mint-httpd_deposit.c
@@ -44,6 +44,7 @@
* @param deposit deposit request to confirm
* @return MHD result code
*/
+// FIXME: this should be in taler-mint-httpd_responses.c
static int
helper_deposit_send_response_success (struct MHD_Connection *connection,
struct Deposit *deposit)
@@ -108,7 +109,7 @@ TALER_MINT_handler_deposit (struct RequestHandler *rh,
wire = NULL;
resp = NULL;
if (-1 == json_unpack (json,
- "{s:s s:o}",
+ "{s:s, s:o}",
"type", &deposit_type,
"wire", &wire))
{
@@ -117,7 +118,7 @@ TALER_MINT_handler_deposit (struct RequestHandler *rh,
resp_code = MHD_HTTP_BAD_REQUEST;
goto EXITIF_exit;
}
- if (NULL == (wire_enc = json_dumps (wire, JSON_COMPACT|JSON_SORT_KEYS)))
+ if (NULL == (wire_enc = json_dumps (wire, JSON_COMPACT | JSON_SORT_KEYS)))
{
GNUNET_break_op (0);
resp = json_pack ("{s:s}", "error", "Bad format");
@@ -130,6 +131,8 @@ TALER_MINT_handler_deposit (struct RequestHandler *rh,
do { \
if (cond) { GNUNET_break (0); goto EXITIF_exit; } \
} while (0)
+ // FIXME: need to distinguish between _OK and _NO return values here,
+ // and never try to queue our own!
#define PARSE_DATA(field, addr) \
EXITIF (GNUNET_OK != \
GNUNET_MINT_parse_navigate_json \