summaryrefslogtreecommitdiff
path: root/src/lib
diff options
context:
space:
mode:
authorChristian Grothoff <christian@grothoff.org>2020-01-18 17:53:47 +0100
committerChristian Grothoff <christian@grothoff.org>2020-01-18 17:53:54 +0100
commitc5c04cb51fddba5ec8a0371155b50145810a92cb (patch)
treefb6f248cd364e868e2ffcf76ed0be5ad3d17e291 /src/lib
parent0f214150db9fbfe737e451e2ea78000ec175ebab (diff)
downloadexchange-c5c04cb51fddba5ec8a0371155b50145810a92cb.tar.gz
exchange-c5c04cb51fddba5ec8a0371155b50145810a92cb.tar.bz2
exchange-c5c04cb51fddba5ec8a0371155b50145810a92cb.zip
fix -Wextra warnings
Diffstat (limited to 'src/lib')
-rw-r--r--src/lib/auditor_api_handle.c3
-rw-r--r--src/lib/exchange_api_handle.c1
-rw-r--r--src/lib/exchange_api_refresh.c6
-rw-r--r--src/lib/testing_api_cmd_refresh.c25
4 files changed, 17 insertions, 18 deletions
diff --git a/src/lib/auditor_api_handle.c b/src/lib/auditor_api_handle.c
index d38de34f..e1e1cd4f 100644
--- a/src/lib/auditor_api_handle.c
+++ b/src/lib/auditor_api_handle.c
@@ -195,14 +195,12 @@ free_version_info (struct TALER_AUDITOR_VersionInformation *vi)
* in the @a key_data.
*
* @param[in] resp_obj JSON object to parse
- * @param check_sig #GNUNET_YES if we should check the signature
* @param[out] vi where to store the results we decoded
* @param[out] vc where to store version compatibility data
* @return #GNUNET_OK on success, #GNUNET_SYSERR on error (malformed JSON)
*/
static int
decode_version_json (const json_t *resp_obj,
- int check_sig,
struct TALER_AUDITOR_VersionInformation *vi,
enum TALER_AUDITOR_VersionCompatibility *vc)
{
@@ -313,7 +311,6 @@ version_completed_cb (void *cls,
}
if (GNUNET_OK !=
decode_version_json (resp_obj,
- GNUNET_YES,
&auditor->vi,
&vc))
{
diff --git a/src/lib/exchange_api_handle.c b/src/lib/exchange_api_handle.c
index 9ee64c4c..ed05558f 100644
--- a/src/lib/exchange_api_handle.c
+++ b/src/lib/exchange_api_handle.c
@@ -278,6 +278,7 @@ TEAH_acc_confirmation_cb (void *cls,
struct TEAH_AuditorInteractionEntry *aie = cls;
struct TEAH_AuditorListEntry *ale = aie->ale;
+ (void) json;
if (MHD_HTTP_OK != http_status)
{
GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
diff --git a/src/lib/exchange_api_refresh.c b/src/lib/exchange_api_refresh.c
index adcc65e1..e097ee3f 100644
--- a/src/lib/exchange_api_refresh.c
+++ b/src/lib/exchange_api_refresh.c
@@ -657,9 +657,7 @@ deserialize_melt_data (const char *buf,
* to #TALER_EXCHANGE_refresh_melt() that will generate the request.
*
* This function does verify that the given request data is internally
- * consistent. However, the @a melts_sigs are only verified if
- * @a check_sigs is set to #GNUNET_YES, as this may be relatively
- * expensive and should be redundant.
+ * consistent. However, the @a melts_sigs are NOT verified.
*
* Aside from some non-trivial cryptographic operations that might
* take a bit of CPU time to complete, this function returns
@@ -675,7 +673,6 @@ deserialize_melt_data (const char *buf,
* @param melt_pk denomination key information
* record corresponding to the @a melt_sig
* validity of the keys
- * @param check_sig verify the validity of the @a melt_sig signature
* @param fresh_pks_len length of the @a pks array
* @param fresh_pks array of @a pks_len denominations of fresh coins to create
* @param[out] res_size set to the size of the return value, or 0 on error
@@ -693,7 +690,6 @@ TALER_EXCHANGE_refresh_prepare (const struct
TALER_DenominationSignature *melt_sig,
const struct
TALER_EXCHANGE_DenomPublicKey *melt_pk,
- int check_sig,
unsigned int fresh_pks_len,
const struct
TALER_EXCHANGE_DenomPublicKey *fresh_pks,
diff --git a/src/lib/testing_api_cmd_refresh.c b/src/lib/testing_api_cmd_refresh.c
index c4dcc3c6..a490acc3 100644
--- a/src/lib/testing_api_cmd_refresh.c
+++ b/src/lib/testing_api_cmd_refresh.c
@@ -989,14 +989,17 @@ refresh_melt_run (void *cls,
&fresh_pk->fee_withdraw));
rms->fresh_pks[i] = *fresh_pk;
/* Make a deep copy of the RSA key */
- rms->fresh_pks[i].key.rsa_public_key = GNUNET_CRYPTO_rsa_public_key_dup (
- fresh_pk->key.rsa_public_key);
+ rms->fresh_pks[i].key.rsa_public_key
+ = GNUNET_CRYPTO_rsa_public_key_dup (fresh_pk->key.rsa_public_key);
}
- rms->refresh_data = TALER_EXCHANGE_refresh_prepare
- (rms->melt_priv, &melt_amount, melt_sig,
- melt_denom_pub,
- GNUNET_YES, num_fresh_coins, rms->fresh_pks,
- &rms->refresh_data_length);
+ rms->refresh_data
+ = TALER_EXCHANGE_refresh_prepare (rms->melt_priv,
+ &melt_amount,
+ melt_sig,
+ melt_denom_pub,
+ num_fresh_coins,
+ rms->fresh_pks,
+ &rms->refresh_data_length);
if (NULL == rms->refresh_data)
{
@@ -1004,9 +1007,11 @@ refresh_melt_run (void *cls,
TALER_TESTING_interpreter_fail (rms->is);
return;
}
- rms->rmh = TALER_EXCHANGE_refresh_melt
- (is->exchange, rms->refresh_data_length,
- rms->refresh_data, &melt_cb, rms);
+ rms->rmh = TALER_EXCHANGE_refresh_melt (is->exchange,
+ rms->refresh_data_length,
+ rms->refresh_data,
+ &melt_cb,
+ rms);
if (NULL == rms->rmh)
{