summaryrefslogtreecommitdiff
path: root/src/auditordb/plugin_auditordb_postgres.c
diff options
context:
space:
mode:
authorMarcello Stanisci <stanisci.m@gmail.com>2020-01-15 12:34:54 +0100
committerMarcello Stanisci <stanisci.m@gmail.com>2020-01-15 12:36:09 +0100
commite77ccd03906bd2db068136bb383976f714b3289e (patch)
treedef5c8ea374dd0b6867225ce9898bfef1e03fe02 /src/auditordb/plugin_auditordb_postgres.c
parent4547bfb318bfad96b12694dd93a50f50717478b6 (diff)
downloadexchange-e77ccd03906bd2db068136bb383976f714b3289e.tar.gz
exchange-e77ccd03906bd2db068136bb383976f714b3289e.tar.bz2
exchange-e77ccd03906bd2db068136bb383976f714b3289e.zip
Preflight checks:
put preflight check inside exchangedb start() function, and provide a preflight method for auditordb.
Diffstat (limited to 'src/auditordb/plugin_auditordb_postgres.c')
-rw-r--r--src/auditordb/plugin_auditordb_postgres.c41
1 files changed, 41 insertions, 0 deletions
diff --git a/src/auditordb/plugin_auditordb_postgres.c b/src/auditordb/plugin_auditordb_postgres.c
index 7360258a..0d16011f 100644
--- a/src/auditordb/plugin_auditordb_postgres.c
+++ b/src/auditordb/plugin_auditordb_postgres.c
@@ -62,6 +62,8 @@ struct TALER_AUDITORDB_Session
* Postgres connection handle.
*/
struct GNUNET_PQ_Context *conn;
+
+ const char *transaction_name;
};
@@ -1012,6 +1014,43 @@ postgres_get_session (void *cls)
return session;
}
+/**
+ * Do a pre-flight check that we are not in an uncommitted transaction.
+ * If we are, try to commit the previous transaction and output a warning.
+ * Does not return anything, as we will continue regardless of the outcome.
+ *
+ * @param cls the `struct PostgresClosure` with the plugin-specific state
+ * @param session the database connection
+ */
+static void
+postgres_preflight (void *cls,
+ struct TALER_AUDITORDB_Session *session)
+{
+ struct GNUNET_PQ_ExecuteStatement es[] = {
+ GNUNET_PQ_make_execute ("ROLLBACK"),
+ GNUNET_PQ_EXECUTE_STATEMENT_END
+ };
+
+ (void) cls;
+ if (NULL == session->transaction_name)
+ return; /* all good */
+ if (GNUNET_OK ==
+ GNUNET_PQ_exec_statements (session->conn,
+ es))
+ {
+ GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+ "BUG: Preflight check committed transaction `%s'!\n",
+ session->transaction_name);
+ }
+ else
+ {
+ GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+ "BUG: Preflight check failed to commit transaction `%s'!\n",
+ session->transaction_name);
+ }
+ session->transaction_name = NULL;
+}
+
/**
* Start a transaction.
@@ -1029,6 +1068,8 @@ postgres_start (void *cls,
GNUNET_PQ_EXECUTE_STATEMENT_END
};
+ postgres_preflight (cls,
+ session);
(void) cls;
if (GNUNET_OK !=
GNUNET_PQ_exec_statements (session->conn,