From f349433ce1bb4edc398c969f16beb776638ec3eb Mon Sep 17 00:00:00 2001 From: Florian Dold Date: Thu, 16 Jan 2020 16:39:02 +0100 Subject: don't use '406 Not Acceptable', as that refers to content negotiation --- core/api-bank.rst | 2 +- core/api-wire.rst | 18 +----------------- 2 files changed, 2 insertions(+), 18 deletions(-) (limited to 'core') diff --git a/core/api-bank.rst b/core/api-bank.rst index 10eae9ad..79043be6 100644 --- a/core/api-bank.rst +++ b/core/api-bank.rst @@ -46,7 +46,7 @@ Withdrawing :status 200 OK: The withdrawal was correctly initiated, therefore the exchange received the payment. A `BankTalerWithdrawResponse` object is returned. - :status 406 Not Acceptable: the user does not have sufficient credit to fulfill their request. + :status 409 Conflict: the user does not have sufficient credit to fulfill their request. :status 404 Not Found: The exchange wire details did not point to any valid bank account. **Details** diff --git a/core/api-wire.rst b/core/api-wire.rst index c97beed4..9992be4c 100644 --- a/core/api-wire.rst +++ b/core/api-wire.rst @@ -52,8 +52,7 @@ Making Transactions :status 200 OK: The request has been correctly handled, so the funds have been transferred to the recipient's account. The body is a `TransactionResponse` - :status 400 Bad Request: The bank replies with a `BankError` object. - :status 406 Not Acceptable: The request had wrong currency; the bank replies with a `BankError` object. + :status 400 Bad Request: The bank replies with an `ErrorDetail` object. :status 409 Conflict: A transaction with the same ``transaction_uid`` but different transaction details has been submitted before. @@ -103,18 +102,6 @@ Making Transactions } - .. ts:def:: BankError - - interface BankError { - - // Human readable explanation of the failure. - error: string; - - // Numeric Taler error code (`TALER_ErrorCode`) - ec: number; - } - - -------------------------------- Querying the transaction history -------------------------------- @@ -168,7 +155,6 @@ Querying the transaction history **Response** :status 200 OK: JSON object whose field ``incoming_transactions`` is an array of type `IncomingBankTransaction`. - :status 204 No content: in case no records exist for the targeted user. .. ts:def:: IncomingBankTransaction @@ -241,8 +227,6 @@ Querying the transaction history :status 200 OK: JSON object whose field ``outgoing_transactions`` is an array of type `OutgoingBankTransaction`. - :status 204 No content: - in case no records exist for the query .. ts:def:: OutgoingBankTransaction -- cgit v1.2.3