From 2268e4b9c7de07f753dc817616e730766eacffe9 Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Fri, 13 Aug 2021 23:14:23 +0200 Subject: -comments for Florian --- merchant-spec/public-orders-get.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/merchant-spec/public-orders-get.ts b/merchant-spec/public-orders-get.ts index 130f53f5..ef9eee3f 100644 --- a/merchant-spec/public-orders-get.ts +++ b/merchant-spec/public-orders-get.ts @@ -63,6 +63,11 @@ function handlePublicOrdersGet(mos: MerchantOrderStore, req: Req): Resp { // Client is trying to get the order status of a claimed, // unpaid order. However, the client is not showing authentication. // + // CG-FIXME: Eh, nothing here suggests the order is _claimed_. + // The branch above is wrong, as an unclaimed order without + // requireClaimToken must not end up here! So I think + // we here need authMissing && !authOk in the branch above! + // // This can happen when the fulfillment URL includes the order ID, // and the storefront redirects the user to the backend QR code // page, because the order is not paid under the current session. -- cgit v1.2.3