From 9e84a26cb3d390a6ce051b75c892094fff233f92 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sat, 9 Feb 2019 17:30:33 +0100 Subject: worker: keep stdio after exit This addresses review comments from https://github.com/nodejs/node/pull/25871. Refs: https://github.com/nodejs/node/pull/25871 PR-URL: https://github.com/nodejs/node/pull/26017 Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum Reviewed-By: Colin Ihrig --- test/parallel/test-worker-safe-getters.js | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) (limited to 'test') diff --git a/test/parallel/test-worker-safe-getters.js b/test/parallel/test-worker-safe-getters.js index 23c8de7c7b..69856659a5 100644 --- a/test/parallel/test-worker-safe-getters.js +++ b/test/parallel/test-worker-safe-getters.js @@ -12,6 +12,8 @@ if (isMainThread) { stderr: true }); + const { stdin, stdout, stderr } = w; + w.on('exit', common.mustCall((code) => { assert.strictEqual(code, 0); @@ -21,17 +23,11 @@ if (isMainThread) { w.ref(); w.unref(); - // Although not browser specific, probably wise to - // make sure the stream getters don't throw either. - w.stdin; - w.stdout; - w.stderr; - // Sanity check. assert.strictEqual(w.threadId, -1); - assert.strictEqual(w.stdin, null); - assert.strictEqual(w.stdout, null); - assert.strictEqual(w.stderr, null); + assert.strictEqual(w.stdin, stdin); + assert.strictEqual(w.stdout, stdout); + assert.strictEqual(w.stderr, stderr); })); } else { process.exit(0); -- cgit v1.2.3