From 6faede7eb4d1568e79f03bdc4807cce598d30c47 Mon Sep 17 00:00:00 2001 From: Mike Kaufman Date: Thu, 21 Sep 2017 10:55:09 -0700 Subject: test: fixing AliasedBuffer tests to enter Isolate AliasedBuffer tests weren't creating an v8::Isolate::Scope, and this had negative impact on the node-chakracore branch, where expectation is an Isoalte has been Enter()'d before being used. PR-URL: https://github.com/nodejs/node/pull/15536 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig --- test/cctest/test_aliased_buffer.cc | 2 ++ 1 file changed, 2 insertions(+) (limited to 'test') diff --git a/test/cctest/test_aliased_buffer.cc b/test/cctest/test_aliased_buffer.cc index 65b029f2a0..8dfb02c181 100644 --- a/test/cctest/test_aliased_buffer.cc +++ b/test/cctest/test_aliased_buffer.cc @@ -82,6 +82,7 @@ void ReadAndValidate(v8::Isolate* isolate, template void ReadWriteTest(v8::Isolate* isolate) { + v8::Isolate::Scope isolate_scope(isolate); v8::HandleScope handle_scope(isolate); v8::Local context = v8::Context::New(isolate); v8::Context::Scope context_scope(context); @@ -114,6 +115,7 @@ void SharedBufferTest( size_t count_A, size_t count_B, size_t count_C) { + v8::Isolate::Scope isolate_scope(isolate); v8::HandleScope handle_scope(isolate); v8::Local context = v8::Context::New(isolate); v8::Context::Scope context_scope(context); -- cgit v1.2.3