From 2833a0d8b7c3f0f5e80059d7a428328c96cbee54 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sat, 7 Sep 2019 21:56:24 +0200 Subject: worker: make terminate() resolve for unref’ed Workers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Once `worker.terminate()` is called, the Worker instance will be destroyed as soon as possible anyway, so in order to make the Promise returned by `worker.terminate()` resolve always, it should be okay to just call `.ref()` on it and keep the main event loop alive temporarily. PR-URL: https://github.com/nodejs/node/pull/29484 Reviewed-By: Ben Noordhuis Reviewed-By: Colin Ihrig Reviewed-By: Benjamin Gruenbaum --- test/parallel/test-worker-terminate-unrefed.js | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 test/parallel/test-worker-terminate-unrefed.js (limited to 'test') diff --git a/test/parallel/test-worker-terminate-unrefed.js b/test/parallel/test-worker-terminate-unrefed.js new file mode 100644 index 0000000000..adf6bbf145 --- /dev/null +++ b/test/parallel/test-worker-terminate-unrefed.js @@ -0,0 +1,16 @@ +'use strict'; +const common = require('../common'); +const { once } = require('events'); +const { Worker } = require('worker_threads'); + +// Test that calling worker.terminate() on an unref()’ed Worker instance +// still resolves the returned Promise. + +async function test() { + const worker = new Worker('setTimeout(() => {}, 1000000);', { eval: true }); + await once(worker, 'online'); + worker.unref(); + await worker.terminate(); +} + +test().then(common.mustCall()); -- cgit v1.2.3