From 0f0e7f55f86d065b77de5e9d6a91637aac09372a Mon Sep 17 00:00:00 2001 From: LakshmiSwethaG Date: Wed, 16 Jan 2019 05:24:43 -0500 Subject: test: refactor to block-scope PR-URL: https://github.com/nodejs/node/pull/25532 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig --- test/parallel/test-fs-watch-encoding.js | 65 +++++++++++++++++++-------------- 1 file changed, 37 insertions(+), 28 deletions(-) (limited to 'test') diff --git a/test/parallel/test-fs-watch-encoding.js b/test/parallel/test-fs-watch-encoding.js index 1cea625509..13b4dc340e 100644 --- a/test/parallel/test-fs-watch-encoding.js +++ b/test/parallel/test-fs-watch-encoding.js @@ -42,36 +42,45 @@ function unregisterWatcher(watcher) { } } -const watcher1 = fs.watch( - tmpdir.path, - { encoding: 'hex' }, - (event, filename) => { - if (['e696b0e5bbbae69687e5a4b9e4bbb62e747874', null].includes(filename)) - done(watcher1); - } -); -registerWatcher(watcher1); +{ + // Test that using the `encoding` option has the expected result. + const watcher = fs.watch( + tmpdir.path, + { encoding: 'hex' }, + (event, filename) => { + if (['e696b0e5bbbae69687e5a4b9e4bbb62e747874', null].includes(filename)) + done(watcher); + } + ); + registerWatcher(watcher); +} -const watcher2 = fs.watch( - tmpdir.path, - (event, filename) => { - if ([fn, null].includes(filename)) - done(watcher2); - } -); -registerWatcher(watcher2); +{ + // Test that in absence of `encoding` option has the expected result. + const watcher = fs.watch( + tmpdir.path, + (event, filename) => { + if ([fn, null].includes(filename)) + done(watcher); + } + ); + registerWatcher(watcher); +} -const watcher3 = fs.watch( - tmpdir.path, - { encoding: 'buffer' }, - (event, filename) => { - if (filename instanceof Buffer && filename.toString('utf8') === fn) - done(watcher3); - else if (filename === null) - done(watcher3); - } -); -registerWatcher(watcher3); +{ + // Test that using the `encoding` option has the expected result. + const watcher = fs.watch( + tmpdir.path, + { encoding: 'buffer' }, + (event, filename) => { + if (filename instanceof Buffer && filename.toString('utf8') === fn) + done(watcher); + else if (filename === null) + done(watcher); + } + ); + registerWatcher(watcher); +} const done = common.mustCall(unregisterWatcher, watchers.size); -- cgit v1.2.3