From ccd3eadbd7dae3a23d43bf490fa9d3019324370e Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Mon, 22 May 2017 18:03:55 +0200 Subject: stream: fix destroy(err, cb) regression Fixed a regression that caused the callback passed to destroy() to not be called if the stream was already destroyed. This caused a regression on the ws module in CITGM introduced by https://github.com/nodejs/node/pull/12925. PR-URL: https://github.com/nodejs/node/pull/13156 Fixes: https://github.com/websockets/ws/issues/1118 Reviewed-By: Colin Ihrig Reviewed-By: Calvin Metcalf Reviewed-By: Luigi Pinca Reviewed-By: Refael Ackermann --- test/parallel/test-stream-readable-destroy.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'test/parallel/test-stream-readable-destroy.js') diff --git a/test/parallel/test-stream-readable-destroy.js b/test/parallel/test-stream-readable-destroy.js index 800b6be086..def20d26c3 100644 --- a/test/parallel/test-stream-readable-destroy.js +++ b/test/parallel/test-stream-readable-destroy.js @@ -160,3 +160,17 @@ const { inherits } = require('util'); new MyReadable(); } + +{ + // destroy and destroy callback + const read = new Readable({ + read() {} + }); + read.resume(); + + const expected = new Error('kaboom'); + + read.destroy(expected, common.mustCall(function(err) { + assert.strictEqual(expected, err); + })); +} -- cgit v1.2.3