From d022cb1bdd20f10483cbe988a950548df2dfd48c Mon Sep 17 00:00:00 2001 From: Weijia Wang <381152119@qq.com> Date: Wed, 13 Dec 2017 20:48:43 +0800 Subject: lib: combine similar error codes There two similar error codes in lib: "ERR_VALUE_OUT_OF_RANGE" and "ERR_OUT_OF_RANGE". This change is to reduce them into "ERR_VALUE_OUT_OF_RANGE" Fixes: https://github.com/nodejs/node/issues/17603 PR-URL: https://github.com/nodejs/node/pull/17648 Fixes: https://github.com/nodejs/node/issues/17603 Reviewed-By: Timothy Gu Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott Reviewed-By: Jon Moss Reviewed-By: Anatoli Papirovski Reviewed-By: Anna Henningsen --- test/parallel/test-internal-errors.js | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'test/parallel/test-internal-errors.js') diff --git a/test/parallel/test-internal-errors.js b/test/parallel/test-internal-errors.js index 78582a5350..3673749224 100644 --- a/test/parallel/test-internal-errors.js +++ b/test/parallel/test-internal-errors.js @@ -281,8 +281,18 @@ assert.strictEqual( ); assert.strictEqual( - errors.message('ERR_VALUE_OUT_OF_RANGE', ['A', 'some values', 'B']), - 'The value of "A" must be some values. Received "B"' + errors.message('ERR_OUT_OF_RANGE', ['A']), + 'The value of "A" is out of range.' +); + +assert.strictEqual( + errors.message('ERR_OUT_OF_RANGE', ['A', 'some values']), + 'The value of "A" is out of range. It must be some values.' +); + +assert.strictEqual( + errors.message('ERR_OUT_OF_RANGE', ['A', 'some values', 'B']), + 'The value of "A" is out of range. It must be some values. Received B' ); assert.strictEqual( -- cgit v1.2.3