From 0babd181a0c5d775e62a12b3b04fe4d7654fe80a Mon Sep 17 00:00:00 2001 From: James M Snell Date: Tue, 12 Dec 2017 11:34:17 -0800 Subject: http2: cleanup Http2Stream/Http2Session destroy PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina Reviewed-By: Anna Henningsen Reviewed-By: Anatoli Papirovski This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits. --- test/parallel/test-http2-compat-serverresponse-createpushresponse.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'test/parallel/test-http2-compat-serverresponse-createpushresponse.js') diff --git a/test/parallel/test-http2-compat-serverresponse-createpushresponse.js b/test/parallel/test-http2-compat-serverresponse-createpushresponse.js index bd9d5c1399..b168c3563c 100644 --- a/test/parallel/test-http2-compat-serverresponse-createpushresponse.js +++ b/test/parallel/test-http2-compat-serverresponse-createpushresponse.js @@ -43,7 +43,7 @@ const server = h2.createServer((request, response) => { ':path': '/pushed', ':method': 'GET' }, common.mustCall((error) => { - assert.strictEqual(error.code, 'ERR_HTTP2_STREAM_CLOSED'); + assert.strictEqual(error.code, 'ERR_HTTP2_INVALID_STREAM'); })); }); })); @@ -61,7 +61,7 @@ server.listen(0, common.mustCall(() => { let remaining = 2; function maybeClose() { if (--remaining === 0) { - client.destroy(); + client.close(); server.close(); } } -- cgit v1.2.3