From 1699a8ad71195bb3066630d38d16b1df7119a495 Mon Sep 17 00:00:00 2001
From: Adrian Estrada <edsadr@gmail.com>
Date: Thu, 12 Jan 2017 19:27:01 -0500
Subject: test: improve test-fs-write-stream-throw-type

* validate the errors for all assert.throws
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10779
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
---
 .../test-fs-write-stream-throw-type-error.js       | 36 ++++++++++++++--------
 1 file changed, 24 insertions(+), 12 deletions(-)

(limited to 'test/parallel/test-fs-write-stream-throw-type-error.js')

diff --git a/test/parallel/test-fs-write-stream-throw-type-error.js b/test/parallel/test-fs-write-stream-throw-type-error.js
index 996b22119c..940def65b3 100644
--- a/test/parallel/test-fs-write-stream-throw-type-error.js
+++ b/test/parallel/test-fs-write-stream-throw-type-error.js
@@ -4,32 +4,44 @@ const assert = require('assert');
 const fs = require('fs');
 const path = require('path');
 
+const numberError = new RegExp('^TypeError: "options" must be a string ' +
+                               'or an object, got number instead.$');
+
+const booleanError = new RegExp('^TypeError: "options" must be a string ' +
+                                'or an object, got boolean instead.$');
+
 const example = path.join(common.tmpDir, 'dummy');
 
 common.refreshTmpDir();
 
-assert.doesNotThrow(function() {
+assert.doesNotThrow(() => {
   fs.createWriteStream(example, undefined);
 });
-assert.doesNotThrow(function() {
+
+assert.doesNotThrow(() => {
   fs.createWriteStream(example, null);
 });
-assert.doesNotThrow(function() {
+
+assert.doesNotThrow(() => {
   fs.createWriteStream(example, 'utf8');
 });
-assert.doesNotThrow(function() {
+
+assert.doesNotThrow(() => {
   fs.createWriteStream(example, {encoding: 'utf8'});
 });
 
-assert.throws(function() {
+assert.throws(() => {
   fs.createWriteStream(example, 123);
-}, /"options" must be a string or an object/);
-assert.throws(function() {
+}, numberError);
+
+assert.throws(() => {
   fs.createWriteStream(example, 0);
-}, /"options" must be a string or an object/);
-assert.throws(function() {
+}, numberError);
+
+assert.throws(() => {
   fs.createWriteStream(example, true);
-}, /"options" must be a string or an object/);
-assert.throws(function() {
+}, booleanError);
+
+assert.throws(() => {
   fs.createWriteStream(example, false);
-}, /"options" must be a string or an object/);
+}, booleanError);
-- 
cgit v1.2.3