From 810af50ba2ab20e006a9e480b911c763f001ce8e Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sat, 12 May 2018 22:15:06 -0400 Subject: assert: support symbols as assertion messages Currently, assertion messages are implicitly converted to strings, which causes symbols to throw. This commit adds an explicit string conversion. PR-URL: https://github.com/nodejs/node/pull/20693 Reviewed-By: Daniel Bevenius Reviewed-By: Luigi Pinca Reviewed-By: Ruben Bridgewater Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell --- test/parallel/test-assert.js | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'test/parallel/test-assert.js') diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js index bf9d6c6eb4..51c9e677b1 100644 --- a/test/parallel/test-assert.js +++ b/test/parallel/test-assert.js @@ -640,6 +640,16 @@ common.expectsError( } ); +common.expectsError( + () => assert(false, Symbol('foo')), + { + code: 'ERR_ASSERTION', + type: assert.AssertionError, + generatedMessage: false, + message: 'Symbol(foo)' + } +); + { // Test caching. const fs = process.binding('fs'); -- cgit v1.2.3