From 710110788b92311a9a012ede812ac87ffa00cad2 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Wed, 11 Apr 2018 03:28:35 +0200 Subject: assert: fix actual & expected input This makes sure the actual and expected values on the error thrown by `assert.throws` etc. are always as they should be. PR-URL: https://github.com/nodejs/node/pull/19925 Reviewed-By: Matteo Collina Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell --- test/parallel/test-assert.js | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) (limited to 'test/parallel/test-assert.js') diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js index c061551604..478945156e 100644 --- a/test/parallel/test-assert.js +++ b/test/parallel/test-assert.js @@ -192,32 +192,40 @@ a.throws(() => thrower(TypeError), (err) => { const noop = () => {}; assert.throws( () => { a.throws((noop)); }, - common.expectsError({ + { code: 'ERR_ASSERTION', - message: /^Missing expected exception\.$/, - operator: 'throws' - })); + message: 'Missing expected exception.', + operator: 'throws', + actual: undefined, + expected: undefined + }); assert.throws( () => { a.throws(noop, TypeError); }, - common.expectsError({ + { code: 'ERR_ASSERTION', - message: /^Missing expected exception \(TypeError\)\.$/ - })); + message: 'Missing expected exception (TypeError).', + actual: undefined, + expected: TypeError + }); assert.throws( () => { a.throws(noop, 'fhqwhgads'); }, - common.expectsError({ + { code: 'ERR_ASSERTION', - message: /^Missing expected exception: fhqwhgads$/ - })); + message: 'Missing expected exception: fhqwhgads', + actual: undefined, + expected: undefined + }); assert.throws( () => { a.throws(noop, TypeError, 'fhqwhgads'); }, - common.expectsError({ + { code: 'ERR_ASSERTION', - message: /^Missing expected exception \(TypeError\): fhqwhgads$/ - })); + message: 'Missing expected exception (TypeError): fhqwhgads', + actual: undefined, + expected: TypeError + }); let threw = false; try { -- cgit v1.2.3